| Message ID | 20230804155323.198234-1-ada@thorsis.com |
|---|---|
| State | Accepted |
| Commit | 8ba4eae01da11e73e7ee9f7047979f4d2ebfe5fc |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | cmd: cyclic: Remove duplicate command name in help text | expand |
On 8/4/23 17:53, Alexander Dahl wrote: > Function 'cmd_usage()' already prints one command in usage before > printing out the help text given to the U_BOOT_CMD_WITH_SUBCMDS macro. > > Wrong previous output: > > Usage: > cyclic cyclic demo <cycletime_ms> <delay_us> - register cyclic demo function > cyclic list - list cyclic functions > > Signed-off-by: Alexander Dahl <ada@thorsis.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > cmd/cyclic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/cyclic.c b/cmd/cyclic.c > index 97324d8240..946f1d7818 100644 > --- a/cmd/cyclic.c > +++ b/cmd/cyclic.c > @@ -77,7 +77,7 @@ static int do_cyclic_list(struct cmd_tbl *cmdtp, int flag, int argc, > } > > static char cyclic_help_text[] = > - "cyclic demo <cycletime_ms> <delay_us> - register cyclic demo function\n" > + "demo <cycletime_ms> <delay_us> - register cyclic demo function\n" > "cyclic list - list cyclic functions\n"; > > U_BOOT_CMD_WITH_SUBCMDS(cyclic, "Cyclic", cyclic_help_text, > > base-commit: 989892f5805dc205033c4723bc8e024472564d16 Viele Grüße, Stefan Roese
On 8/4/23 17:53, Alexander Dahl wrote: > Function 'cmd_usage()' already prints one command in usage before > printing out the help text given to the U_BOOT_CMD_WITH_SUBCMDS macro. > > Wrong previous output: > > Usage: > cyclic cyclic demo <cycletime_ms> <delay_us> - register cyclic demo function > cyclic list - list cyclic functions > > Signed-off-by: Alexander Dahl <ada@thorsis.com> Applied to u-boot-watchdog/master Thanks, Stefan > --- > cmd/cyclic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/cmd/cyclic.c b/cmd/cyclic.c > index 97324d8240..946f1d7818 100644 > --- a/cmd/cyclic.c > +++ b/cmd/cyclic.c > @@ -77,7 +77,7 @@ static int do_cyclic_list(struct cmd_tbl *cmdtp, int flag, int argc, > } > > static char cyclic_help_text[] = > - "cyclic demo <cycletime_ms> <delay_us> - register cyclic demo function\n" > + "demo <cycletime_ms> <delay_us> - register cyclic demo function\n" > "cyclic list - list cyclic functions\n"; > > U_BOOT_CMD_WITH_SUBCMDS(cyclic, "Cyclic", cyclic_help_text, > > base-commit: 989892f5805dc205033c4723bc8e024472564d16 Viele Grüße, Stefan Roese
diff --git a/cmd/cyclic.c b/cmd/cyclic.c index 97324d8240..946f1d7818 100644 --- a/cmd/cyclic.c +++ b/cmd/cyclic.c @@ -77,7 +77,7 @@ static int do_cyclic_list(struct cmd_tbl *cmdtp, int flag, int argc, } static char cyclic_help_text[] = - "cyclic demo <cycletime_ms> <delay_us> - register cyclic demo function\n" + "demo <cycletime_ms> <delay_us> - register cyclic demo function\n" "cyclic list - list cyclic functions\n"; U_BOOT_CMD_WITH_SUBCMDS(cyclic, "Cyclic", cyclic_help_text,
Function 'cmd_usage()' already prints one command in usage before printing out the help text given to the U_BOOT_CMD_WITH_SUBCMDS macro. Wrong previous output: Usage: cyclic cyclic demo <cycletime_ms> <delay_us> - register cyclic demo function cyclic list - list cyclic functions Signed-off-by: Alexander Dahl <ada@thorsis.com> --- cmd/cyclic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 989892f5805dc205033c4723bc8e024472564d16