| Message ID | 20230803110813.175956-4-massimo.pegorer+oss@gmail.com |
|---|---|
| State | Accepted |
| Commit | c71321c7c6ee2a284dd66b949747e91e9cb75341 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: rk3308: Fix two minor UART warnings | expand |
On 2023/8/3 19:08, Massimo Pegorer wrote: > Make device tree complete and consistent for pre relocation phase. Some > nodes are missing, causing warnings to be issued on serial port probing > during pre relocation phase (uclass_get_device_by_phandle_id fails when > called by pinctrl_select_state_full: none of these failures is fatal > nor causing issues). Add to *-u-boot.dtsi all required nodes with the > 'bootph-some-ram' attribute. > > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi b/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi > index 61415559b7..d88dee8057 100644 > --- a/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi > +++ b/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi > @@ -13,3 +13,30 @@ > &uart0 { > bootph-all; > }; > + > +&pinctrl { > + bootph-some-ram; > + > + uart0 { > + bootph-some-ram; > + }; > + rtc { > + bootph-some-ram; > + }; > +}; > + > +&uart0_xfer { > + bootph-some-ram; > +}; > + > +&uart0_cts { > + bootph-some-ram; > +}; > + > +&uart0_rts { > + bootph-some-ram; > +}; > + > +&rtc_32k { > + bootph-some-ram; > +};
diff --git a/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi b/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi index 61415559b7..d88dee8057 100644 --- a/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi +++ b/arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi @@ -13,3 +13,30 @@ &uart0 { bootph-all; }; + +&pinctrl { + bootph-some-ram; + + uart0 { + bootph-some-ram; + }; + rtc { + bootph-some-ram; + }; +}; + +&uart0_xfer { + bootph-some-ram; +}; + +&uart0_cts { + bootph-some-ram; +}; + +&uart0_rts { + bootph-some-ram; +}; + +&rtc_32k { + bootph-some-ram; +};
Make device tree complete and consistent for pre relocation phase. Some nodes are missing, causing warnings to be issued on serial port probing during pre relocation phase (uclass_get_device_by_phandle_id fails when called by pinctrl_select_state_full: none of these failures is fatal nor causing issues). Add to *-u-boot.dtsi all required nodes with the 'bootph-some-ram' attribute. Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com> --- arch/arm/dts/rk3308-rock-pi-s-u-boot.dtsi | 27 +++++++++++++++++++++++ 1 file changed, 27 insertions(+)