| Message ID | 20230801072811.10354-7-eugen.hristev@collabora.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: rk3588: add support for DFU in SPL | expand |
Hi Eugen, On 2023/8/1 15:28, Eugen Hristev wrote: > Add bootph-all to gadget nodes to have the gadget available in SPL. Does this gadget available on both USB2 and USB3? I think only USB2 is enough? Thanks, - Kever > > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > index 5a3292699640..f453aeeaf526 100644 > --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > @@ -221,10 +221,12 @@ > }; > > &u2phy0 { > + bootph-all; > status = "okay"; > }; > > &u2phy0_otg { > + bootph-all; > rockchip,typec-vbus-det; > status = "okay"; > }; > @@ -271,6 +273,7 @@ > }; > > &usbdp_phy0 { > + bootph-all; > orientation-switch; > svid = <0xff01>; > sbu1-dc-gpios = <&gpio4 RK_PA6 GPIO_ACTIVE_HIGH>; > @@ -293,14 +296,17 @@ > }; > > &usbdp_phy0_u3 { > + bootph-all; > status = "okay"; > }; > > &usbdrd3_0 { > + bootph-all; > status = "okay"; > }; > > &usbdrd_dwc3_0 { > + bootph-all; > dr_mode = "otg"; > usb-role-switch; >
On 8/12/23 05:53, Kever Yang wrote: > Hi Eugen, > > On 2023/8/1 15:28, Eugen Hristev wrote: >> Add bootph-all to gadget nodes to have the gadget available in SPL. > > Does this gadget available on both USB2 and USB3? I think only USB2 is > enough? > Hi Kever, This board has one USB type C that is connected on USB3. This type C port is used for maskrom, to flash using rkdeveloptool and to power the board. It is only natural that this port is used for gadget, because everyone who boot this board, use rockusb to boot, will already have a cable connected to the host. Also, on this device RK3588 USB2 controller does not support gadget mode, only host, so I am forced to use USB3 anyway. Eugen > > Thanks, > > - Kever > >> >> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> >> --- >> arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi >> b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi >> index 5a3292699640..f453aeeaf526 100644 >> --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi >> +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi >> @@ -221,10 +221,12 @@ >> }; >> &u2phy0 { >> + bootph-all; >> status = "okay"; >> }; >> &u2phy0_otg { >> + bootph-all; >> rockchip,typec-vbus-det; >> status = "okay"; >> }; >> @@ -271,6 +273,7 @@ >> }; >> &usbdp_phy0 { >> + bootph-all; >> orientation-switch; >> svid = <0xff01>; >> sbu1-dc-gpios = <&gpio4 RK_PA6 GPIO_ACTIVE_HIGH>; >> @@ -293,14 +296,17 @@ >> }; >> &usbdp_phy0_u3 { >> + bootph-all; >> status = "okay"; >> }; >> &usbdrd3_0 { >> + bootph-all; >> status = "okay"; >> }; >> &usbdrd_dwc3_0 { >> + bootph-all; >> dr_mode = "otg"; >> usb-role-switch;
diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi index 5a3292699640..f453aeeaf526 100644 --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi @@ -221,10 +221,12 @@ }; &u2phy0 { + bootph-all; status = "okay"; }; &u2phy0_otg { + bootph-all; rockchip,typec-vbus-det; status = "okay"; }; @@ -271,6 +273,7 @@ }; &usbdp_phy0 { + bootph-all; orientation-switch; svid = <0xff01>; sbu1-dc-gpios = <&gpio4 RK_PA6 GPIO_ACTIVE_HIGH>; @@ -293,14 +296,17 @@ }; &usbdp_phy0_u3 { + bootph-all; status = "okay"; }; &usbdrd3_0 { + bootph-all; status = "okay"; }; &usbdrd_dwc3_0 { + bootph-all; dr_mode = "otg"; usb-role-switch;
Add bootph-all to gadget nodes to have the gadget available in SPL. Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)