diff mbox series

[3/5] ARM: dts: at91: sam9x60: Change i2c compatible

Message ID 20230705201701.322372-4-post@lespocky.de
State Accepted
Commit cdbd40dbb558f81c0f46b809fab0259dd92fd412
Delegated to: Eugen Hristev
Headers show
Series ARM: dts: at91: Improve sam9x60-curiosity | expand

Commit Message

Alexander Dahl July 5, 2023, 8:16 p.m. UTC
From: Alexander Dahl <ada@thorsis.com>

There's a more specific compatible string for the i2c interface, use it.

Signed-off-by: Alexander Dahl <ada@thorsis.com>
---

Notes:
    I²C access to the eeprom did not work though, neither before nor after
    this change.

 arch/arm/dts/at91-sam9x60_curiosity.dts | 2 +-
 arch/arm/dts/sam9x60ek.dts              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Durai Manickam KR July 6, 2023, 8:32 a.m. UTC | #1
Hi Alexander,

sam9x60_curiosity and sam9x60ek belongs to same SOC family. So the 
compatible string is updated as "microchip,sam9x60-i2c" in the 
sam9x60.dtsi file. These changes are available in linux-6.4.y branch.

On 06/07/23 01:46, Alexander Dahl wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Alexander Dahl <ada@thorsis.com>
>
> There's a more specific compatible string for the i2c interface, use it.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
>
> Notes:
>      I²C access to the eeprom did not work though, neither before nor after
>      this change.
>
>   arch/arm/dts/at91-sam9x60_curiosity.dts | 2 +-
>   arch/arm/dts/sam9x60ek.dts              | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/at91-sam9x60_curiosity.dts b/arch/arm/dts/at91-sam9x60_curiosity.dts
> index da5e19b66b..ae707dd64b 100644
> --- a/arch/arm/dts/at91-sam9x60_curiosity.dts
> +++ b/arch/arm/dts/at91-sam9x60_curiosity.dts
> @@ -21,7 +21,7 @@
>                                  status = "okay";
>
>                                  i2c@600 {
> -                                       compatible = "atmel,sama5d2-i2c";
> +                                       compatible = "microchip,sam9x60-i2c";
>                                          reg = <0x600 0x200>;
>                                          pinctrl-names = "default";
>                                          pinctrl-0 = <&pinctrl_flx0>;
> diff --git a/arch/arm/dts/sam9x60ek.dts b/arch/arm/dts/sam9x60ek.dts
> index 45e2f4cc40..74016f5e28 100644
> --- a/arch/arm/dts/sam9x60ek.dts
> +++ b/arch/arm/dts/sam9x60ek.dts
> @@ -62,7 +62,7 @@
>                                  status = "okay";
>
>                                  i2c@600 {
> -                                       compatible = "atmel,sama5d2-i2c";
> +                                       compatible = "microchip,sam9x60-i2c";
>                                          reg = <0x600 0x200>;
>                                          pinctrl-names = "default";
>                                          pinctrl-0 = <&pinctrl_flx0>;
> --
> 2.30.2
>
Alexander Dahl July 6, 2023, 8:59 a.m. UTC | #2
Hello,

Am Thu, Jul 06, 2023 at 08:32:41AM +0000 schrieb Durai.ManickamKR@microchip.com:
> Hi Alexander,
> 
> sam9x60_curiosity and sam9x60ek belongs to same SOC family. So the 
> compatible string is updated as "microchip,sam9x60-i2c" in the 
> sam9x60.dtsi file. These changes are available in linux-6.4.y branch.

Maybe I was not clear enough.  We are talking about U-Boot here.  The
whole patch series is for U-Boot and based on U-Boot v2023.07-rc6.
I'm on Linux v6.4 already and things work in Linux.  The problem I
have is with EEPROM access in U-Boot.

Greets
Alex

> 
> On 06/07/23 01:46, Alexander Dahl wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > From: Alexander Dahl <ada@thorsis.com>
> >
> > There's a more specific compatible string for the i2c interface, use it.
> >
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > ---
> >
> > Notes:
> >      I²C access to the eeprom did not work though, neither before nor after
> >      this change.
> >
> >   arch/arm/dts/at91-sam9x60_curiosity.dts | 2 +-
> >   arch/arm/dts/sam9x60ek.dts              | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/dts/at91-sam9x60_curiosity.dts b/arch/arm/dts/at91-sam9x60_curiosity.dts
> > index da5e19b66b..ae707dd64b 100644
> > --- a/arch/arm/dts/at91-sam9x60_curiosity.dts
> > +++ b/arch/arm/dts/at91-sam9x60_curiosity.dts
> > @@ -21,7 +21,7 @@
> >                                  status = "okay";
> >
> >                                  i2c@600 {
> > -                                       compatible = "atmel,sama5d2-i2c";
> > +                                       compatible = "microchip,sam9x60-i2c";
> >                                          reg = <0x600 0x200>;
> >                                          pinctrl-names = "default";
> >                                          pinctrl-0 = <&pinctrl_flx0>;
> > diff --git a/arch/arm/dts/sam9x60ek.dts b/arch/arm/dts/sam9x60ek.dts
> > index 45e2f4cc40..74016f5e28 100644
> > --- a/arch/arm/dts/sam9x60ek.dts
> > +++ b/arch/arm/dts/sam9x60ek.dts
> > @@ -62,7 +62,7 @@
> >                                  status = "okay";
> >
> >                                  i2c@600 {
> > -                                       compatible = "atmel,sama5d2-i2c";
> > +                                       compatible = "microchip,sam9x60-i2c";
> >                                          reg = <0x600 0x200>;
> >                                          pinctrl-names = "default";
> >                                          pinctrl-0 = <&pinctrl_flx0>;
> > --
> > 2.30.2
> >
Durai Manickam KR July 6, 2023, 9:09 a.m. UTC | #3
Sorry! misunderstood as kernel. Ignore this comment.

On 06/07/23 14:02, Durai Manickam KR wrote:
> Hi Alexander,
>
> sam9x60_curiosity and sam9x60ek belongs to same SOC family. So the 
> compatible string is updated as "microchip,sam9x60-i2c" in the 
> sam9x60.dtsi file. These changes are available in linux-6.4.y branch.
>
> On 06/07/23 01:46, Alexander Dahl wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you 
>> know the content is safe
>>
>> From: Alexander Dahl <ada@thorsis.com>
>>
>> There's a more specific compatible string for the i2c interface, use it.
>>
>> Signed-off-by: Alexander Dahl <ada@thorsis.com>
>> ---
>>
>> Notes:
>>      I²C access to the eeprom did not work though, neither before nor 
>> after
>>      this change.
>>
>>   arch/arm/dts/at91-sam9x60_curiosity.dts | 2 +-
>>   arch/arm/dts/sam9x60ek.dts              | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/dts/at91-sam9x60_curiosity.dts 
>> b/arch/arm/dts/at91-sam9x60_curiosity.dts
>> index da5e19b66b..ae707dd64b 100644
>> --- a/arch/arm/dts/at91-sam9x60_curiosity.dts
>> +++ b/arch/arm/dts/at91-sam9x60_curiosity.dts
>> @@ -21,7 +21,7 @@
>>                                  status = "okay";
>>
>>                                  i2c@600 {
>> -                                       compatible = 
>> "atmel,sama5d2-i2c";
>> +                                       compatible = 
>> "microchip,sam9x60-i2c";
>>                                          reg = <0x600 0x200>;
>>                                          pinctrl-names = "default";
>>                                          pinctrl-0 = <&pinctrl_flx0>;
>> diff --git a/arch/arm/dts/sam9x60ek.dts b/arch/arm/dts/sam9x60ek.dts
>> index 45e2f4cc40..74016f5e28 100644
>> --- a/arch/arm/dts/sam9x60ek.dts
>> +++ b/arch/arm/dts/sam9x60ek.dts
>> @@ -62,7 +62,7 @@
>>                                  status = "okay";
>>
>>                                  i2c@600 {
>> -                                       compatible = 
>> "atmel,sama5d2-i2c";
>> +                                       compatible = 
>> "microchip,sam9x60-i2c";
>>                                          reg = <0x600 0x200>;
>>                                          pinctrl-names = "default";
>>                                          pinctrl-0 = <&pinctrl_flx0>;
>> -- 
>> 2.30.2
>>
diff mbox series

Patch

diff --git a/arch/arm/dts/at91-sam9x60_curiosity.dts b/arch/arm/dts/at91-sam9x60_curiosity.dts
index da5e19b66b..ae707dd64b 100644
--- a/arch/arm/dts/at91-sam9x60_curiosity.dts
+++ b/arch/arm/dts/at91-sam9x60_curiosity.dts
@@ -21,7 +21,7 @@ 
 				status = "okay";
 
 				i2c@600 {
-					compatible = "atmel,sama5d2-i2c";
+					compatible = "microchip,sam9x60-i2c";
 					reg = <0x600 0x200>;
 					pinctrl-names = "default";
 					pinctrl-0 = <&pinctrl_flx0>;
diff --git a/arch/arm/dts/sam9x60ek.dts b/arch/arm/dts/sam9x60ek.dts
index 45e2f4cc40..74016f5e28 100644
--- a/arch/arm/dts/sam9x60ek.dts
+++ b/arch/arm/dts/sam9x60ek.dts
@@ -62,7 +62,7 @@ 
 				status = "okay";
 
 				i2c@600 {
-					compatible = "atmel,sama5d2-i2c";
+					compatible = "microchip,sam9x60-i2c";
 					reg = <0x600 0x200>;
 					pinctrl-names = "default";
 					pinctrl-0 = <&pinctrl_flx0>;