| Message ID | 20230605094825.160337-4-joy.zou@nxp.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | support trimed pca9450 new pmic | expand |
> -----Original Message----- > From: Marek Vasut <marex@denx.de> > Sent: 2023年6月5日 18:05 > To: Joy Zou <joy.zou@nxp.com>; jh80.chung@samsung.com; Peng Fan > <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai <ping.bai@nxp.com>; > festevam@denx.de; sbabic@denx.de; heiko.thiery@gmail.com > Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> > Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 6/5/23 11:48, Joy Zou wrote: > > ARM: dts: imx93: ... > (not DTS:) Okay, thanks! Will change it in patch v2. > > > The new pmic trimed BUCK1. So need to modify the range. > > There is no LDO2 and LDO3, So need to delete the property. > > > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > > --- > > arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------ > > 1 file changed, 2 insertions(+), 18 deletions(-) > > > > diff --git a/arch/arm/dts/imx93-11x11-evk.dts > > b/arch/arm/dts/imx93-11x11-evk.dts > > index b3a5a3d71e..ceab56a5d8 100644 > > --- a/arch/arm/dts/imx93-11x11-evk.dts > > +++ b/arch/arm/dts/imx93-11x11-evk.dts > > @@ -141,8 +141,8 @@ > > regulators { > > buck1: BUCK1 { > > regulator-name = "BUCK1"; > > - regulator-min-microvolt = <600000>; > > - regulator-max-microvolt = <2187500>; > > + regulator-min-microvolt = <650000>; > > + regulator-max-microvolt = <2237500>; > > Where does this patch come from ? Linux ? If Linux, then include commit hash > of that commit from Linux kernel in the commit message. If not from Linux, > why is there no matching fix in Linux ? This patch com from linux. I will add commit hash form Linux kernel. Thanks! BR Joy zou
> -----Original Message----- > From: Joy Zou > Sent: 2023年6月5日 18:24 > To: Marek Vasut <marex@denx.de>; jh80.chung@samsung.com; Peng Fan > <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai <ping.bai@nxp.com>; > festevam@denx.de; sbabic@denx.de; heiko.thiery@gmail.com > Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> > Subject: RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage > range > > > > -----Original Message----- > > From: Marek Vasut <marex@denx.de> > > Sent: 2023年6月5日 18:05 > > To: Joy Zou <joy.zou@nxp.com>; jh80.chung@samsung.com; Peng Fan > > <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai > > <ping.bai@nxp.com>; festevam@denx.de; sbabic@denx.de; > > heiko.thiery@gmail.com > > Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> > > Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage > > range > > > > Caution: This is an external email. Please take care when clicking > > links or opening attachments. When in doubt, report the message using > > the 'Report this email' button > > > > > > On 6/5/23 11:48, Joy Zou wrote: > > > > ARM: dts: imx93: ... > > (not DTS:) > Okay, thanks! > Will change it in patch v2. > > > > > The new pmic trimed BUCK1. So need to modify the range. > > > There is no LDO2 and LDO3, So need to delete the property. > > > > > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > > > --- > > > arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------ > > > 1 file changed, 2 insertions(+), 18 deletions(-) > > > > > > diff --git a/arch/arm/dts/imx93-11x11-evk.dts > > > b/arch/arm/dts/imx93-11x11-evk.dts > > > index b3a5a3d71e..ceab56a5d8 100644 > > > --- a/arch/arm/dts/imx93-11x11-evk.dts > > > +++ b/arch/arm/dts/imx93-11x11-evk.dts > > > @@ -141,8 +141,8 @@ > > > regulators { > > > buck1: BUCK1 { > > > regulator-name = "BUCK1"; > > > - regulator-min-microvolt = <600000>; > > > - regulator-max-microvolt = <2187500>; > > > + regulator-min-microvolt = <650000>; > > > + regulator-max-microvolt = <2237500>; > > > > Where does this patch come from ? Linux ? If Linux, then include > > commit hash of that commit from Linux kernel in the commit message. If > > not from Linux, why is there no matching fix in Linux ? > This patch com from linux. I will add commit hash form Linux kernel. > Thanks! I am sorry! Please ignore the previous reply. This patch only come from my local linux kernel. The linux kernel patch also is reviewing. So I need add commit hash after the linux kernel patch accepted? Thanks ! BR Joy Zou > BR > Joy zou
On 6/6/23 08:09, Joy Zou wrote: > >> -----Original Message----- >> From: Joy Zou >> Sent: 2023年6月5日 18:24 >> To: Marek Vasut <marex@denx.de>; jh80.chung@samsung.com; Peng Fan >> <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai <ping.bai@nxp.com>; >> festevam@denx.de; sbabic@denx.de; heiko.thiery@gmail.com >> Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> >> Subject: RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage >> range >> >> >>> -----Original Message----- >>> From: Marek Vasut <marex@denx.de> >>> Sent: 2023年6月5日 18:05 >>> To: Joy Zou <joy.zou@nxp.com>; jh80.chung@samsung.com; Peng Fan >>> <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai >>> <ping.bai@nxp.com>; festevam@denx.de; sbabic@denx.de; >>> heiko.thiery@gmail.com >>> Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> >>> Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage >>> range >>> >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using >>> the 'Report this email' button >>> >>> >>> On 6/5/23 11:48, Joy Zou wrote: >>> >>> ARM: dts: imx93: ... >>> (not DTS:) >> Okay, thanks! >> Will change it in patch v2. >>> >>>> The new pmic trimed BUCK1. So need to modify the range. >>>> There is no LDO2 and LDO3, So need to delete the property. >>>> >>>> Signed-off-by: Joy Zou <joy.zou@nxp.com> >>>> --- >>>> arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------ >>>> 1 file changed, 2 insertions(+), 18 deletions(-) >>>> >>>> diff --git a/arch/arm/dts/imx93-11x11-evk.dts >>>> b/arch/arm/dts/imx93-11x11-evk.dts >>>> index b3a5a3d71e..ceab56a5d8 100644 >>>> --- a/arch/arm/dts/imx93-11x11-evk.dts >>>> +++ b/arch/arm/dts/imx93-11x11-evk.dts >>>> @@ -141,8 +141,8 @@ >>>> regulators { >>>> buck1: BUCK1 { >>>> regulator-name = "BUCK1"; >>>> - regulator-min-microvolt = <600000>; >>>> - regulator-max-microvolt = <2187500>; >>>> + regulator-min-microvolt = <650000>; >>>> + regulator-max-microvolt = <2237500>; >>> >>> Where does this patch come from ? Linux ? If Linux, then include >>> commit hash of that commit from Linux kernel in the commit message. If >>> not from Linux, why is there no matching fix in Linux ? >> This patch com from linux. I will add commit hash form Linux kernel. >> Thanks! > I am sorry! Please ignore the previous reply. This patch only come from my local linux kernel. > The linux kernel patch also is reviewing. > So I need add commit hash after the linux kernel patch accepted? Link to lore.kernel.org would be fine too.
> -----Original Message----- > From: Marek Vasut <marex@denx.de> > Sent: 2023年6月6日 17:28 > To: Joy Zou <joy.zou@nxp.com>; jh80.chung@samsung.com; Peng Fan > <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai <ping.bai@nxp.com>; > festevam@denx.de; sbabic@denx.de; heiko.thiery@gmail.com > Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> > Subject: Re: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage > range > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 6/6/23 08:09, Joy Zou wrote: > > > >> -----Original Message----- > >> From: Joy Zou > >> Sent: 2023年6月5日 18:24 > >> To: Marek Vasut <marex@denx.de>; jh80.chung@samsung.com; Peng Fan > >> <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai > >> <ping.bai@nxp.com>; festevam@denx.de; sbabic@denx.de; > >> heiko.thiery@gmail.com > >> Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> > >> Subject: RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 > >> voltage range > >> > >> > >>> -----Original Message----- > >>> From: Marek Vasut <marex@denx.de> > >>> Sent: 2023年6月5日 18:05 > >>> To: Joy Zou <joy.zou@nxp.com>; jh80.chung@samsung.com; Peng Fan > >>> <peng.fan@nxp.com>; Ye Li <ye.li@nxp.com>; Jacky Bai > >>> <ping.bai@nxp.com>; festevam@denx.de; sbabic@denx.de; > >>> heiko.thiery@gmail.com > >>> Cc: u-boot@lists.denx.de; dl-uboot-imx <uboot-imx@nxp.com> > >>> Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 > >>> voltage range > >>> > >>> Caution: This is an external email. Please take care when clicking > >>> links or opening attachments. When in doubt, report the message > >>> using the 'Report this email' button > >>> > >>> > >>> On 6/5/23 11:48, Joy Zou wrote: > >>> > >>> ARM: dts: imx93: ... > >>> (not DTS:) > >> Okay, thanks! > >> Will change it in patch v2. > >>> > >>>> The new pmic trimed BUCK1. So need to modify the range. > >>>> There is no LDO2 and LDO3, So need to delete the property. > >>>> > >>>> Signed-off-by: Joy Zou <joy.zou@nxp.com> > >>>> --- > >>>> arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------ > >>>> 1 file changed, 2 insertions(+), 18 deletions(-) > >>>> > >>>> diff --git a/arch/arm/dts/imx93-11x11-evk.dts > >>>> b/arch/arm/dts/imx93-11x11-evk.dts > >>>> index b3a5a3d71e..ceab56a5d8 100644 > >>>> --- a/arch/arm/dts/imx93-11x11-evk.dts > >>>> +++ b/arch/arm/dts/imx93-11x11-evk.dts > >>>> @@ -141,8 +141,8 @@ > >>>> regulators { > >>>> buck1: BUCK1 { > >>>> regulator-name = "BUCK1"; > >>>> - regulator-min-microvolt = <600000>; > >>>> - regulator-max-microvolt = <2187500>; > >>>> + regulator-min-microvolt = <650000>; > >>>> + regulator-max-microvolt = > <2237500>; > >>> > >>> Where does this patch come from ? Linux ? If Linux, then include > >>> commit hash of that commit from Linux kernel in the commit message. > >>> If not from Linux, why is there no matching fix in Linux ? > >> This patch com from linux. I will add commit hash form Linux kernel. > >> Thanks! > > I am sorry! Please ignore the previous reply. This patch only come from my > local linux kernel. > > The linux kernel patch also is reviewing. > > So I need add commit hash after the linux kernel patch accepted? > > Link to lore.kernel.org would be fine too. Okay，Thanks! BR Joy Zou
diff --git a/arch/arm/dts/imx93-11x11-evk.dts b/arch/arm/dts/imx93-11x11-evk.dts index b3a5a3d71e..ceab56a5d8 100644 --- a/arch/arm/dts/imx93-11x11-evk.dts +++ b/arch/arm/dts/imx93-11x11-evk.dts @@ -141,8 +141,8 @@ regulators { buck1: BUCK1 { regulator-name = "BUCK1"; - regulator-min-microvolt = <600000>; - regulator-max-microvolt = <2187500>; + regulator-min-microvolt = <650000>; + regulator-max-microvolt = <2237500>; regulator-boot-on; regulator-always-on; regulator-ramp-delay = <3125>; @@ -189,22 +189,6 @@ regulator-always-on; }; - ldo2: LDO2 { - regulator-name = "LDO2"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1150000>; - regulator-boot-on; - regulator-always-on; - }; - - ldo3: LDO3 { - regulator-name = "LDO3"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <3300000>; - regulator-boot-on; - regulator-always-on; - }; - ldo4: LDO4 { regulator-name = "LDO4"; regulator-min-microvolt = <800000>;
The new pmic trimed BUCK1. So need to modify the range. There is no LDO2 and LDO3, So need to delete the property. Signed-off-by: Joy Zou <joy.zou@nxp.com> --- arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-)