diff mbox series

[v1,3/3] arch/arm64: meson-a1: dts: move pwrc node to bus

Message ID 20230522120941.63962-4-avromanov@sberdevices.ru
State New
Delegated to: Neil Armstrong
Headers show
Series Meson Secure PWRC Driver | expand

Commit Message

Alexey Romanov May 22, 2023, 12:09 p.m. UTC
This is necessary so that pwrc can be used together with
peripherals when described in a bus node. For example,
in the future, this will be USB.

Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
---
 arch/arm/dts/meson-a1.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Neil Armstrong May 30, 2023, 3:52 p.m. UTC | #1
Hi,

On 22/05/2023 14:09, Alexey Romanov via groups.io wrote:
> This is necessary so that pwrc can be used together with
> peripherals when described in a bus node. For example,
> in the future, this will be USB.
> 
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> ---
>   arch/arm/dts/meson-a1.dtsi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/dts/meson-a1.dtsi b/arch/arm/dts/meson-a1.dtsi
> index 9776b2d8798..f3560cbc3a4 100644
> --- a/arch/arm/dts/meson-a1.dtsi
> +++ b/arch/arm/dts/meson-a1.dtsi
> @@ -65,12 +65,6 @@
>   
>   	sm: secure-monitor {
>   		compatible = "amlogic,meson-gxbb-sm";
> -
> -		pwrc: power-controller {
> -			compatible = "amlogic,meson-a1-pwrc";
> -			#power-domain-cells = <1>;
> -			status = "okay";
> -		};
>   	};
>   
>   	soc {
> @@ -161,6 +155,12 @@
>   			#address-cells = <0>;
>   		};
>   
> +		pwrc: power-controller {
> +			compatible = "amlogic,meson-a1-pwrc";
> +			#power-domain-cells = <1>;
> +			status = "okay";
> +		};
> +
>   		usb: usb@fe004400 {
>   			compatible = "amlogic,meson-a1-usb-ctrl";
>   			reg = <0x0 0xfe004400 0x0 0xa0>;

The DT should be the same as Linux, so there's no reason why this would be moved out of the SM node.

Neil
diff mbox series

Patch

diff --git a/arch/arm/dts/meson-a1.dtsi b/arch/arm/dts/meson-a1.dtsi
index 9776b2d8798..f3560cbc3a4 100644
--- a/arch/arm/dts/meson-a1.dtsi
+++ b/arch/arm/dts/meson-a1.dtsi
@@ -65,12 +65,6 @@ 
 
 	sm: secure-monitor {
 		compatible = "amlogic,meson-gxbb-sm";
-
-		pwrc: power-controller {
-			compatible = "amlogic,meson-a1-pwrc";
-			#power-domain-cells = <1>;
-			status = "okay";
-		};
 	};
 
 	soc {
@@ -161,6 +155,12 @@ 
 			#address-cells = <0>;
 		};
 
+		pwrc: power-controller {
+			compatible = "amlogic,meson-a1-pwrc";
+			#power-domain-cells = <1>;
+			status = "okay";
+		};
+
 		usb: usb@fe004400 {
 			compatible = "amlogic,meson-a1-usb-ctrl";
 			reg = <0x0 0xfe004400 0x0 0xa0>;