| Message ID | 20230316025332.3297-18-yanhong.wang@starfivetech.com |
|---|---|
| State | Accepted |
| Commit | 0eff3bf17631889945c89918ea3b97f7c626aef0 |
| Delegated to: | Andes |
| Headers | show |
| Series | Basic StarFive JH7110 RISC-V SoC support | expand |
On Mär 16 2023, Yanhong Wang wrote: > This is the initial basic config for StarFive VisionFive v2 board. It > includes consol, Norflash, sdio, ddr etc. Are you also planning to add a config for the 1.2a version?
On 2023/3/20 22:28, Andreas Schwab wrote: > On Mär 16 2023, Yanhong Wang wrote: > >> This is the initial basic config for StarFive VisionFive v2 board. It >> includes consol, Norflash, sdio, ddr etc. > > Are you also planning to add a config for the 1.2a version? > Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE, 1.2a and 1.3b versions use the same config. Version 1.3b uses the following configuration: CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b" CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb" Version 1.2a uses the following configuration: CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a" CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb" Is it necessary to separate the configs for 1.2a and 1.3b as separate defconfig files? Best Regards. Yanhong.
On Mär 21 2023, yanhong wang wrote: > Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE, > 1.2a and 1.3b versions use the same config. > > Version 1.3b uses the following configuration: > CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b" > CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb" > > Version 1.2a uses the following configuration: > CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a" > CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb" > > Is it necessary to separate the configs for 1.2a and 1.3b as separate defconfig files? It makes a difference for when ethernet support is added.
On 2023/3/21 21:51, Andreas Schwab wrote: > On Mär 21 2023, yanhong wang wrote: > >> Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE, >> 1.2a and 1.3b versions use the same config. >> >> Version 1.3b uses the following configuration: >> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b" >> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb" >> >> Version 1.2a uses the following configuration: >> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a" >> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb" >> >> Is it necessary to separate the configs for 1.2a and 1.3b as separate defconfig files? > > It makes a difference for when ethernet support is added. > The difference between 1.2a and 1.3b versions is mainly in ethernet, so the definition of dts is separated. Defconfig file in addition to the differences mentioned above, the others are the same. Your suggestion is to define defconfig file separately, is that right? If so, I will define the defconfig files of 1.2a and 1.3b independently in the next version.
On Mär 22 2023, yanhong wang wrote: > On 2023/3/21 21:51, Andreas Schwab wrote: >> On Mär 21 2023, yanhong wang wrote: >> >>> Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE, >>> 1.2a and 1.3b versions use the same config. >>> >>> Version 1.3b uses the following configuration: >>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b" >>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb" >>> >>> Version 1.2a uses the following configuration: >>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a" >>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb" >>> >>> Is it necessary to separate the configs for 1.2a and 1.3b as separate defconfig files? >> >> It makes a difference for when ethernet support is added. >> > > The difference between 1.2a and 1.3b versions is mainly in ethernet, so the definition of > dts is separated. Defconfig file in addition to the differences mentioned above, the others > are the same. Your suggestion is to define defconfig file separately, is that right? Yes, a 1.2a board will need to use the 1.2a device tree to get a working ethernet, IIUC.
On 2023/3/23 16:31, Andreas Schwab wrote: > On Mär 22 2023, yanhong wang wrote: > >> On 2023/3/21 21:51, Andreas Schwab wrote: >>> On Mär 21 2023, yanhong wang wrote: >>> >>>> Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE, >>>> 1.2a and 1.3b versions use the same config. >>>> >>>> Version 1.3b uses the following configuration: >>>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b" >>>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb" >>>> >>>> Version 1.2a uses the following configuration: >>>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a" >>>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb" >>>> >>>> Is it necessary to separate the configs for 1.2a and 1.3b as separate defconfig files? >>> >>> It makes a difference for when ethernet support is added. >>> >> >> The difference between 1.2a and 1.3b versions is mainly in ethernet, so the definition of >> dts is separated. Defconfig file in addition to the differences mentioned above, the others >> are the same. Your suggestion is to define defconfig file separately, is that right? > > Yes, a 1.2a board will need to use the 1.2a device tree to get a working > ethernet, IIUC. > Okay, I will define the defconfig for 1.2A and 1.3B separately in the next version.
diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig new file mode 100644 index 0000000000..550d0ff3ab --- /dev/null +++ b/configs/starfive_visionfive2_defconfig @@ -0,0 +1,79 @@ +CONFIG_RISCV=y +CONFIG_SYS_MALLOC_LEN=0x800000 +CONFIG_SYS_MALLOC_F_LEN=0x10000 +CONFIG_SPL_GPIO=y +CONFIG_NR_DRAM_BANKS=1 +CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80000000 +CONFIG_SPL_DM_SPI=y +CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b" +CONFIG_SPL_TEXT_BASE=0x8000000 +CONFIG_SYS_PROMPT="StarFive #" +CONFIG_DM_RESET=y +CONFIG_SPL_MMC=y +CONFIG_SPL_STACK=0x8180000 +CONFIG_SPL=y +CONFIG_SPL_SPI_FLASH_SUPPORT=y +CONFIG_SPL_SPI=y +CONFIG_SYS_LOAD_ADDR=0x82000000 +CONFIG_TARGET_STARFIVE_VISIONFIVE2=y +CONFIG_SPL_OPENSBI_LOAD_ADDR=0x40000000 +CONFIG_ARCH_RV64I=y +CONFIG_CMODEL_MEDANY=y +CONFIG_RISCV_SMODE=y +CONFIG_DISTRO_DEFAULTS=y +CONFIG_FIT=y +CONFIG_QSPI_BOOT=y +CONFIG_SD_BOOT=y +CONFIG_USE_BOOTARGS=y +CONFIG_BOOTARGS="console=ttyS0,115200 debug rootwait earlycon=sbi" +CONFIG_USE_PREBOOT=y +CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr};fdt addr ${fdtcontroladdr};" +CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb" +CONFIG_DISPLAY_CPUINFO=y +CONFIG_DISPLAY_BOARDINFO=y +CONFIG_SPL_MAX_SIZE=0x40000 +CONFIG_SPL_PAD_TO=0x0 +CONFIG_SPL_BSS_START_ADDR=0x8040000 +CONFIG_SPL_BSS_MAX_SIZE=0x10000 +# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set +CONFIG_SYS_SPL_MALLOC=y +CONFIG_HAS_CUSTOM_SPL_MALLOC_START=y +CONFIG_CUSTOM_SYS_SPL_MALLOC_ADDR=0x80000000 +CONFIG_SYS_SPL_MALLOC_SIZE=0x400000 +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION=y +CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION=0x2 +CONFIG_SPL_DM_SPI_FLASH=y +CONFIG_SPL_DM_RESET=y +CONFIG_SPL_SPI_LOAD=y +CONFIG_SYS_CBSIZE=256 +CONFIG_SYS_PBSIZE=276 +CONFIG_SYS_BOOTM_LEN=0x4000000 +CONFIG_CMD_MEMINFO=y +CONFIG_CMD_TFTPPUT=y +CONFIG_SYS_RELOC_GD_ENV_ADDR=y +CONFIG_SPL_CLK_COMPOSITE_CCF=y +CONFIG_CLK_COMPOSITE_CCF=y +CONFIG_SPL_CLK_JH7110=y +# CONFIG_I2C is not set +CONFIG_MMC_HS400_SUPPORT=y +CONFIG_SPL_MMC_HS400_SUPPORT=y +CONFIG_MMC_DW=y +CONFIG_MMC_DW_SNPS=y +CONFIG_SF_DEFAULT_SPEED=100000000 +CONFIG_SPI_FLASH_EON=y +CONFIG_SPI_FLASH_GIGADEVICE=y +CONFIG_SPI_FLASH_ISSI=y +CONFIG_SPI_FLASH_MACRONIX=y +CONFIG_PINCTRL=y +CONFIG_PINCONF=y +CONFIG_SPL_PINCTRL=y +CONFIG_SPL_PINCONF=y +CONFIG_SPL_PINCTRL_STARFIVE=y +CONFIG_SPL_PINCTRL_STARFIVE_JH7110=y +CONFIG_PINCTRL_STARFIVE=y +# CONFIG_RAM_SIFIVE is not set +CONFIG_SYS_NS16550=y +CONFIG_CADENCE_QSPI=y +CONFIG_TIMER_EARLY=y +CONFIG_OF_LIBFDT_OVERLAY=y