diff mbox series

[4/7] zlib: trees.c: Fix a warning with clang-15

Message ID 20230227220839.2519733-4-trini@konsulko.com
State Accepted
Commit 99de38a1092b584da438970a3b636cc3178b3637
Delegated to: Tom Rini
Headers show
Series [1/7] global: Disable deprecated-non-prototype warning with clang | expand

Commit Message

Tom Rini Feb. 27, 2023, 10:08 p.m. UTC
With clang-15 we now will get warnings such as:

warning: a function declaration without a prototype is deprecated in all
versions of C [-Wstrict-prototypes]

And it is easy enough to address this warning here, even if we would
like to stay in sync more with upstream as it's a single location.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
 lib/zlib/trees.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Feb. 28, 2023, 12:35 a.m. UTC | #1
On Mon, 27 Feb 2023 at 15:09, Tom Rini <trini@konsulko.com> wrote:
>
> With clang-15 we now will get warnings such as:
>
> warning: a function declaration without a prototype is deprecated in all
> versions of C [-Wstrict-prototypes]
>
> And it is easy enough to address this warning here, even if we would
> like to stay in sync more with upstream as it's a single location.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  lib/zlib/trees.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini March 23, 2023, 1:18 a.m. UTC | #2
On Mon, Feb 27, 2023 at 05:08:36PM -0500, Tom Rini wrote:

> With clang-15 we now will get warnings such as:
> 
> warning: a function declaration without a prototype is deprecated in all
> versions of C [-Wstrict-prototypes]
> 
> And it is easy enough to address this warning here, even if we would
> like to stay in sync more with upstream as it's a single location.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/lib/zlib/trees.c b/lib/zlib/trees.c
index 970bc5dbc64e..e040617686a1 100644
--- a/lib/zlib/trees.c
+++ b/lib/zlib/trees.c
@@ -237,7 +237,7 @@  local void send_bits(s, value, length)
 /* ===========================================================================
  * Initialize the various 'constant' tables.
  */
-local void tr_static_init()
+local void tr_static_init(void)
 {
 #if defined(GEN_TREES_H) || !defined(STDC)
     static int static_init_done = 0;