| Message ID | 20230220194927.476708-10-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Bin Meng |
| Headers | show |
| Series | x86: Various minor enhancements for coreboot | expand |
Hi Simon, On Tue, Feb 21, 2023 at 3:49 AM Simon Glass <sjg@chromium.org> wrote: > > This is much more common on modern hardware, so default to using it. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > include/configs/coreboot.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h > index f73004386fd..2775f8d76ce 100644 > --- a/include/configs/coreboot.h > +++ b/include/configs/coreboot.h > @@ -19,6 +19,8 @@ > "stdout=serial,vidconsole\0" \ > "stderr=serial,vidconsole\0" > > +#undef CONFIG_SYS_NS16550_PORT_MAPPED This macro is only meaningful for non-DM boards which is not the case for x86. > + > /* ATA/IDE support */ > > #endif /* __CONFIG_H */ > Regards, Bin
On Mon, Mar 20, 2023 at 4:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Simon, > > On Tue, Feb 21, 2023 at 3:49 AM Simon Glass <sjg@chromium.org> wrote: > > > > This is much more common on modern hardware, so default to using it. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > include/configs/coreboot.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h > > index f73004386fd..2775f8d76ce 100644 > > --- a/include/configs/coreboot.h > > +++ b/include/configs/coreboot.h > > @@ -19,6 +19,8 @@ > > "stdout=serial,vidconsole\0" \ > > "stderr=serial,vidconsole\0" > > > > +#undef CONFIG_SYS_NS16550_PORT_MAPPED > > This macro is only meaningful for non-DM boards which is not the case for x86. > for non-DM boards, or for boards that don't enable CONFIG_NS16550_DYNAMIC Regards, Bin
diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h index f73004386fd..2775f8d76ce 100644 --- a/include/configs/coreboot.h +++ b/include/configs/coreboot.h @@ -19,6 +19,8 @@ "stdout=serial,vidconsole\0" \ "stderr=serial,vidconsole\0" +#undef CONFIG_SYS_NS16550_PORT_MAPPED + /* ATA/IDE support */ #endif /* __CONFIG_H */
This is much more common on modern hardware, so default to using it. Signed-off-by: Simon Glass <sjg@chromium.org> --- include/configs/coreboot.h | 2 ++ 1 file changed, 2 insertions(+)