| Message ID | 20230219150629.4012377-5-jonas@kwiboo.se |
|---|---|
| State | Superseded |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: Use external TPL binary to create a working firmware image | expand |
Hi Jonas, On 2/19/23 16:06, Jonas Karlman wrote: > Latest vendor TPL for RK3328 has grown past the current init size limit > of 28KiB and the current init size limit for RK3568 of 76KiB is too big > to fit in 64KiB SRAM. > > Sync init size limit from vendor u-boot for the following SoCs: > > rk3328: 30KiB (+2KiB) > rk3568: 60KiB (-16KiB) > > This makes it possible to use latest vendor TPL on RK3328 without > getting a size limit error running the mkimage command. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> I don't have any feedback on the content of the patchset other than it'd make sense to have this one split in two commits, one for each SoC so that in the event we need to revert one we don't revert the other at the same time. Cheers, Quentin
On 2023/2/19 23:06, Jonas Karlman wrote: > Latest vendor TPL for RK3328 has grown past the current init size limit > of 28KiB and the current init size limit for RK3568 of 76KiB is too big > to fit in 64KiB SRAM. > > Sync init size limit from vendor u-boot for the following SoCs: > > rk3328: 30KiB (+2KiB) > rk3568: 60KiB (-16KiB) > > This makes it possible to use latest vendor TPL on RK3328 without > getting a size limit error running the mkimage command. > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > v4: > - Only change limit for rk3328 and rk3568 > > v3: > - Sync with vendor u-boot as-is > - Update commit message to include size changes > > v2: > - New patch > > tools/rkcommon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/rkcommon.c b/tools/rkcommon.c > index 1f1eaa16752b..0d29110a4dec 100644 > --- a/tools/rkcommon.c > +++ b/tools/rkcommon.c > @@ -129,12 +129,12 @@ static struct spl_info spl_infos[] = { > { "rk322x", "RK32", 0x8000 - 0x1000, false, RK_HEADER_V1 }, > { "rk3288", "RK32", 0x8000, false, RK_HEADER_V1 }, > { "rk3308", "RK33", 0x40000 - 0x1000, false, RK_HEADER_V1 }, > - { "rk3328", "RK32", 0x8000 - 0x1000, false, RK_HEADER_V1 }, > + { "rk3328", "RK32", 0x8000 - 0x800, false, RK_HEADER_V1 }, > { "rk3368", "RK33", 0x8000 - 0x1000, false, RK_HEADER_V1 }, > { "rk3399", "RK33", 0x30000 - 0x2000, false, RK_HEADER_V1 }, > { "rv1108", "RK11", 0x1800, false, RK_HEADER_V1 }, > { "rv1126", "110B", 0x10000 - 0x1000, false, RK_HEADER_V1 }, > - { "rk3568", "RK35", 0x14000 - 0x1000, false, RK_HEADER_V2 }, > + { "rk3568", "RK35", 0x10000 - 0x1000, false, RK_HEADER_V2 }, > }; > > /**
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index 1f1eaa16752b..0d29110a4dec 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -129,12 +129,12 @@ static struct spl_info spl_infos[] = { { "rk322x", "RK32", 0x8000 - 0x1000, false, RK_HEADER_V1 }, { "rk3288", "RK32", 0x8000, false, RK_HEADER_V1 }, { "rk3308", "RK33", 0x40000 - 0x1000, false, RK_HEADER_V1 }, - { "rk3328", "RK32", 0x8000 - 0x1000, false, RK_HEADER_V1 }, + { "rk3328", "RK32", 0x8000 - 0x800, false, RK_HEADER_V1 }, { "rk3368", "RK33", 0x8000 - 0x1000, false, RK_HEADER_V1 }, { "rk3399", "RK33", 0x30000 - 0x2000, false, RK_HEADER_V1 }, { "rv1108", "RK11", 0x1800, false, RK_HEADER_V1 }, { "rv1126", "110B", 0x10000 - 0x1000, false, RK_HEADER_V1 }, - { "rk3568", "RK35", 0x14000 - 0x1000, false, RK_HEADER_V2 }, + { "rk3568", "RK35", 0x10000 - 0x1000, false, RK_HEADER_V2 }, }; /**
Latest vendor TPL for RK3328 has grown past the current init size limit of 28KiB and the current init size limit for RK3568 of 76KiB is too big to fit in 64KiB SRAM. Sync init size limit from vendor u-boot for the following SoCs: rk3328: 30KiB (+2KiB) rk3568: 60KiB (-16KiB) This makes it possible to use latest vendor TPL on RK3328 without getting a size limit error running the mkimage command. Signed-off-by: Jonas Karlman <jonas@kwiboo.se> --- v4: - Only change limit for rk3328 and rk3568 v3: - Sync with vendor u-boot as-is - Update commit message to include size changes v2: - New patch tools/rkcommon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)