| Message ID | 20230210210818.32387-1-mibodhi@gmail.com |
|---|---|
| State | Accepted |
| Commit | dd15284b749e41a3db94883bde9b96601491ec10 |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board | expand |
On 2/10/23 22:08, Tony Dinh wrote: > When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is > required for this board to boot over UART with kwboot. Enable this in > kirkwood-pogoplug-series-4-u-boot.dtsi. > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > > arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi > > diff --git a/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi > new file mode 100644 > index 0000000000..f9e127234c > --- /dev/null > +++ b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2023 Tony Dinh <mibodhi@gmail.com> > + */ > +&uart0 { > + u-boot,dm-pre-reloc; > +}; Viele Grüße, Stefan Roese
Am 2023-02-13 09:43, schrieb Stefan Roese: > On 2/10/23 22:08, Tony Dinh wrote: >> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is >> required for this board to boot over UART with kwboot. Enable this in >> kirkwood-pogoplug-series-4-u-boot.dtsi. >> >> Signed-off-by: Tony Dinh <mibodhi@gmail.com> > > Reviewed-by: Stefan Roese <sr@denx.de> If I understood it correctly, this is a workaround, right? Maybe we can include a link to the original discussion here for the case when someone stumbles over this commit: Link: https://lore.kernel.org/r/20230201080210.ypz4nrj4y2igwxz3@pali/ -michael
Hi Michael, On 2/13/23 09:48, Michael Walle wrote: > Am 2023-02-13 09:43, schrieb Stefan Roese: >> On 2/10/23 22:08, Tony Dinh wrote: >>> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is >>> required for this board to boot over UART with kwboot. Enable this in >>> kirkwood-pogoplug-series-4-u-boot.dtsi. >>> >>> Signed-off-by: Tony Dinh <mibodhi@gmail.com> >> >> Reviewed-by: Stefan Roese <sr@denx.de> > > If I understood it correctly, this is a workaround, right? Maybe we > can include a link to the original discussion here for the case when > someone stumbles over this commit: > > Link: https://lore.kernel.org/r/20230201080210.ypz4nrj4y2igwxz3@pali/ Correct, it's not fully understood, why this property is really needed. Some bug still might be hidden in the early DT console code. Still we want to move forward with this board, so this dm-pre-reloc property helps here. I'll add the link to the discussion to the commit text. Good idea. Thanks, Stefan
On 2/10/23 22:08, Tony Dinh wrote: > When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is > required for this board to boot over UART with kwboot. Enable this in > kirkwood-pogoplug-series-4-u-boot.dtsi. > > Signed-off-by: Tony Dinh <mibodhi@gmail.com> Applied to u-boot-marvell/master Thanks, Stefan > --- > > arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi > > diff --git a/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi > new file mode 100644 > index 0000000000..f9e127234c > --- /dev/null > +++ b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi > @@ -0,0 +1,7 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2023 Tony Dinh <mibodhi@gmail.com> > + */ > +&uart0 { > + u-boot,dm-pre-reloc; > +}; Viele Grüße, Stefan Roese
On Mon, Feb 13, 2023 at 1:12 AM Stefan Roese <sr@denx.de> wrote: > > Hi Michael, > > On 2/13/23 09:48, Michael Walle wrote: > > Am 2023-02-13 09:43, schrieb Stefan Roese: > >> On 2/10/23 22:08, Tony Dinh wrote: > >>> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is > >>> required for this board to boot over UART with kwboot. Enable this in > >>> kirkwood-pogoplug-series-4-u-boot.dtsi. > >>> > >>> Signed-off-by: Tony Dinh <mibodhi@gmail.com> > >> > >> Reviewed-by: Stefan Roese <sr@denx.de> > > > > If I understood it correctly, this is a workaround, right? Maybe we > > can include a link to the original discussion here for the case when > > someone stumbles over this commit: > > > > Link: https://lore.kernel.org/r/20230201080210.ypz4nrj4y2igwxz3@pali/ > > Correct, it's not fully understood, why this property is really needed. > Some bug still might be hidden in the early DT console code. Still we > want to move forward with this board, so this dm-pre-reloc property > helps here. > > I'll add the link to the discussion to the commit text. Good idea. Thanks Stefan! All the best, Tony > > Thanks, > Stefan >
diff --git a/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi new file mode 100644 index 0000000000..f9e127234c --- /dev/null +++ b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi @@ -0,0 +1,7 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2023 Tony Dinh <mibodhi@gmail.com> + */ +&uart0 { + u-boot,dm-pre-reloc; +};
When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is required for this board to boot over UART with kwboot. Enable this in kirkwood-pogoplug-series-4-u-boot.dtsi. Signed-off-by: Tony Dinh <mibodhi@gmail.com> --- arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi