diff mbox series

[1/3] net: ksz9477: remove unnecessary dsa_set_tagging call

Message ID 20230207233718.3162217-1-tharvey@gateworks.com
State Accepted
Commit 38482d659647e8932f95cea88d70ad1b2bbd5af4
Delegated to: Ramon Fried
Headers show
Series [1/3] net: ksz9477: remove unnecessary dsa_set_tagging call | expand

Commit Message

Tim Harvey Feb. 7, 2023, 11:37 p.m. UTC
packet tagging is not used for this driver so we do not need to
call dsa_set_tagging.

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 drivers/net/ksz9477.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ramon Fried Feb. 18, 2023, 8:04 p.m. UTC | #1
On Wed, Feb 8, 2023 at 1:37 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> packet tagging is not used for this driver so we do not need to
> call dsa_set_tagging.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/net/ksz9477.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ksz9477.c b/drivers/net/ksz9477.c
> index fb5c76c600be..fecc394e0277 100644
> --- a/drivers/net/ksz9477.c
> +++ b/drivers/net/ksz9477.c
> @@ -501,8 +501,6 @@ static int ksz_i2c_probe(struct udevice *dev)
>                 ksz_pwrite8(priv->dev, i, REG_PORT_MSTP_STATE, data8);
>         }
>
> -       dsa_set_tagging(dev, 0, 0);
> -
>         return 0;
>  };
>
> --
> 2.25.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Tom Rini May 6, 2023, 2:54 p.m. UTC | #2
On Tue, Feb 07, 2023 at 03:37:16PM -0800, Tim Harvey wrote:

> packet tagging is not used for this driver so we do not need to
> call dsa_set_tagging.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

For the series, applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/net/ksz9477.c b/drivers/net/ksz9477.c
index fb5c76c600be..fecc394e0277 100644
--- a/drivers/net/ksz9477.c
+++ b/drivers/net/ksz9477.c
@@ -501,8 +501,6 @@  static int ksz_i2c_probe(struct udevice *dev)
 		ksz_pwrite8(priv->dev, i, REG_PORT_MSTP_STATE, data8);
 	}
 
-	dsa_set_tagging(dev, 0, 0);
-
 	return 0;
 };