diff mbox series

Kconfig: Remove an impossible condition

Message ID 20230122172352.1029-1-samuel@sholland.org
State Accepted
Delegated to: Andre Przywara
Headers show
Series Kconfig: Remove an impossible condition | expand

Commit Message

Samuel Holland Jan. 22, 2023, 5:23 p.m. UTC
ARCH_SUNXI selects BINMAN, so the condition "!BINMAN && ARCH_SUNXI"
is impossible to satisfy.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andre Przywara April 28, 2023, 12:31 a.m. UTC | #1
On Sun, 22 Jan 2023 11:23:51 -0600
Samuel Holland <samuel@sholland.org> wrote:

> ARCH_SUNXI selects BINMAN, so the condition "!BINMAN && ARCH_SUNXI"
> is impossible to satisfy.

Indeed the generic ARCH_SUNXI entry in arch/arm/Kconfig selects
BINMAN, so that looks fine. The same seems to be true for
ARCH_ROCKCHIP, btw. Anyway, for that patch:

> Signed-off-by: Samuel Holland <samuel@sholland.org>

Acked-by: Andre Przywara <andre.przywara@arm.com>

Queued for sunxi/master.

Cheers,
Andre

> ---
> 
>  Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Kconfig b/Kconfig
> index a75cce7e28..f810646e8a 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -459,7 +459,7 @@ config BUILD_TARGET
>  	default "u-boot-with-spl.kwb" if ARMADA_32BIT && SPL
>  	default "u-boot-elf.srec" if RCAR_GEN3
>  	default "u-boot.itb" if !BINMAN && SPL_LOAD_FIT && (ARCH_ROCKCHIP || \
> -				ARCH_SUNXI || RISCV || ARCH_ZYNQMP)
> +				RISCV || ARCH_ZYNQMP)
>  	default "u-boot.kwb" if (ARCH_KIRKWOOD || ARMADA_32BIT) && !SPL
>  	default "u-boot-with-spl.bin" if MPC85xx && !E500MC && !E5500 && !E6500 && SPL
>  	default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT
diff mbox series

Patch

diff --git a/Kconfig b/Kconfig
index a75cce7e28..f810646e8a 100644
--- a/Kconfig
+++ b/Kconfig
@@ -459,7 +459,7 @@  config BUILD_TARGET
 	default "u-boot-with-spl.kwb" if ARMADA_32BIT && SPL
 	default "u-boot-elf.srec" if RCAR_GEN3
 	default "u-boot.itb" if !BINMAN && SPL_LOAD_FIT && (ARCH_ROCKCHIP || \
-				ARCH_SUNXI || RISCV || ARCH_ZYNQMP)
+				RISCV || ARCH_ZYNQMP)
 	default "u-boot.kwb" if (ARCH_KIRKWOOD || ARMADA_32BIT) && !SPL
 	default "u-boot-with-spl.bin" if MPC85xx && !E500MC && !E5500 && !E6500 && SPL
 	default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT