| Message ID | 20230119125612.1968983-1-john@metanate.com |
|---|---|
| State | Accepted |
| Commit | 519fa7aa252789677939f0bd991bf26a4fe469ec |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | power: act8846_pmic: fix number of registers | expand |
On Thu, 19 Jan 2023 at 05:56, John Keeping <john@metanate.com> wrote: > > The highest register on ACT8846 is 0xf5, so set the number of registers > to 0xf6, ensuring that the pmic read/write commands are able to access > all of the supported registers (and many that are not valid, since the > register space is quite sparse). > > Signed-off-by: John Keeping <john@metanate.com> > --- > include/power/act8846_pmic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
On 1/19/23 21:56, John Keeping wrote: > The highest register on ACT8846 is 0xf5, so set the number of registers > to 0xf6, ensuring that the pmic read/write commands are able to access > all of the supported registers (and many that are not valid, since the > register space is quite sparse). > > Signed-off-by: John Keeping <john@metanate.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > include/power/act8846_pmic.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/power/act8846_pmic.h b/include/power/act8846_pmic.h > index acd0fd671e..84845c70f9 100644 > --- a/include/power/act8846_pmic.h > +++ b/include/power/act8846_pmic.h > @@ -9,7 +9,7 @@ > > #include <asm/gpio.h> > > -#define ACT8846_NUM_OF_REGS 12 > +#define ACT8846_NUM_OF_REGS 0xf6 > > #define BUCK_VOL_MASK 0x3f > #define LDO_VOL_MASK 0x3f
diff --git a/include/power/act8846_pmic.h b/include/power/act8846_pmic.h index acd0fd671e..84845c70f9 100644 --- a/include/power/act8846_pmic.h +++ b/include/power/act8846_pmic.h @@ -9,7 +9,7 @@ #include <asm/gpio.h> -#define ACT8846_NUM_OF_REGS 12 +#define ACT8846_NUM_OF_REGS 0xf6 #define BUCK_VOL_MASK 0x3f #define LDO_VOL_MASK 0x3f
The highest register on ACT8846 is 0xf5, so set the number of registers to 0xf6, ensuring that the pmic read/write commands are able to access all of the supported registers (and many that are not valid, since the register space is quite sparse). Signed-off-by: John Keeping <john@metanate.com> --- include/power/act8846_pmic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)