| Message ID | 20230110113124.1434-3-ashok.reddy.soma@amd.com |
|---|---|
| State | Accepted |
| Commit | 6f5bb9913ca54fe0a3e45f83458eb71103e22ef7 |
| Delegated to: | Jaehoon Chung |
| Headers | show |
| Series | Add eMMC 5.1 support for Versal NET | expand |
On 1/10/23 20:31, Ashok Reddy Soma wrote: > Check if the low level driver supports config_dll callback function and > call it if it does. Call with dll disable before calling set_clock and > with dll enable after it. > > Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/sdhci.c | 16 ++++++++++++++++ > include/sdhci.h | 2 ++ > 2 files changed, 18 insertions(+) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index a80ad8329a..181ab9b7cb 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -396,6 +396,14 @@ int sdhci_set_clock(struct mmc *mmc, unsigned int clock) > } > } > > + if (host->ops && host->ops->config_dll) { > + ret = host->ops->config_dll(host, clock, false); > + if (ret) { > + printf("%s: Error while configuring dll\n", __func__); > + return ret; > + } > + } > + > if (SDHCI_GET_VERSION(host) >= SDHCI_SPEC_300) { > /* > * Check if the Host Controller supports Programmable Clock > @@ -439,6 +447,14 @@ int sdhci_set_clock(struct mmc *mmc, unsigned int clock) > if (host->ops && host->ops->set_clock) > host->ops->set_clock(host, div); > > + if (host->ops && host->ops->config_dll) { > + ret = host->ops->config_dll(host, clock, true); > + if (ret) { > + printf("%s: Error while configuring dll\n", __func__); > + return ret; > + } > + } > + > clk |= (div & SDHCI_DIV_MASK) << SDHCI_DIVIDER_SHIFT; > clk |= ((div & SDHCI_DIV_HI_MASK) >> SDHCI_DIV_MASK_LEN) > << SDHCI_DIVIDER_HI_SHIFT; > diff --git a/include/sdhci.h b/include/sdhci.h > index 24b4599b85..64a3d309da 100644 > --- a/include/sdhci.h > +++ b/include/sdhci.h > @@ -272,6 +272,8 @@ struct sdhci_ops { > void (*set_clock)(struct sdhci_host *host, u32 div); > int (*platform_execute_tuning)(struct mmc *host, u8 opcode); > int (*set_delay)(struct sdhci_host *host); > + /* Callback function to set DLL clock configuration */ > + int (*config_dll)(struct sdhci_host *host, u32 clock, bool enable);> int (*deferred_probe)(struct sdhci_host *host); > > /**
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index a80ad8329a..181ab9b7cb 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -396,6 +396,14 @@ int sdhci_set_clock(struct mmc *mmc, unsigned int clock) } } + if (host->ops && host->ops->config_dll) { + ret = host->ops->config_dll(host, clock, false); + if (ret) { + printf("%s: Error while configuring dll\n", __func__); + return ret; + } + } + if (SDHCI_GET_VERSION(host) >= SDHCI_SPEC_300) { /* * Check if the Host Controller supports Programmable Clock @@ -439,6 +447,14 @@ int sdhci_set_clock(struct mmc *mmc, unsigned int clock) if (host->ops && host->ops->set_clock) host->ops->set_clock(host, div); + if (host->ops && host->ops->config_dll) { + ret = host->ops->config_dll(host, clock, true); + if (ret) { + printf("%s: Error while configuring dll\n", __func__); + return ret; + } + } + clk |= (div & SDHCI_DIV_MASK) << SDHCI_DIVIDER_SHIFT; clk |= ((div & SDHCI_DIV_HI_MASK) >> SDHCI_DIV_MASK_LEN) << SDHCI_DIVIDER_HI_SHIFT; diff --git a/include/sdhci.h b/include/sdhci.h index 24b4599b85..64a3d309da 100644 --- a/include/sdhci.h +++ b/include/sdhci.h @@ -272,6 +272,8 @@ struct sdhci_ops { void (*set_clock)(struct sdhci_host *host, u32 div); int (*platform_execute_tuning)(struct mmc *host, u8 opcode); int (*set_delay)(struct sdhci_host *host); + /* Callback function to set DLL clock configuration */ + int (*config_dll)(struct sdhci_host *host, u32 clock, bool enable); int (*deferred_probe)(struct sdhci_host *host); /**
Check if the low level driver supports config_dll callback function and call it if it does. Call with dll disable before calling set_clock and with dll enable after it. Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com> --- drivers/mmc/sdhci.c | 16 ++++++++++++++++ include/sdhci.h | 2 ++ 2 files changed, 18 insertions(+)