| Message ID | 20221123234500.354-1-pali@kernel.org |
|---|---|
| State | Accepted |
| Commit | 544071ac4a1c301ed38d7f9ce41cc7cd0910083d |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Nokia RX-51: Use ENTRY/ENDPROC for save_boot_params | expand |
On Thu, Nov 24, 2022 at 12:45:00AM +0100, Pali Rohár wrote: > ENTRY/ENDPROC macros from linux/linkage.h will make code more readable and > also will properly mark assembly symbol in ELF binary as function symbol. > > Signed-off-by: Pali Rohár <pali@kernel.org> Applied to u-boot/next, thanks!
diff --git a/board/nokia/rx51/lowlevel_init.S b/board/nokia/rx51/lowlevel_init.S index 930052ea60f2..44f32f114e75 100644 --- a/board/nokia/rx51/lowlevel_init.S +++ b/board/nokia/rx51/lowlevel_init.S @@ -5,6 +5,7 @@ */ #include <config.h> +#include <linux/linkage.h> kernoffs: /* offset of kernel image from this address */ .word . - CONFIG_TEXT_BASE - KERNEL_OFFSET @@ -29,8 +30,7 @@ z_magic: /* LINUX_ARM_ZIMAGE_MAGIC */ * Description: Copy attached kernel to address KERNEL_ADDRESS */ -.global save_boot_params -save_boot_params: +ENTRY(save_boot_params) /* * Copy valid attached kernel to absolute address KERNEL_ADDRESS @@ -93,3 +93,5 @@ skip_copy: /* Returns */ b save_boot_params_ret + +ENDPROC(save_boot_params)
ENTRY/ENDPROC macros from linux/linkage.h will make code more readable and also will properly mark assembly symbol in ELF binary as function symbol. Signed-off-by: Pali Rohár <pali@kernel.org> --- board/nokia/rx51/lowlevel_init.S | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)