diff mbox series

[11/11] imx: mx6sabresd: select DM_SERIAL

Message ID 20221107080016.1304-12-peng.fan@oss.nxp.com
State Accepted
Commit beb403f9e53b8dddf330228bd5f79a62aad5fcdc
Delegated to: Stefano Babic
Headers show
Series imx: convert to DM_SERIAL | expand

Commit Message

Peng Fan (OSS) Nov. 7, 2022, 8 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

Select DM_SERIAL

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 configs/mx6sabresd_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam Nov. 14, 2022, 6:58 p.m. UTC | #1
Hi Peng,

On Mon, Nov 7, 2022 at 4:14 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Select DM_SERIAL

When converting to DM_SERIAL, please also remove setup_iomux_uart()
from the board code.
Peng Fan (OSS) Nov. 15, 2022, 9:17 a.m. UTC | #2
On 11/15/2022 2:58 AM, Fabio Estevam wrote:
> Hi Peng,
> 
> On Mon, Nov 7, 2022 at 4:14 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>>
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Select DM_SERIAL
> 
> When converting to DM_SERIAL, please also remove setup_iomux_uart()
> from the board code.

No, the SPL not use DM_SERIAL. For mx6sabresd, it supports 3 boards,
limited SRAM made is hard to enable the DM feature.

Thanks,
Peng.
Fabio Estevam Nov. 15, 2022, 11:30 a.m. UTC | #3
Hi Peng,

On Tue, Nov 15, 2022 at 6:17 AM Peng Fan <peng.fan@oss.nxp.com> wrote:
>
> No, the SPL not use DM_SERIAL. For mx6sabresd, it supports 3 boards,
> limited SRAM made is hard to enable the DM feature.

setup_iomux_uart() is not called in SPL. It is called inside U-Boot proper.
Stefano Babic Jan. 31, 2023, 1:15 p.m. UTC | #4
> From: Peng Fan <peng.fan@nxp.com>
> Select DM_SERIAL
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/configs/mx6sabresd_defconfig b/configs/mx6sabresd_defconfig
index 26cee0eae60..43c668ce5af 100644
--- a/configs/mx6sabresd_defconfig
+++ b/configs/mx6sabresd_defconfig
@@ -104,6 +104,7 @@  CONFIG_POWER_LEGACY=y
 CONFIG_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_POWER_I2C=y
+CONFIG_DM_SERIAL=y
 CONFIG_MXC_UART=y
 CONFIG_SPI=y
 CONFIG_DM_SPI=y