diff mbox series

[1/1] test: fix some pylint errors in test_efi_secboot

Message ID 20221001185709.26980-1-heinrich.schuchardt@canonical.com
State Accepted, archived
Delegated to: Heinrich Schuchardt
Headers show
Series [1/1] test: fix some pylint errors in test_efi_secboot | expand

Commit Message

Heinrich Schuchardt Oct. 1, 2022, 6:57 p.m. UTC
* Remove unused import
* Provide module docstring

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 test/py/tests/test_efi_secboot/conftest.py | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Comments

Ilias Apalodimas Oct. 5, 2022, 7:02 a.m. UTC | #1
On Sat, Oct 01, 2022 at 08:57:09PM +0200, Heinrich Schuchardt wrote:
> * Remove unused import
> * Provide module docstring
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  test/py/tests/test_efi_secboot/conftest.py | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/test/py/tests/test_efi_secboot/conftest.py b/test/py/tests/test_efi_secboot/conftest.py
> index db6b8d301f..406131cb45 100644
> --- a/test/py/tests/test_efi_secboot/conftest.py
> +++ b/test/py/tests/test_efi_secboot/conftest.py
> @@ -2,18 +2,12 @@
>  # Copyright (c) 2019, Linaro Limited
>  # Author: AKASHI Takahiro <takahiro.akashi@linaro.org>
>  
> -import os
> -import os.path
> -from subprocess import call, check_call, check_output, CalledProcessError
> +""" Fixture for UEFI secure boot test """
> +
> +from subprocess import call, check_call, CalledProcessError
>  import pytest
>  from defs import *
>  
> -
> -#
> -# Fixture for UEFI secure boot test
> -#
> -
> -
>  @pytest.fixture(scope='session')
>  def efi_boot_env(request, u_boot_config):
>      """Set up a file system to be used in UEFI secure boot test.
> -- 
> 2.37.2
> 

Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/test/py/tests/test_efi_secboot/conftest.py b/test/py/tests/test_efi_secboot/conftest.py
index db6b8d301f..406131cb45 100644
--- a/test/py/tests/test_efi_secboot/conftest.py
+++ b/test/py/tests/test_efi_secboot/conftest.py
@@ -2,18 +2,12 @@ 
 # Copyright (c) 2019, Linaro Limited
 # Author: AKASHI Takahiro <takahiro.akashi@linaro.org>
 
-import os
-import os.path
-from subprocess import call, check_call, check_output, CalledProcessError
+""" Fixture for UEFI secure boot test """
+
+from subprocess import call, check_call, CalledProcessError
 import pytest
 from defs import *
 
-
-#
-# Fixture for UEFI secure boot test
-#
-
-
 @pytest.fixture(scope='session')
 def efi_boot_env(request, u_boot_config):
     """Set up a file system to be used in UEFI secure boot test.