| Message ID | 20220825064131.673958-3-ovpanait@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | [1/4] microblaze: drop CONFIG_SYS_INIT_RAM_ADDR and CONFIG_SYS_INIT_RAM_SIZE | expand |
čt 25. 8. 2022 v 8:42 odesílatel Ovidiu Panait <ovpanait@gmail.com> napsal: > > Add bdinfo_print_size() helper to display size variables (such as cache > sizes) in bdinfo format. The size is printed as "xxx Bytes", "xxx KiB", > "xxx MiB", "xxx GiB", etc as needed; > > Signed-off-by: Ovidiu Panait <ovpanait@gmail.com> > --- > > cmd/bdinfo.c | 7 +++++++ > include/init.h | 13 +++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c > index 37cd8a57eb..9e23c4dd8f 100644 > --- a/cmd/bdinfo.c > +++ b/cmd/bdinfo.c > @@ -16,9 +16,16 @@ > #include <vsprintf.h> > #include <asm/cache.h> > #include <asm/global_data.h> > +#include <display_options.h> > > DECLARE_GLOBAL_DATA_PTR; > > +void bdinfo_print_size(const char *name, uint64_t size) > +{ > + printf("%-12s= ", name); > + print_size(size, "\n"); > +} > + > void bdinfo_print_num_l(const char *name, ulong value) > { > printf("%-12s= 0x%0*lx\n", name, 2 * (int)sizeof(value), value); > diff --git a/include/init.h b/include/init.h > index 7b8f62c121..02bb4ce13e 100644 > --- a/include/init.h > +++ b/include/init.h > @@ -343,6 +343,19 @@ void bdinfo_print_num_ll(const char *name, unsigned long long value); > /* Print a clock speed in MHz */ > void bdinfo_print_mhz(const char *name, unsigned long hz); > > +/** > + * bdinfo_print_size - print size variables in bdinfo format > + * @name: string to print before the size > + * @size: size to print > + * > + * Helper function for displaying size variables as properly formatted bdinfo > + * entries. The size is printed as "xxx Bytes", "xxx KiB", "xxx MiB", > + * "xxx GiB", etc. as needed; > + * > + * For use in arch_print_bdinfo(). > + */ > +void bdinfo_print_size(const char *name, uint64_t size); > + > /* Show arch-specific information for the 'bd' command */ > void arch_print_bdinfo(void); > > -- > 2.25.1 > No problem with this code. If there is any problem you can include it directly to mb implementation but make sense to have it in generic location. Thanks, Michal
On Thu, 25 Aug 2022 at 00:41, Ovidiu Panait <ovpanait@gmail.com> wrote: > > Add bdinfo_print_size() helper to display size variables (such as cache > sizes) in bdinfo format. The size is printed as "xxx Bytes", "xxx KiB", > "xxx MiB", "xxx GiB", etc as needed; > > Signed-off-by: Ovidiu Panait <ovpanait@gmail.com> > --- > > cmd/bdinfo.c | 7 +++++++ > include/init.h | 13 +++++++++++++ > 2 files changed, 20 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index 37cd8a57eb..9e23c4dd8f 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -16,9 +16,16 @@ #include <vsprintf.h> #include <asm/cache.h> #include <asm/global_data.h> +#include <display_options.h> DECLARE_GLOBAL_DATA_PTR; +void bdinfo_print_size(const char *name, uint64_t size) +{ + printf("%-12s= ", name); + print_size(size, "\n"); +} + void bdinfo_print_num_l(const char *name, ulong value) { printf("%-12s= 0x%0*lx\n", name, 2 * (int)sizeof(value), value); diff --git a/include/init.h b/include/init.h index 7b8f62c121..02bb4ce13e 100644 --- a/include/init.h +++ b/include/init.h @@ -343,6 +343,19 @@ void bdinfo_print_num_ll(const char *name, unsigned long long value); /* Print a clock speed in MHz */ void bdinfo_print_mhz(const char *name, unsigned long hz); +/** + * bdinfo_print_size - print size variables in bdinfo format + * @name: string to print before the size + * @size: size to print + * + * Helper function for displaying size variables as properly formatted bdinfo + * entries. The size is printed as "xxx Bytes", "xxx KiB", "xxx MiB", + * "xxx GiB", etc. as needed; + * + * For use in arch_print_bdinfo(). + */ +void bdinfo_print_size(const char *name, uint64_t size); + /* Show arch-specific information for the 'bd' command */ void arch_print_bdinfo(void);
Add bdinfo_print_size() helper to display size variables (such as cache sizes) in bdinfo format. The size is printed as "xxx Bytes", "xxx KiB", "xxx MiB", "xxx GiB", etc as needed; Signed-off-by: Ovidiu Panait <ovpanait@gmail.com> --- cmd/bdinfo.c | 7 +++++++ include/init.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)