| Message ID | 20220807154708.1418967-14-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | blk: Rationalise the block interface | expand |
On 8/7/22 17:46, Simon Glass wrote: > We don't want boards to be able to change these. They can be handled > as dependencies of options that need them, such as SPL_MMC. There is no > point in enabling the block interface without any storage devices to > create a block device. > > Hide both options from the 'menuconfig' display and deny their use in > defconfig files. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/block/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > index 7bd37f760ca..b8ed3ef8d1f 100644 > --- a/drivers/block/Kconfig > +++ b/drivers/block/Kconfig > @@ -1,5 +1,5 @@ > config BLK > - bool "Support block devices" > + bool # "Support block devices" This needs be merged into patch 3 to avoid misconfigurations when applying only patch 1-3. Best regards Heinrich > depends on DM > default y if MMC || USB || SCSI || NVME || IDE || AHCI > default y if EFI_MEDIA || VIRTIO_BLK || PVBLOCK > @@ -12,7 +12,7 @@ config BLK > A filesystem can be placed in each partition. > > config SPL_LEGACY_BLOCK > - bool "Enable Legacy Block Device" > + bool # "Enable Legacy Block Device" > depends on SPL && !DM_SPL > default y if SPL_MMC || SPL_USB_STORAGE || SCSI || NVME || IDE > default y if SPL_AHCI_PCI
Hi Heinrich, On Mon, 8 Aug 2022 at 02:09, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > On 8/7/22 17:46, Simon Glass wrote: > > We don't want boards to be able to change these. They can be handled > > as dependencies of options that need them, such as SPL_MMC. There is no > > point in enabling the block interface without any storage devices to > > create a block device. > > > > Hide both options from the 'menuconfig' display and deny their use in > > defconfig files. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > drivers/block/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > > index 7bd37f760ca..b8ed3ef8d1f 100644 > > --- a/drivers/block/Kconfig > > +++ b/drivers/block/Kconfig > > @@ -1,5 +1,5 @@ > > config BLK > > - bool "Support block devices" > > + bool # "Support block devices" > > This needs be merged into patch 3 to avoid misconfigurations when > applying only patch 1-3. Let's not do that, then. We should apply the whole series. Regards, Simon
diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 7bd37f760ca..b8ed3ef8d1f 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -1,5 +1,5 @@ config BLK - bool "Support block devices" + bool # "Support block devices" depends on DM default y if MMC || USB || SCSI || NVME || IDE || AHCI default y if EFI_MEDIA || VIRTIO_BLK || PVBLOCK @@ -12,7 +12,7 @@ config BLK A filesystem can be placed in each partition. config SPL_LEGACY_BLOCK - bool "Enable Legacy Block Device" + bool # "Enable Legacy Block Device" depends on SPL && !DM_SPL default y if SPL_MMC || SPL_USB_STORAGE || SCSI || NVME || IDE default y if SPL_AHCI_PCI
We don't want boards to be able to change these. They can be handled as dependencies of options that need them, such as SPL_MMC. There is no point in enabling the block interface without any storage devices to create a block device. Hide both options from the 'menuconfig' display and deny their use in defconfig files. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/block/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)