diff mbox series

gpio: aspeed: port Linux dt-bindings header file

Message ID 20220802205450.801824-1-dphadke@linux.microsoft.com
State Superseded
Delegated to: Tom Rini
Headers show
Series gpio: aspeed: port Linux dt-bindings header file | expand

Commit Message

Dhananjay Phadke Aug. 2, 2022, 8:54 p.m. UTC 
Ported as is, makes it easier to add readable GPIO definitions
in DTS files.

Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
---
 include/dt-bindings/gpio/aspeed-gpio.h | 49 ++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h

Comments

ChiaWei Wang Aug. 3, 2022, 1:46 a.m. UTC | #1 
Acked-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>

> From: Dhananjay Phadke <dphadke@linux.microsoft.com>
> Sent: Wednesday, August 3, 2022 4:55 AM
> 
> Ported as is, makes it easier to add readable GPIO definitions in DTS files.
> 
> Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
> ---
>  include/dt-bindings/gpio/aspeed-gpio.h | 49 ++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h
> 
> diff --git a/include/dt-bindings/gpio/aspeed-gpio.h
> b/include/dt-bindings/gpio/aspeed-gpio.h
> new file mode 100644
> index 0000000000..56fc4889b2
> --- /dev/null
> +++ b/include/dt-bindings/gpio/aspeed-gpio.h
> @@ -0,0 +1,49 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * This header provides constants for binding aspeed,*-gpio.
> + *
> + * The first cell in Aspeed's GPIO specifier is the GPIO ID. The macros
> +below
> + * provide names for this.
> + *
> + * The second cell contains standard flag values specified in gpio.h.
> + */
> +
> +#ifndef _DT_BINDINGS_GPIO_ASPEED_GPIO_H #define
> +_DT_BINDINGS_GPIO_ASPEED_GPIO_H
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +#define ASPEED_GPIO_PORT_A 0
> +#define ASPEED_GPIO_PORT_B 1
> +#define ASPEED_GPIO_PORT_C 2
> +#define ASPEED_GPIO_PORT_D 3
> +#define ASPEED_GPIO_PORT_E 4
> +#define ASPEED_GPIO_PORT_F 5
> +#define ASPEED_GPIO_PORT_G 6
> +#define ASPEED_GPIO_PORT_H 7
> +#define ASPEED_GPIO_PORT_I 8
> +#define ASPEED_GPIO_PORT_J 9
> +#define ASPEED_GPIO_PORT_K 10
> +#define ASPEED_GPIO_PORT_L 11
> +#define ASPEED_GPIO_PORT_M 12
> +#define ASPEED_GPIO_PORT_N 13
> +#define ASPEED_GPIO_PORT_O 14
> +#define ASPEED_GPIO_PORT_P 15
> +#define ASPEED_GPIO_PORT_Q 16
> +#define ASPEED_GPIO_PORT_R 17
> +#define ASPEED_GPIO_PORT_S 18
> +#define ASPEED_GPIO_PORT_T 19
> +#define ASPEED_GPIO_PORT_U 20
> +#define ASPEED_GPIO_PORT_V 21
> +#define ASPEED_GPIO_PORT_W 22
> +#define ASPEED_GPIO_PORT_X 23
> +#define ASPEED_GPIO_PORT_Y 24
> +#define ASPEED_GPIO_PORT_Z 25
> +#define ASPEED_GPIO_PORT_AA 26
> +#define ASPEED_GPIO_PORT_AB 27
> +#define ASPEED_GPIO_PORT_AC 28
> +
> +#define ASPEED_GPIO(port, offset) \
> +	((ASPEED_GPIO_PORT_##port * 8) + offset)
> +
> +#endif
> --
> 2.25.1
Billy Tsai Aug. 3, 2022, 2:10 a.m. UTC | #2 
Reviewed-by: Billy Tsai <billy_tsai@aspeedtech.com>

On 2022/8/3, 9:46 AM, "ChiaWei Wang" <chiawei_wang@aspeedtech.com> wrote:

    Acked-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>

    > From: Dhananjay Phadke <dphadke@linux.microsoft.com>
    > Sent: Wednesday, August 3, 2022 4:55 AM
    > 
    > Ported as is, makes it easier to add readable GPIO definitions in DTS files.
    > 
    > Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
    > ---
    >  include/dt-bindings/gpio/aspeed-gpio.h | 49 ++++++++++++++++++++++++++
    >  1 file changed, 49 insertions(+)
    >  create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h
    > 
    > diff --git a/include/dt-bindings/gpio/aspeed-gpio.h
    > b/include/dt-bindings/gpio/aspeed-gpio.h
    > new file mode 100644
    > index 0000000000..56fc4889b2
    > --- /dev/null
    > +++ b/include/dt-bindings/gpio/aspeed-gpio.h
    > @@ -0,0 +1,49 @@
    > +/* SPDX-License-Identifier: GPL-2.0+ */
    > +/*
    > + * This header provides constants for binding aspeed,*-gpio.
    > + *
    > + * The first cell in Aspeed's GPIO specifier is the GPIO ID. The macros
    > +below
    > + * provide names for this.
    > + *
    > + * The second cell contains standard flag values specified in gpio.h.
    > + */
    > +
    > +#ifndef _DT_BINDINGS_GPIO_ASPEED_GPIO_H #define
    > +_DT_BINDINGS_GPIO_ASPEED_GPIO_H
    > +
    > +#include <dt-bindings/gpio/gpio.h>
    > +
    > +#define ASPEED_GPIO_PORT_A 0
    > +#define ASPEED_GPIO_PORT_B 1
    > +#define ASPEED_GPIO_PORT_C 2
    > +#define ASPEED_GPIO_PORT_D 3
    > +#define ASPEED_GPIO_PORT_E 4
    > +#define ASPEED_GPIO_PORT_F 5
    > +#define ASPEED_GPIO_PORT_G 6
    > +#define ASPEED_GPIO_PORT_H 7
    > +#define ASPEED_GPIO_PORT_I 8
    > +#define ASPEED_GPIO_PORT_J 9
    > +#define ASPEED_GPIO_PORT_K 10
    > +#define ASPEED_GPIO_PORT_L 11
    > +#define ASPEED_GPIO_PORT_M 12
    > +#define ASPEED_GPIO_PORT_N 13
    > +#define ASPEED_GPIO_PORT_O 14
    > +#define ASPEED_GPIO_PORT_P 15
    > +#define ASPEED_GPIO_PORT_Q 16
    > +#define ASPEED_GPIO_PORT_R 17
    > +#define ASPEED_GPIO_PORT_S 18
    > +#define ASPEED_GPIO_PORT_T 19
    > +#define ASPEED_GPIO_PORT_U 20
    > +#define ASPEED_GPIO_PORT_V 21
    > +#define ASPEED_GPIO_PORT_W 22
    > +#define ASPEED_GPIO_PORT_X 23
    > +#define ASPEED_GPIO_PORT_Y 24
    > +#define ASPEED_GPIO_PORT_Z 25
    > +#define ASPEED_GPIO_PORT_AA 26
    > +#define ASPEED_GPIO_PORT_AB 27
    > +#define ASPEED_GPIO_PORT_AC 28
    > +
    > +#define ASPEED_GPIO(port, offset) \
    > +	((ASPEED_GPIO_PORT_##port * 8) + offset)
    > +
    > +#endif
    > --
    > 2.25.1
Billy Tsai Aug. 3, 2022, 5:34 a.m. UTC | #3 
Hello,

On 2022/8/3, 10:10 AM, "Billy Tsai" <billy_tsai@aspeedtech.com> wrote:

    Reviewed-by: Billy Tsai <billy_tsai@aspeedtech.com>

    On 2022/8/3, 9:46 AM, "ChiaWei Wang" <chiawei_wang@aspeedtech.com> wrote:

        Acked-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>

        > > From: Dhananjay Phadke <dphadke@linux.microsoft.com>
        > > Sent: Wednesday, August 3, 2022 4:55 AM
        > > 
        > > Ported as is, makes it easier to add readable GPIO definitions in DTS files.
        > > 
        > > Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
        > > ---
        > >  include/dt-bindings/gpio/aspeed-gpio.h | 49 ++++++++++++++++++++++++++
        > >  1 file changed, 49 insertions(+)
        > >  create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h
        > > 
        > > diff --git a/include/dt-bindings/gpio/aspeed-gpio.h
        > > b/include/dt-bindings/gpio/aspeed-gpio.h
        > > new file mode 100644
        > > index 0000000000..56fc4889b2
        > > --- /dev/null
        > > +++ b/include/dt-bindings/gpio/aspeed-gpio.h
        > > @@ -0,0 +1,49 @@
        > > +/* SPDX-License-Identifier: GPL-2.0+ */
        > > +/*
        > > + * This header provides constants for binding aspeed,*-gpio.
        > > + *
        > > + * The first cell in Aspeed's GPIO specifier is the GPIO ID. The macros
        > > +below
        > > + * provide names for this.
        > > + *
        > > + * The second cell contains standard flag values specified in gpio.h.
        > > + */
        > > +
        > > +#ifndef _DT_BINDINGS_GPIO_ASPEED_GPIO_H #define
        > > +_DT_BINDINGS_GPIO_ASPEED_GPIO_H
        > > +
        > > +#include <dt-bindings/gpio/gpio.h>
        > > +
        > > +#define ASPEED_GPIO_PORT_A 0
        > > +#define ASPEED_GPIO_PORT_B 1
        > > +#define ASPEED_GPIO_PORT_C 2
        > > +#define ASPEED_GPIO_PORT_D 3
        > > +#define ASPEED_GPIO_PORT_E 4
        > > +#define ASPEED_GPIO_PORT_F 5
        > > +#define ASPEED_GPIO_PORT_G 6
        > > +#define ASPEED_GPIO_PORT_H 7
        > > +#define ASPEED_GPIO_PORT_I 8
        > > +#define ASPEED_GPIO_PORT_J 9
        > > +#define ASPEED_GPIO_PORT_K 10
        > > +#define ASPEED_GPIO_PORT_L 11
        > > +#define ASPEED_GPIO_PORT_M 12
        > > +#define ASPEED_GPIO_PORT_N 13
        > > +#define ASPEED_GPIO_PORT_O 14
        > > +#define ASPEED_GPIO_PORT_P 15
        > > +#define ASPEED_GPIO_PORT_Q 16
        > > +#define ASPEED_GPIO_PORT_R 17
        > > +#define ASPEED_GPIO_PORT_S 18
        > > +#define ASPEED_GPIO_PORT_T 19
        > > +#define ASPEED_GPIO_PORT_U 20
        > > +#define ASPEED_GPIO_PORT_V 21
        > > +#define ASPEED_GPIO_PORT_W 22
        > > +#define ASPEED_GPIO_PORT_X 23
        > > +#define ASPEED_GPIO_PORT_Y 24
        > > +#define ASPEED_GPIO_PORT_Z 25
        > > +#define ASPEED_GPIO_PORT_AA 26
        > > +#define ASPEED_GPIO_PORT_AB 27
        > > +#define ASPEED_GPIO_PORT_AC 28
        > > +
        > > +#define ASPEED_GPIO(port, offset) \
        > > +	((ASPEED_GPIO_PORT_##port * 8) + offset)
Please help to fix the check patch warning.
"Macro argument 'offset' may be better as '(offset)' to avoid precedence issues"
((ASPEED_GPIO_PORT_##port * 8) + (offset))
        > > +
        > > +#endif
        > > --
        > > 2.25.1
Dhananjay Phadke Aug. 4, 2022, 12:07 a.m. UTC | #4 
On 8/2/2022 10:34 PM, Billy Tsai wrote:
> Hello,
> 
> On 2022/8/3, 10:10 AM, "Billy Tsai" <billy_tsai@aspeedtech.com> wrote:
> 
>      Reviewed-by: Billy Tsai <billy_tsai@aspeedtech.com>
> 
>      On 2022/8/3, 9:46 AM, "ChiaWei Wang" <chiawei_wang@aspeedtech.com> wrote:
> 
>          Acked-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> 
>          > > From: Dhananjay Phadke <dphadke@linux.microsoft.com>
>          > > Sent: Wednesday, August 3, 2022 4:55 AM
>          > >
>          > > Ported as is, makes it easier to add readable GPIO definitions in DTS files.
>          > >
>          > > Signed-off-by: Dhananjay Phadke <dphadke@linux.microsoft.com>
>          > > ---
>          > >  include/dt-bindings/gpio/aspeed-gpio.h | 49 ++++++++++++++++++++++++++
>          > >  1 file changed, 49 insertions(+)
>          > >  create mode 100644 include/dt-bindings/gpio/aspeed-gpio.h
[...]
>          > > +
>          > > +#define ASPEED_GPIO(port, offset) \
>          > > +	((ASPEED_GPIO_PORT_##port * 8) + offset)
> Please help to fix the check patch warning.
> "Macro argument 'offset' may be better as '(offset)' to avoid precedence issues"
> ((ASPEED_GPIO_PORT_##port * 8) + (offset))
>          > > +

Yes, I noticed this, but it would mean this will diverge from
kernel. I can send v2 here and then sync to kernel later.

Regards,
Dhananjay
diff mbox series

Patch

diff --git a/include/dt-bindings/gpio/aspeed-gpio.h b/include/dt-bindings/gpio/aspeed-gpio.h
new file mode 100644
index 0000000000..56fc4889b2
--- /dev/null
+++ b/include/dt-bindings/gpio/aspeed-gpio.h
@@ -0,0 +1,49 @@ 
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * This header provides constants for binding aspeed,*-gpio.
+ *
+ * The first cell in Aspeed's GPIO specifier is the GPIO ID. The macros below
+ * provide names for this.
+ *
+ * The second cell contains standard flag values specified in gpio.h.
+ */
+
+#ifndef _DT_BINDINGS_GPIO_ASPEED_GPIO_H
+#define _DT_BINDINGS_GPIO_ASPEED_GPIO_H
+
+#include <dt-bindings/gpio/gpio.h>
+
+#define ASPEED_GPIO_PORT_A 0
+#define ASPEED_GPIO_PORT_B 1
+#define ASPEED_GPIO_PORT_C 2
+#define ASPEED_GPIO_PORT_D 3
+#define ASPEED_GPIO_PORT_E 4
+#define ASPEED_GPIO_PORT_F 5
+#define ASPEED_GPIO_PORT_G 6
+#define ASPEED_GPIO_PORT_H 7
+#define ASPEED_GPIO_PORT_I 8
+#define ASPEED_GPIO_PORT_J 9
+#define ASPEED_GPIO_PORT_K 10
+#define ASPEED_GPIO_PORT_L 11
+#define ASPEED_GPIO_PORT_M 12
+#define ASPEED_GPIO_PORT_N 13
+#define ASPEED_GPIO_PORT_O 14
+#define ASPEED_GPIO_PORT_P 15
+#define ASPEED_GPIO_PORT_Q 16
+#define ASPEED_GPIO_PORT_R 17
+#define ASPEED_GPIO_PORT_S 18
+#define ASPEED_GPIO_PORT_T 19
+#define ASPEED_GPIO_PORT_U 20
+#define ASPEED_GPIO_PORT_V 21
+#define ASPEED_GPIO_PORT_W 22
+#define ASPEED_GPIO_PORT_X 23
+#define ASPEED_GPIO_PORT_Y 24
+#define ASPEED_GPIO_PORT_Z 25
+#define ASPEED_GPIO_PORT_AA 26
+#define ASPEED_GPIO_PORT_AB 27
+#define ASPEED_GPIO_PORT_AC 28
+
+#define ASPEED_GPIO(port, offset) \
+	((ASPEED_GPIO_PORT_##port * 8) + offset)
+
+#endif