| Message ID | 20220526140456.53776-1-eugen.hristev@microchip.com |
|---|---|
| State | Accepted |
| Commit | 0d60a93053b20dfece6ed85fc2dc69e530c1c8d6 |
| Delegated to: | Eugen Hristev |
| Headers | show |
| Series | [1/3] ARM: dts: at91: replace microchip, 24aa02e48 with atmel, at24c02 | expand |
Am 2022-05-26 16:04, schrieb Eugen Hristev: > microchip,24aa025e48 does not exist in the bindings of this driver. > It can be replaced with atmel,at24c02 which is a standard compatible > and the memory is compatible with this one, depending on the page size. > microchip 24aa02e48 has a page size of 8, while 24aa025e48 has a page > size of 16 bytes. Nice. Thanks for taking care! One minor nit below. > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Reviewed-by: Michael Walle <michael@walle.cc> > --- > arch/arm/dts/at91-sama5d2_icp.dts | 6 +++--- > arch/arm/dts/at91-sama7g5ek.dts | 4 ++-- > arch/arm/dts/sama5d27_som1.dtsi | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/dts/at91-sama5d2_icp.dts > b/arch/arm/dts/at91-sama5d2_icp.dts > index 44522197ff..0b0db1b2be 100644 > --- a/arch/arm/dts/at91-sama5d2_icp.dts > +++ b/arch/arm/dts/at91-sama5d2_icp.dts > @@ -68,19 +68,19 @@ > status = "okay"; > > eeprom@50 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x50>; > pagesize = <16>; > }; > > eeprom@52 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x52>; > pagesize = <16>; > }; > > eeprom@53 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x53>; > pagesize = <16>; > }; > diff --git a/arch/arm/dts/at91-sama7g5ek.dts > b/arch/arm/dts/at91-sama7g5ek.dts > index 086ee45005..eaba0de3f7 100644 > --- a/arch/arm/dts/at91-sama7g5ek.dts > +++ b/arch/arm/dts/at91-sama7g5ek.dts > @@ -405,13 +405,13 @@ > status = "okay"; > > eeprom@52 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x52>; > pagesize = <16>; > }; > > eeprom@53 { > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa025e48, an at24c02 with page size of 16 */ > reg = <0x53>; > pagesize = <16>; > }; > diff --git a/arch/arm/dts/sama5d27_som1.dtsi > b/arch/arm/dts/sama5d27_som1.dtsi > index ea7540bcfc..db4fefadcd 100644 > --- a/arch/arm/dts/sama5d27_som1.dtsi > +++ b/arch/arm/dts/sama5d27_som1.dtsi > @@ -92,7 +92,7 @@ > status = "okay"; > > i2c_eeprom: i2c_eeprom@50 { Nit: that one should actually be just "eeprom@50". -michael > - compatible = "microchip,24aa02e48"; > + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip > 24aa02e48 */ > reg = <0x50>; > }; > };
On 5/26/22 5:11 PM, Michael Walle wrote: [snip] >> @@ -92,7 +92,7 @@ >> status = "okay"; >> >> i2c_eeprom: i2c_eeprom@50 { > > Nit: that one should actually be just "eeprom@50". Hi Michael, That's true, but my patch just changes the compatible . With time, I want to completely sync the DT with Linux. It will take some effort, but I am gathering the pieces of the puzzle slowly. Thanks ! Eugen > > -michael > >> - compatible = "microchip,24aa02e48"; >> + compatible = "atmel,24c02"; /* >> EEPROM is 2Kbits microchip >> 24aa02e48 */ >> reg = <0x50>; >> }; >> };
Hello Eugen, On 26.05.22 16:18, Eugen.Hristev@microchip.com wrote: > On 5/26/22 5:11 PM, Michael Walle wrote: > > [snip] > >>> @@ -92,7 +92,7 @@ >>> status = "okay"; >>> >>> i2c_eeprom: i2c_eeprom@50 { >> >> Nit: that one should actually be just "eeprom@50". > > Hi Michael, > > That's true, but my patch just changes the compatible . > > With time, I want to completely sync the DT with Linux. It will take > some effort, but I am gathering the pieces of the puzzle slowly. > > Thanks ! Fine with me. Reviewed-by: Heiko Schocher <hs@denx.de> bye, Heiko > > Eugen > > >> >> -michael >> >>> - compatible = "microchip,24aa02e48"; >>> + compatible = "atmel,24c02"; /* >>> EEPROM is 2Kbits microchip >>> 24aa02e48 */ >>> reg = <0x50>; >>> }; >>> }; >
On 5/31/22 7:43 AM, Heiko Schocher wrote: > Hello Eugen, > > On 26.05.22 16:18, Eugen.Hristev@microchip.com wrote: >> On 5/26/22 5:11 PM, Michael Walle wrote: >> >> [snip] >> >>>> @@ -92,7 +92,7 @@ >>>> status = "okay"; >>>> >>>> i2c_eeprom: i2c_eeprom@50 { >>> >>> Nit: that one should actually be just "eeprom@50". >> >> Hi Michael, >> >> That's true, but my patch just changes the compatible . >> >> With time, I want to completely sync the DT with Linux. It will take >> some effort, but I am gathering the pieces of the puzzle slowly. >> >> Thanks ! > > Fine with me. > > Reviewed-by: Heiko Schocher <hs@denx.de> Applied the series to u-boot-at91/next Thanks for reviewing. Eugen > > bye, > Heiko >> >> Eugen >> >> >>> >>> -michael >>> >>>> - compatible = "microchip,24aa02e48"; >>>> + compatible = "atmel,24c02"; /* >>>> EEPROM is 2Kbits microchip >>>> 24aa02e48 */ >>>> reg = <0x50>; >>>> }; >>>> }; >> > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de >
diff --git a/arch/arm/dts/at91-sama5d2_icp.dts b/arch/arm/dts/at91-sama5d2_icp.dts index 44522197ff..0b0db1b2be 100644 --- a/arch/arm/dts/at91-sama5d2_icp.dts +++ b/arch/arm/dts/at91-sama5d2_icp.dts @@ -68,19 +68,19 @@ status = "okay"; eeprom@50 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x50>; pagesize = <16>; }; eeprom@52 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x52>; pagesize = <16>; }; eeprom@53 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x53>; pagesize = <16>; }; diff --git a/arch/arm/dts/at91-sama7g5ek.dts b/arch/arm/dts/at91-sama7g5ek.dts index 086ee45005..eaba0de3f7 100644 --- a/arch/arm/dts/at91-sama7g5ek.dts +++ b/arch/arm/dts/at91-sama7g5ek.dts @@ -405,13 +405,13 @@ status = "okay"; eeprom@52 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x52>; pagesize = <16>; }; eeprom@53 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa025e48, an at24c02 with page size of 16 */ reg = <0x53>; pagesize = <16>; }; diff --git a/arch/arm/dts/sama5d27_som1.dtsi b/arch/arm/dts/sama5d27_som1.dtsi index ea7540bcfc..db4fefadcd 100644 --- a/arch/arm/dts/sama5d27_som1.dtsi +++ b/arch/arm/dts/sama5d27_som1.dtsi @@ -92,7 +92,7 @@ status = "okay"; i2c_eeprom: i2c_eeprom@50 { - compatible = "microchip,24aa02e48"; + compatible = "atmel,24c02"; /* EEPROM is 2Kbits microchip 24aa02e48 */ reg = <0x50>; }; };
microchip,24aa025e48 does not exist in the bindings of this driver. It can be replaced with atmel,at24c02 which is a standard compatible and the memory is compatible with this one, depending on the page size. microchip 24aa02e48 has a page size of 8, while 24aa025e48 has a page size of 16 bytes. Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- arch/arm/dts/at91-sama5d2_icp.dts | 6 +++--- arch/arm/dts/at91-sama7g5ek.dts | 4 ++-- arch/arm/dts/sama5d27_som1.dtsi | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)