| Message ID | 20220511182828.26890-1-pali@kernel.org |
|---|---|
| State | Accepted |
| Commit | c1abf7659c9b29874d9d718df6890de1638cedba |
| Delegated to: | Peng Fan |
| Headers | show |
| Series | mmc: fsl_esdhc_spl: Fix checking for number of read sectors | expand |
On 5/12/22 03:28, Pali Rohár wrote: > Commit 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy > support") changed number of sectors which are read but did not adjusted > error check. > > Fix it and check for if correct number of sectors were read. > > Fixes: 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support") > Signed-off-by: Pali Rohár <pali@kernel.org> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/fsl_esdhc_spl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c > index ea8f4cd66964..760f13d24018 100644 > --- a/drivers/mmc/fsl_esdhc_spl.c > +++ b/drivers/mmc/fsl_esdhc_spl.c > @@ -106,7 +106,7 @@ again: > blk_off = (sector * 512) % mmc->read_bl_len; > blk_cnt = DIV_ROUND_UP(512, mmc->read_bl_len); > err = mmc->block_dev.block_read(&mmc->block_dev, blk_start, blk_cnt, tmp_buf); > - if (err != 1) { > + if (err != blk_cnt) { > puts("spl: mmc read failed!!\n"); > hang(); > }
On Wed, May 11, 2022 at 08:28:28PM +0200, Pali Rohár wrote: > Commit 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy > support") changed number of sectors which are read but did not adjusted > error check. > > Fix it and check for if correct number of sectors were read. > > Fixes: 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support") > Signed-off-by: Pali Rohár <pali@kernel.org> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Applied to u-boot/master, thanks!
diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c index ea8f4cd66964..760f13d24018 100644 --- a/drivers/mmc/fsl_esdhc_spl.c +++ b/drivers/mmc/fsl_esdhc_spl.c @@ -106,7 +106,7 @@ again: blk_off = (sector * 512) % mmc->read_bl_len; blk_cnt = DIV_ROUND_UP(512, mmc->read_bl_len); err = mmc->block_dev.block_read(&mmc->block_dev, blk_start, blk_cnt, tmp_buf); - if (err != 1) { + if (err != blk_cnt) { puts("spl: mmc read failed!!\n"); hang(); }
Commit 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support") changed number of sectors which are read but did not adjusted error check. Fix it and check for if correct number of sectors were read. Fixes: 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support") Signed-off-by: Pali Rohár <pali@kernel.org> --- drivers/mmc/fsl_esdhc_spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)