diff mbox series

[2/3] examples: hello_world: Drop inclusion of common header

Message ID 20220505153242.1598807-3-paul.barker@sancloud.com
State Accepted
Delegated to: Tom Rini
Headers show
Series Clarify standalone application support | expand

Commit Message

Paul Barker May 5, 2022, 3:32 p.m. UTC
The "common.h" header is not covered by the licensing exception for
standalone applications. Let's drop inclusion of this header from the
hello_world example to prove that a standalone app can be built without
it.

Signed-off-by: Paul Barker <paul.barker@sancloud.com>
---
 examples/standalone/hello_world.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tom Rini May 11, 2022, 1:34 p.m. UTC | #1
On Thu, May 05, 2022 at 03:32:41PM +0000, Paul Barker wrote:

> The "common.h" header is not covered by the licensing exception for
> standalone applications. Let's drop inclusion of this header from the
> hello_world example to prove that a standalone app can be built without
> it.
> 
> Signed-off-by: Paul Barker <paul.barker@sancloud.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Wolfgang Denk Aug. 26, 2022, 1:36 p.m. UTC | #2
Dear Paul,

In message <20220505153242.1598807-3-paul.barker@sancloud.com> you wrote:
> The "common.h" header is not covered by the licensing exception for
> standalone applications. Let's drop inclusion of this header from the
> hello_world example to prove that a standalone app can be built without
> it.
>
> Signed-off-by: Paul Barker <paul.barker@sancloud.com>
> ---
>  examples/standalone/hello_world.c | 1 -
>  1 file changed, 1 deletion(-)

Acked-off-by: Wolfgang Denk <wd@denx.de>

Best regards,

Wolfgang Denk
Tom Rini Oct. 26, 2022, 7:26 p.m. UTC | #3
On Thu, May 05, 2022 at 03:32:41PM +0000, Paul Barker wrote:

> The "common.h" header is not covered by the licensing exception for
> standalone applications. Let's drop inclusion of this header from the
> hello_world example to prove that a standalone app can be built without
> it.
> 
> Signed-off-by: Paul Barker <paul.barker@sancloud.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/examples/standalone/hello_world.c b/examples/standalone/hello_world.c
index 263cd9ca079d..27ec3793155d 100644
--- a/examples/standalone/hello_world.c
+++ b/examples/standalone/hello_world.c
@@ -4,7 +4,6 @@ 
  * Wolfgang Denk, DENX Software Engineering, wd@denx.de.
  */
 
-#include <common.h>
 #include <exports.h>
 
 int hello_world(int argc, char *const argv[])