| Message ID | 20220330091443.34177-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted, archived |
| Commit | b6370aca3709ef23a9e8fe556beaa2e4b4e089c3 |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | [v1,1/1] efi_loader: initrddump: Actually use the custom CFLAGS | expand |
On 3/30/22 11:14, Andy Shevchenko wrote: > It seems a copy'n'paste typo when tool had been introduced. > It has never had the 'exit' suffix in the file name. Hence, > the custom CFLAGS never been applied and, for example, BFD > linker complains: > > LD lib/efi_loader/initrddump_efi.so > ld.bfd: lib/efi_loader/initrddump.o: warning: relocation in read-only section `.text.efi_main' > ld.bfd: warning: creating DT_TEXTREL in a shared object > > Remove wrong 'exit' suffix from the custom CFLAGS variable. > > Fixes: 65ab48d69ddb ("efi_selftest: provide initrddump test tool") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > lib/efi_loader/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile > index befed7144e78..034d26cf0109 100644 > --- a/lib/efi_loader/Makefile > +++ b/lib/efi_loader/Makefile > @@ -16,7 +16,7 @@ CFLAGS_helloworld.o := $(CFLAGS_EFI) -Os -ffreestanding > CFLAGS_REMOVE_helloworld.o := $(CFLAGS_NON_EFI) > CFLAGS_dtbdump.o := $(CFLAGS_EFI) -Os -ffreestanding > CFLAGS_REMOVE_dtbdump.o := $(CFLAGS_NON_EFI) > -CFLAGS_initrddump_exit.o := $(CFLAGS_EFI) -Os -ffreestanding > +CFLAGS_initrddump.o := $(CFLAGS_EFI) -Os -ffreestanding > CFLAGS_REMOVE_initrddump.o := $(CFLAGS_NON_EFI) > > ifneq ($(CONFIG_CMD_BOOTEFI_HELLO_COMPILE),)
diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile index befed7144e78..034d26cf0109 100644 --- a/lib/efi_loader/Makefile +++ b/lib/efi_loader/Makefile @@ -16,7 +16,7 @@ CFLAGS_helloworld.o := $(CFLAGS_EFI) -Os -ffreestanding CFLAGS_REMOVE_helloworld.o := $(CFLAGS_NON_EFI) CFLAGS_dtbdump.o := $(CFLAGS_EFI) -Os -ffreestanding CFLAGS_REMOVE_dtbdump.o := $(CFLAGS_NON_EFI) -CFLAGS_initrddump_exit.o := $(CFLAGS_EFI) -Os -ffreestanding +CFLAGS_initrddump.o := $(CFLAGS_EFI) -Os -ffreestanding CFLAGS_REMOVE_initrddump.o := $(CFLAGS_NON_EFI) ifneq ($(CONFIG_CMD_BOOTEFI_HELLO_COMPILE),)
It seems a copy'n'paste typo when tool had been introduced. It has never had the 'exit' suffix in the file name. Hence, the custom CFLAGS never been applied and, for example, BFD linker complains: LD lib/efi_loader/initrddump_efi.so ld.bfd: lib/efi_loader/initrddump.o: warning: relocation in read-only section `.text.efi_main' ld.bfd: warning: creating DT_TEXTREL in a shared object Remove wrong 'exit' suffix from the custom CFLAGS variable. Fixes: 65ab48d69ddb ("efi_selftest: provide initrddump test tool") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- lib/efi_loader/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)