| Message ID | 20220311191005.364540-3-sjg@chromium.org |
|---|---|
| State | Rejected |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Reduce size of a few boards | expand |
On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > This board is right up against the size limit. Drop ext4 writing to give > it some more space. > > Signed-off-by: Simon Glass <sjg@chromium.org> I would really like to see what LTO does here instead of removing functionality. I'm sure it shrinks things enough to fit, but it does need run time testing.
On 11.03.22 20:10, Simon Glass wrote: > This board is right up against the size limit. Drop ext4 writing to give > it some more space. > > Signed-off-by: Simon Glass <sjg@chromium.org> NAK. At least for now. We should not randomly disable user visible functionality and not without investigating other possible options. Regards, Soeren > --- > > configs/tbs2910_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > index e1278f2e70a..9819df55f05 100644 > --- a/configs/tbs2910_defconfig > +++ b/configs/tbs2910_defconfig > @@ -50,7 +50,6 @@ CONFIG_CMD_TIME=y > CONFIG_CMD_SYSBOOT=y > CONFIG_CMD_EXT2=y > CONFIG_CMD_EXT4=y > -CONFIG_CMD_EXT4_WRITE=y > CONFIG_CMD_FAT=y > CONFIG_CMD_FS_GENERIC=y > CONFIG_EFI_PARTITION=y
Hi Tom, On Fri, 11 Mar 2022 at 12:58, Tom Rini <trini@konsulko.com> wrote: > > On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > > > This board is right up against the size limit. Drop ext4 writing to give > > it some more space. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > I would really like to see what LTO does here instead of removing > functionality. I'm sure it shrinks things enough to fit, but it does > need run time testing. Well let's see if the maintainer responds. But this is blocking the EFI series which we really need to get in it. It can always be cleaned up later. Regards, Simon
On Fri, Mar 11, 2022 at 07:24:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Fri, 11 Mar 2022 at 12:58, Tom Rini <trini@konsulko.com> wrote: > > > > On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > > > > > This board is right up against the size limit. Drop ext4 writing to give > > > it some more space. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > I would really like to see what LTO does here instead of removing > > functionality. I'm sure it shrinks things enough to fit, but it does > > need run time testing. > > Well let's see if the maintainer responds. But this is blocking the > EFI series which we really need to get in it. It can always be cleaned > up later. Erm, Soeren has been quite responsive.
Hi Soeren, On Fri, 11 Mar 2022 at 15:57, Soeren Moch <smoch@web.de> wrote: > > > > On 11.03.22 20:10, Simon Glass wrote: > > This board is right up against the size limit. Drop ext4 writing to give > > it some more space. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > NAK. > > At least for now. > We should not randomly disable user visible functionality and not > without investigating other possible options. OK please go ahead and send a suitable patch. Regards, Simon > > --- > > > > configs/tbs2910_defconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig > > index e1278f2e70a..9819df55f05 100644 > > --- a/configs/tbs2910_defconfig > > +++ b/configs/tbs2910_defconfig > > @@ -50,7 +50,6 @@ CONFIG_CMD_TIME=y > > CONFIG_CMD_SYSBOOT=y > > CONFIG_CMD_EXT2=y > > CONFIG_CMD_EXT4=y > > -CONFIG_CMD_EXT4_WRITE=y > > CONFIG_CMD_FAT=y > > CONFIG_CMD_FS_GENERIC=y > > CONFIG_EFI_PARTITION=y >
Hi Tom, On Fri, 11 Mar 2022 at 21:04, Tom Rini <trini@konsulko.com> wrote: > > On Fri, Mar 11, 2022 at 07:24:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 11 Mar 2022 at 12:58, Tom Rini <trini@konsulko.com> wrote: > > > > > > On Fri, Mar 11, 2022 at 12:10:02PM -0700, Simon Glass wrote: > > > > > > > This board is right up against the size limit. Drop ext4 writing to give > > > > it some more space. > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > > > I would really like to see what LTO does here instead of removing > > > functionality. I'm sure it shrinks things enough to fit, but it does > > > need run time testing. > > > > Well let's see if the maintainer responds. But this is blocking the > > EFI series which we really need to get in it. It can always be cleaned > > up later. > > Erm, Soeren has been quite responsive. OK, good. It even looks like our emails crossed. Regards, Simon
diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig index e1278f2e70a..9819df55f05 100644 --- a/configs/tbs2910_defconfig +++ b/configs/tbs2910_defconfig @@ -50,7 +50,6 @@ CONFIG_CMD_TIME=y CONFIG_CMD_SYSBOOT=y CONFIG_CMD_EXT2=y CONFIG_CMD_EXT4=y -CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_EFI_PARTITION=y
This board is right up against the size limit. Drop ext4 writing to give it some more space. Signed-off-by: Simon Glass <sjg@chromium.org> --- configs/tbs2910_defconfig | 1 - 1 file changed, 1 deletion(-)