| Message ID | 20220122050728.v5.11.Ic815ec868a958977d6de91d02851622dce6147a5@changeid |
|---|---|
| State | Accepted |
| Commit | 8ca0931a913d5e25232c454ceca70635c49058dc |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | kconfig: Add some new macros | expand |
On Sat, Jan 22, 2022 at 05:07:32AM -0700, Simon Glass wrote: > If a thread crashes it is helpful to try the operation again with > threading disabled. Add a hint about that. > > Signed-off-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index 3e450e40670..0faa3ac9385 100644 --- a/tools/buildman/builderthread.py +++ b/tools/buildman/builderthread.py @@ -557,6 +557,6 @@ class BuilderThread(threading.Thread): try: self.RunJob(job) except Exception as e: - print('Thread exception:', e) + print('Thread exception (use -T0 to run without threads):', e) self.builder.thread_exceptions.append(e) self.builder.queue.task_done() diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index e09ccb742e8..c2e0b0b5c62 100644 --- a/tools/buildman/func_test.py +++ b/tools/buildman/func_test.py @@ -623,4 +623,6 @@ class TestFunctional(unittest.TestCase): with test_util.capture_sys_output() as (stdout, stderr): self.assertEqual(102, self._RunControl('-o', self._output_dir, test_thread_exceptions=True)) - self.assertIn('Thread exception: test exception', stdout.getvalue()) + self.assertIn( + 'Thread exception (use -T0 to run without threads): test exception', + stdout.getvalue())
If a thread crashes it is helpful to try the operation again with threading disabled. Add a hint about that. Signed-off-by: Simon Glass <sjg@chromium.org> --- (no changes since v1) tools/buildman/builderthread.py | 2 +- tools/buildman/func_test.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)