| Message ID | 20220117135721.196379-1-angus@akkea.ca |
|---|---|
| State | Accepted |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [v3] drivers: spi-nor: Add JEDEC id for W25Q16JV | expand |
On Mon, Jan 17, 2022 at 7:27 PM Angus Ainslie <angus@akkea.ca> wrote: > > Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with > DUAL/QUAD SPI > > Changes since v2: > > Chagned the name to follow "DTR" parts > > Changes since v1: > > Updated the name for more suffixes > > Signed-off-by: Angus Ainslie <angus@akkea.ca> > --- > drivers/mtd/spi/spi-nor-ids.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c > index b551ebd75e..08e386fbf5 100644 > --- a/drivers/mtd/spi/spi-nor-ids.c > +++ b/drivers/mtd/spi/spi-nor-ids.c > @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > }, > + { > + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, Can this name as "w25q16jv-im/jm" ? Jagan.
>> + { >> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, > > Can this name as "w25q16jv-im/jm" ? FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this particular flash the name in linux is "w25q16jv-im/jm".. Anyhow, see [1] for a lengthy discussion on that name. That being said, I still don't share Tudors opinion on using that made up name, just because no one will find any flash if one searches for w25q16jvm in the internet. -michael [1] https://lore.kernel.org/linux-mtd/20200103223423.14025-1-michael@walle.cc/
Hi Jagan, On 2022-01-20 04:55, Jagan Teki wrote: > On Mon, Jan 17, 2022 at 7:27 PM Angus Ainslie <angus@akkea.ca> wrote: >> >> Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory >> with >> DUAL/QUAD SPI >> >> Changes since v2: >> >> Chagned the name to follow "DTR" parts >> >> Changes since v1: >> >> Updated the name for more suffixes >> >> Signed-off-by: Angus Ainslie <angus@akkea.ca> >> --- >> drivers/mtd/spi/spi-nor-ids.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c >> b/drivers/mtd/spi/spi-nor-ids.c >> index b551ebd75e..08e386fbf5 100644 >> --- a/drivers/mtd/spi/spi-nor-ids.c >> +++ b/drivers/mtd/spi/spi-nor-ids.c >> @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { >> SECT_4K | SPI_NOR_DUAL_READ | >> SPI_NOR_QUAD_READ | >> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) >> }, >> + { >> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, > > Can this name as "w25q16jv-im/jm" ? > I sent a v2 with that name and there was one comment to change it to this name. If you prefer please use v2 instead. https://lists.denx.de/pipermail/u-boot/2022-January/471874.html Thanks Angus > Jagan.
On 1/20/22 3:20 PM, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >>> + { >>> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, >> >> Can this name as "w25q16jv-im/jm" ? > > FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this > particular flash the name in linux is "w25q16jv-im/jm".. would you fix it? :D > > Anyhow, see [1] for a lengthy discussion on that name. That being said, I > still don't share Tudors opinion on using that made up name, just because > no one will find any flash if one searches for w25q16jvm in the internet. The temperature range "I/J" is skipped in the name because it does not have any influence on the jedec-id. That's why we don't include the "Package Type" field in the naming convention as well. > > -michael > > [1] https://lore.kernel.org/linux-mtd/20200103223423.14025-1-michael@walle.cc/ >
On Thu, Jan 20, 2022 at 7:53 PM <Tudor.Ambarus@microchip.com> wrote: > > On 1/20/22 3:20 PM, Michael Walle wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > >>> + { > >>> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, > >> > >> Can this name as "w25q16jv-im/jm" ? > > > > FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this > > particular flash the name in linux is "w25q16jv-im/jm".. > > would you fix it? :D > > > > > Anyhow, see [1] for a lengthy discussion on that name. That being said, I > > still don't share Tudors opinion on using that made up name, just because > > no one will find any flash if one searches for w25q16jvm in the internet. > > The temperature range "I/J" is skipped in the name because it does not have > any influence on the jedec-id. That's why we don't include the "Package Type" > field in the naming convention as well. Okay, I'm merging v3. let me know if you have any questions? Thanks, Jagan.
On 1/20/22 4:39 PM, Jagan Teki wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, Jan 20, 2022 at 7:53 PM <Tudor.Ambarus@microchip.com> wrote: >> >> On 1/20/22 3:20 PM, Michael Walle wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>>>> + { >>>>> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, >>>> >>>> Can this name as "w25q16jv-im/jm" ? >>> >>> FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this >>> particular flash the name in linux is "w25q16jv-im/jm".. >> >> would you fix it? :D >> >>> >>> Anyhow, see [1] for a lengthy discussion on that name. That being said, I >>> still don't share Tudors opinion on using that made up name, just because >>> no one will find any flash if one searches for w25q16jvm in the internet. >> >> The temperature range "I/J" is skipped in the name because it does not have >> any influence on the jedec-id. That's why we don't include the "Package Type" >> field in the naming convention as well. > > Okay, I'm merging v3. let me know if you have any questions? > For now it should be fine. But if anyone is feeling brave enough maybe we should fix the naming scheme for winbond once and for all. It seems that the flashes were we append "m" support DTR, and in fact winbond names them blabla-dtr [1]. So instead of "w25q16jvm" maybe it's better to convert to "w25q16jv-dtr". Are there any volunteers to check if my assumption is correct? [1] https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash/?__locale=en&selected=128Mb#Density
On 1/20/2022 7:46 AM, Tudor.Ambarus@microchip.com wrote: >>>> FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this >>>> particular flash the name in linux is "w25q16jv-im/jm".. >>> >>> would you fix it? :D >>> >>>> >>>> Anyhow, see [1] for a lengthy discussion on that name. That being said, I >>>> still don't share Tudors opinion on using that made up name, just because >>>> no one will find any flash if one searches for w25q16jvm in the internet. >>> >>> The temperature range "I/J" is skipped in the name because it does not have >>> any influence on the jedec-id. That's why we don't include the "Package Type" >>> field in the naming convention as well. >> >> Okay, I'm merging v3. let me know if you have any questions? >> > > For now it should be fine. But if anyone is feeling brave enough maybe we should > fix the naming scheme for winbond once and for all. It seems that the flashes > were we append "m" support DTR, and in fact winbond names them blabla-dtr [1]. > So instead of "w25q16jvm" maybe it's better to convert to "w25q16jv-dtr". > Are there any volunteers to check if my assumption is correct? > > [1] https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash/?__locale=en&selected=128Mb#Density I would be happy to do it if there's consensus that we can break downstream device-tree users that hold older compatible string :-). I thought of w25q512jv-dtr for my patch [1] but saw "m" suffix used for other dtr parts. On related note, that array can be sorted by Device ID. [1] https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/ Dhananjay
On 1/21/22 12:52 AM, Dhananjay Phadke wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 1/20/2022 7:46 AM, Tudor.Ambarus@microchip.com wrote: >>>>> FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this >>>>> particular flash the name in linux is "w25q16jv-im/jm".. >>>> >>>> would you fix it? :D >>>> >>>>> >>>>> Anyhow, see [1] for a lengthy discussion on that name. That being said, I >>>>> still don't share Tudors opinion on using that made up name, just because >>>>> no one will find any flash if one searches for w25q16jvm in the internet. >>>> >>>> The temperature range "I/J" is skipped in the name because it does not have >>>> any influence on the jedec-id. That's why we don't include the "Package Type" >>>> field in the naming convention as well. >>> >>> Okay, I'm merging v3. let me know if you have any questions? >>> >> >> For now it should be fine. But if anyone is feeling brave enough maybe we should >> fix the naming scheme for winbond once and for all. It seems that the flashes >> were we append "m" support DTR, and in fact winbond names them blabla-dtr [1]. >> So instead of "w25q16jvm" maybe it's better to convert to "w25q16jv-dtr". >> Are there any volunteers to check if my assumption is correct? >> >> [1] https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash/?__locale=en&selected=128Mb#Density > > I would be happy to do it if there's consensus that we can break > downstream device-tree users that hold older compatible string :-). aren't these flashes using the generic jedec,spi-nor compatible? > > I thought of w25q512jv-dtr for my patch [1] but saw "m" suffix used for > other dtr parts. > > On related note, that array can be sorted by Device ID. better to order them alphabetically, not by jedec ID. > > [1] > https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/ > > Dhananjay >
On 1/21/22 6:34 AM, Tudor.Ambarus@microchip.com wrote: >> On related note, that array can be sorted by Device ID. > better to order them alphabetically, not by jedec ID. > alphabetically by name I meant, it's easier for humans to identify a flash.
On 2022-01-20 06:39, Jagan Teki wrote: > On Thu, Jan 20, 2022 at 7:53 PM <Tudor.Ambarus@microchip.com> wrote: >> >> On 1/20/22 3:20 PM, Michael Walle wrote: >> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> > >> >>> + { >> >>> + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, >> >> >> >> Can this name as "w25q16jv-im/jm" ? >> > >> > FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this >> > particular flash the name in linux is "w25q16jv-im/jm".. >> >> would you fix it? :D >> >> > >> > Anyhow, see [1] for a lengthy discussion on that name. That being said, I >> > still don't share Tudors opinion on using that made up name, just because >> > no one will find any flash if one searches for w25q16jvm in the internet. >> >> The temperature range "I/J" is skipped in the name because it does not >> have >> any influence on the jedec-id. That's why we don't include the >> "Package Type" >> field in the naming convention as well. > > Okay, I'm merging v3. let me know if you have any questions? > Thanks ! > Thanks, > Jagan.
Hi Jagan, [snip] On 2022-01-20 06:39, Jagan Teki wrote: > > Okay, I'm merging v3. let me know if you have any questions? > I didn't see this go in yet. Should it be in u-boot master ? Thanks Angus > Thanks, > Jagan.
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index b551ebd75e..08e386fbf5 100644 --- a/drivers/mtd/spi/spi-nor-ids.c +++ b/drivers/mtd/spi/spi-nor-ids.c @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, + { + INFO("w25q16jvm", 0xef7015, 0, 64 * 1024, 32, + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + }, { INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI Changes since v2: Chagned the name to follow "DTR" parts Changes since v1: Updated the name for more suffixes Signed-off-by: Angus Ainslie <angus@akkea.ca> --- drivers/mtd/spi/spi-nor-ids.c | 5 +++++ 1 file changed, 5 insertions(+)