| Message ID | 20211125180522.4113337-1-john@metanate.com |
|---|---|
| State | Accepted |
| Commit | eaee44aaaa43ad138a9b730e17e370e83bba6cf5 |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | rockchip: boot_mode: fix fastboot command | expand |
On 2021/11/26 上午2:05, John Keeping wrote: > The USB controller index must be separated from the type argument, > otherwise the preboot command fails with the error: > > Error: Wrong USB controller index format > > Add the missing space to fix fastboot mode here. > > Signed-off-by: John Keeping <john@metanate.com> Reviewed-by: Kever Yang <kever.yang@rock-chips.com> Thanks, - Kever > --- > > arch/arm/mach-rockchip/boot_mode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c > index 2158934159..1a1a887fc2 100644 > --- a/arch/arm/mach-rockchip/boot_mode.c > +++ b/arch/arm/mach-rockchip/boot_mode.c > @@ -95,7 +95,7 @@ int setup_boot_mode(void) > switch (boot_mode) { > case BOOT_FASTBOOT: > debug("%s: enter fastboot!\n", __func__); > - env_set("preboot", "setenv preboot; fastboot usb0"); > + env_set("preboot", "setenv preboot; fastboot usb 0"); > break; > case BOOT_UMS: > debug("%s: enter UMS!\n", __func__);
diff --git a/arch/arm/mach-rockchip/boot_mode.c b/arch/arm/mach-rockchip/boot_mode.c index 2158934159..1a1a887fc2 100644 --- a/arch/arm/mach-rockchip/boot_mode.c +++ b/arch/arm/mach-rockchip/boot_mode.c @@ -95,7 +95,7 @@ int setup_boot_mode(void) switch (boot_mode) { case BOOT_FASTBOOT: debug("%s: enter fastboot!\n", __func__); - env_set("preboot", "setenv preboot; fastboot usb0"); + env_set("preboot", "setenv preboot; fastboot usb 0"); break; case BOOT_UMS: debug("%s: enter UMS!\n", __func__);
The USB controller index must be separated from the type argument, otherwise the preboot command fails with the error: Error: Wrong USB controller index format Add the missing space to fix fastboot mode here. Signed-off-by: John Keeping <john@metanate.com> --- arch/arm/mach-rockchip/boot_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)