diff mbox series

ARM: dts: stm32: Add custom PHY reset bindings on AV96

Message ID 20211113022737.232052-1-marex@denx.de
State Accepted
Commit 312011e8e7ba1a5cf2234dae73daa8304f5993dd
Delegated to: Patrice Chotard
Headers show
Series ARM: dts: stm32: Add custom PHY reset bindings on AV96 | expand

Commit Message

Marek Vasut Nov. 13, 2021, 2:27 a.m. UTC
The ethernet PHY must be reset on AV96, however DWMAC currently does
not support the MDIO-bus PHY GPIO reset bindings and the ethernet MAC
PHY reset property is going away on next DT sync. Add PHY specific
reset bindings to trigger the PHY reset and fix sporadic ethernet
malfunctions, until the next DT sync.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
---
 arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Patrice CHOTARD Nov. 15, 2021, 8:16 a.m. UTC | #1
Hi Marek

On 11/13/21 3:27 AM, Marek Vasut wrote:
> The ethernet PHY must be reset on AV96, however DWMAC currently does
> not support the MDIO-bus PHY GPIO reset bindings and the ethernet MAC
> PHY reset property is going away on next DT sync. Add PHY specific
> reset bindings to trigger the PHY reset and fix sporadic ethernet
> malfunctions, until the next DT sync.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>  arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
> index 8b275e4950e..4b1dbf08387 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
> +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
> @@ -19,6 +19,17 @@
>  	};
>  };
>  
> +
> +&ethernet0 {
> +	mdio0 {
> +		ethernet-phy@7 {
> +			reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
> +			reset-assert-us = <11000>;
> +			reset-deassert-us = <1000>;
> +		};
> +	};
> +};
> +
>  &sdmmc1 {
>  	u-boot,dm-spl;
>  };
> 
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
Patrick DELAUNAY Nov. 15, 2021, 11:31 a.m. UTC | #2
Hi Marek,

On 11/13/21 3:27 AM, Marek Vasut wrote:
> The ethernet PHY must be reset on AV96, however DWMAC currently does
> not support the MDIO-bus PHY GPIO reset bindings and the ethernet MAC
> PHY reset property is going away on next DT sync. Add PHY specific
> reset bindings to trigger the PHY reset and fix sporadic ethernet
> malfunctions, until the next DT sync.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
>   arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
> index 8b275e4950e..4b1dbf08387 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
> +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
> @@ -19,6 +19,17 @@
>   	};
>   };
>   
> +
> +&ethernet0 {
> +	mdio0 {
> +		ethernet-phy@7 {
> +			reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
> +			reset-assert-us = <11000>;
> +			reset-deassert-us = <1000>;
> +		};
> +	};
> +};
> +
>   &sdmmc1 {
>   	u-boot,dm-spl;
>   };


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick
Patrice CHOTARD Nov. 30, 2021, 10:31 a.m. UTC | #3
HI Marek

On 11/15/21 12:31 PM, Patrick DELAUNAY wrote:
> Hi Marek,
> 
> On 11/13/21 3:27 AM, Marek Vasut wrote:
>> The ethernet PHY must be reset on AV96, however DWMAC currently does
>> not support the MDIO-bus PHY GPIO reset bindings and the ethernet MAC
>> PHY reset property is going away on next DT sync. Add PHY specific
>> reset bindings to trigger the PHY reset and fix sporadic ethernet
>> malfunctions, until the next DT sync.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> ---
>>   arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
>> index 8b275e4950e..4b1dbf08387 100644
>> --- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
>> @@ -19,6 +19,17 @@
>>       };
>>   };
>>   +
>> +&ethernet0 {
>> +    mdio0 {
>> +        ethernet-phy@7 {
>> +            reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
>> +            reset-assert-us = <11000>;
>> +            reset-deassert-us = <1000>;
>> +        };
>> +    };
>> +};
>> +
>>   &sdmmc1 {
>>       u-boot,dm-spl;
>>   };
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 
> 
> 
Applied to u-boot-stm32/next

Thanks
Patrice
diff mbox series

Patch

diff --git a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
index 8b275e4950e..4b1dbf08387 100644
--- a/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp15xx-dhcor-avenger96-u-boot.dtsi
@@ -19,6 +19,17 @@ 
 	};
 };
 
+
+&ethernet0 {
+	mdio0 {
+		ethernet-phy@7 {
+			reset-gpios = <&gpioz 2 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <11000>;
+			reset-deassert-us = <1000>;
+		};
+	};
+};
+
 &sdmmc1 {
 	u-boot,dm-spl;
 };