diff mbox series

[v6,11/11] verdin-imx8mm: fix watchdog pinctrl issue

Message ID 20211009204113.1208641-12-marcel@ziswiler.com
State Accepted
Commit f254a46809a09f14f82ab6fcf5d28d2f60e0547b
Delegated to: Stefano Babic
Headers show
Series board: toradex: verdin-imx8mm: target refresh | expand

Commit Message

Marcel Ziswiler Oct. 9, 2021, 8:41 p.m. UTC 
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Finally, found the root cause of the issue already once mentioned back
here [2] which caused the following error message during boot:

imx_wdt watchdog@30280000:
 pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19

Turns out while the watchdog node itself was already u-boot,dm-spl its
pinctrl node was not which caused it to be unavailable at that early
stage. Note that any and all other boards I checked also seem to be
missing this. However, I can't judge whether or not they might indeed
need a similar fix or not.

[2] https://marc.info/?l=u-boot&m=161786572422973

Fixes: commit d304e7ace3a6
 ("ARM: imx8m: Fix reset in SPL on Toradex iMX8MM Verdin")
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

---

(no changes since v2)

Changes in v2:
- New patch fixing watchdog pinctrl issue.

 arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Stefano Babic Oct. 20, 2021, 2:43 p.m. UTC | #1 
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Finally, found the root cause of the issue already once mentioned back
> here [2] which caused the following error message during boot:
> imx_wdt watchdog@30280000:
>  pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19
> Turns out while the watchdog node itself was already u-boot,dm-spl its
> pinctrl node was not which caused it to be unavailable at that early
> stage. Note that any and all other boards I checked also seem to be
> missing this. However, I can't judge whether or not they might indeed
> need a similar fix or not.
> [2] https://marc.info/?l=u-boot&m=161786572422973
> Fixes: commit d304e7ace3a6
>  ("ARM: imx8m: Fix reset in SPL on Toradex iMX8MM Verdin")
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
index 6a7e9d776c8..9fb4d8aa8c2 100644
--- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
+++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
@@ -76,6 +76,10 @@ 
 	u-boot,dm-spl;
 };
 
+&pinctrl_wdog {
+	u-boot,dm-spl;
+};
+
 &uart1 {
 	u-boot,dm-spl;
 };