diff mbox series

arm: mvebu: dts: Armada8k enable mdio

Message ID 20210824081425.39426-1-sven.auhagen@voleatech.de
State Accepted
Commit 88426bd6b08e42ce3ca2b1b9c3e11e5c390c3020
Delegated to: Stefan Roese
Headers show
Series arm: mvebu: dts: Armada8k enable mdio | expand

Commit Message

Sven Auhagen Aug. 24, 2021, 8:14 a.m. UTC 
From: Sven Auhagen <Sven.Auhagen@voleatech.de>

Since mvpp2 is using the new mdio driver and the cp110 has been
synced with the linux upstream, the mdio has to enabled in the
device tree file.
This is missing for some device tree files and therefore the
network cards do not come online.

Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
---
 arch/arm/dts/armada-7040-db.dts             | 1 +
 arch/arm/dts/armada-8040-clearfog-gt-8k.dts | 1 +
 arch/arm/dts/armada-8040-db.dts             | 1 +
 arch/arm/dts/armada-8040-mcbin.dts          | 1 +
 4 files changed, 4 insertions(+)

Comments

Stefan Roese Sept. 10, 2021, 6:55 a.m. UTC | #1 
On 24.08.21 10:14, sven.auhagen@voleatech.de wrote:
> From: Sven Auhagen <Sven.Auhagen@voleatech.de>
> 
> Since mvpp2 is using the new mdio driver and the cp110 has been
> synced with the linux upstream, the mdio has to enabled in the
> device tree file.
> This is missing for some device tree files and therefore the
> network cards do not come online.
> 
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/dts/armada-7040-db.dts             | 1 +
>   arch/arm/dts/armada-8040-clearfog-gt-8k.dts | 1 +
>   arch/arm/dts/armada-8040-db.dts             | 1 +
>   arch/arm/dts/armada-8040-mcbin.dts          | 1 +
>   4 files changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/armada-7040-db.dts b/arch/arm/dts/armada-7040-db.dts
> index b158f92349..9104042359 100644
> --- a/arch/arm/dts/armada-7040-db.dts
> +++ b/arch/arm/dts/armada-7040-db.dts
> @@ -175,6 +175,7 @@
>   };
>   
>   &cp0_mdio {
> +	status = "okay";
>   	phy0: ethernet-phy@0 {
>   		reg = <0>;
>   	};
> diff --git a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> index 6a586dbbba..79ee871c5a 100644
> --- a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> @@ -295,6 +295,7 @@
>   };
>   
>   &cp1_mdio {
> +	status = "okay";
>   	phy0: ethernet-phy@0 {
>   		reg = <0>;
>   	};
> diff --git a/arch/arm/dts/armada-8040-db.dts b/arch/arm/dts/armada-8040-db.dts
> index 51c2f23f4d..2686e00242 100644
> --- a/arch/arm/dts/armada-8040-db.dts
> +++ b/arch/arm/dts/armada-8040-db.dts
> @@ -270,6 +270,7 @@
>   };
>   
>   &cp0_mdio {
> +	status = "okay";
>   	phy1: ethernet-phy@1 {
>   		reg = <1>;
>   	};
> diff --git a/arch/arm/dts/armada-8040-mcbin.dts b/arch/arm/dts/armada-8040-mcbin.dts
> index 2184648318..b0bed77ae6 100644
> --- a/arch/arm/dts/armada-8040-mcbin.dts
> +++ b/arch/arm/dts/armada-8040-mcbin.dts
> @@ -155,6 +155,7 @@
>   };
>   
>   &cp0_mdio {
> +	status = "okay";
>   	ge_phy: ethernet-phy@0 {
>   		reg = <0>;
>   	};
> 


Viele Grüße,
Stefan
François Ozog Sept. 10, 2021, 7:25 a.m. UTC | #2 
Hi Simon,

That's typically what SystemReady want to avoid/address. The board MDIO has
always been "Okay". Linux may not have been able to deal with it.

So the right way to handle that is:
- there is a board DT "attached" to the board
- TFA adjusts the DRAM aspect (SPL, core boot...)
- OP-TEE adjust Secure DRAM aspects (Trusty, Q-SEE...)
- U-Boot adjusts to the booted OS (turn off MDIO if the booted OS does not
support it) or administrative desires. U-Boot is also in the best position
to deal with hats, capes...
- OS selects what it can handle

This way, there is a single source for DTB, no nightmare to sync up all
involved projects.



On Fri, 10 Sept 2021 at 08:56, Stefan Roese <sr@denx.de> wrote:

> On 24.08.21 10:14, sven.auhagen@voleatech.de wrote:
> > From: Sven Auhagen <Sven.Auhagen@voleatech.de>
> >
> > Since mvpp2 is using the new mdio driver and the cp110 has been
> > synced with the linux upstream, the mdio has to enabled in the
> > device tree file.
> > This is missing for some device tree files and therefore the
> > network cards do not come online.
> >
> > Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
>
> Thanks,
> Stefan
>
> > ---
> >   arch/arm/dts/armada-7040-db.dts             | 1 +
> >   arch/arm/dts/armada-8040-clearfog-gt-8k.dts | 1 +
> >   arch/arm/dts/armada-8040-db.dts             | 1 +
> >   arch/arm/dts/armada-8040-mcbin.dts          | 1 +
> >   4 files changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/dts/armada-7040-db.dts
> b/arch/arm/dts/armada-7040-db.dts
> > index b158f92349..9104042359 100644
> > --- a/arch/arm/dts/armada-7040-db.dts
> > +++ b/arch/arm/dts/armada-7040-db.dts
> > @@ -175,6 +175,7 @@
> >   };
> >
> >   &cp0_mdio {
> > +     status = "okay";
> >       phy0: ethernet-phy@0 {
> >               reg = <0>;
> >       };
> > diff --git a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> > index 6a586dbbba..79ee871c5a 100644
> > --- a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> > +++ b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
> > @@ -295,6 +295,7 @@
> >   };
> >
> >   &cp1_mdio {
> > +     status = "okay";
> >       phy0: ethernet-phy@0 {
> >               reg = <0>;
> >       };
> > diff --git a/arch/arm/dts/armada-8040-db.dts
> b/arch/arm/dts/armada-8040-db.dts
> > index 51c2f23f4d..2686e00242 100644
> > --- a/arch/arm/dts/armada-8040-db.dts
> > +++ b/arch/arm/dts/armada-8040-db.dts
> > @@ -270,6 +270,7 @@
> >   };
> >
> >   &cp0_mdio {
> > +     status = "okay";
> >       phy1: ethernet-phy@1 {
> >               reg = <1>;
> >       };
> > diff --git a/arch/arm/dts/armada-8040-mcbin.dts
> b/arch/arm/dts/armada-8040-mcbin.dts
> > index 2184648318..b0bed77ae6 100644
> > --- a/arch/arm/dts/armada-8040-mcbin.dts
> > +++ b/arch/arm/dts/armada-8040-mcbin.dts
> > @@ -155,6 +155,7 @@
> >   };
> >
> >   &cp0_mdio {
> > +     status = "okay";
> >       ge_phy: ethernet-phy@0 {
> >               reg = <0>;
> >       };
> >
>
>
> Viele Grüße,
> Stefan
>
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
>
diff mbox series

Patch

diff --git a/arch/arm/dts/armada-7040-db.dts b/arch/arm/dts/armada-7040-db.dts
index b158f92349..9104042359 100644
--- a/arch/arm/dts/armada-7040-db.dts
+++ b/arch/arm/dts/armada-7040-db.dts
@@ -175,6 +175,7 @@ 
 };
 
 &cp0_mdio {
+	status = "okay";
 	phy0: ethernet-phy@0 {
 		reg = <0>;
 	};
diff --git a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
index 6a586dbbba..79ee871c5a 100644
--- a/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
+++ b/arch/arm/dts/armada-8040-clearfog-gt-8k.dts
@@ -295,6 +295,7 @@ 
 };
 
 &cp1_mdio {
+	status = "okay";
 	phy0: ethernet-phy@0 {
 		reg = <0>;
 	};
diff --git a/arch/arm/dts/armada-8040-db.dts b/arch/arm/dts/armada-8040-db.dts
index 51c2f23f4d..2686e00242 100644
--- a/arch/arm/dts/armada-8040-db.dts
+++ b/arch/arm/dts/armada-8040-db.dts
@@ -270,6 +270,7 @@ 
 };
 
 &cp0_mdio {
+	status = "okay";
 	phy1: ethernet-phy@1 {
 		reg = <1>;
 	};
diff --git a/arch/arm/dts/armada-8040-mcbin.dts b/arch/arm/dts/armada-8040-mcbin.dts
index 2184648318..b0bed77ae6 100644
--- a/arch/arm/dts/armada-8040-mcbin.dts
+++ b/arch/arm/dts/armada-8040-mcbin.dts
@@ -155,6 +155,7 @@ 
 };
 
 &cp0_mdio {
+	status = "okay";
 	ge_phy: ethernet-phy@0 {
 		reg = <0>;
 	};