| Message ID | 20210802131838.21097-10-pali@kernel.org |
|---|---|
| State | Accepted |
| Commit | fd004950804a60ebcba8dcc0cc850d793c3aa1ea |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Reduce usage of timestamp macros | expand |
On Mon, 2 Aug 2021 at 07:19, Pali Rohár <pali@kernel.org> wrote: > > U_BOOT_DATE and U_BOOT_TIME are updated on every run of make command. > Therefore mrc.c file is recompiled every time when running make which means > that whole U-Boot binary is recompiled on every run of make command. > > Simplify it and do not recompile U-Boot binary on every run of make command > by not depending on macros U_BOOT_DATE and U_BOOT_TIME. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > arch/x86/cpu/quark/mrc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
On Mon, Aug 2, 2021 at 9:19 PM Pali Rohár <pali@kernel.org> wrote: > > U_BOOT_DATE and U_BOOT_TIME are updated on every run of make command. > Therefore mrc.c file is recompiled every time when running make which means > that whole U-Boot binary is recompiled on every run of make command. > > Simplify it and do not recompile U-Boot binary on every run of make command > by not depending on macros U_BOOT_DATE and U_BOOT_TIME. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > arch/x86/cpu/quark/mrc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Mon, Aug 02, 2021 at 03:18:36PM +0200, Pali Rohár wrote: > U_BOOT_DATE and U_BOOT_TIME are updated on every run of make command. > Therefore mrc.c file is recompiled every time when running make which means > that whole U-Boot binary is recompiled on every run of make command. > > Simplify it and do not recompile U-Boot binary on every run of make command > by not depending on macros U_BOOT_DATE and U_BOOT_TIME. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Reviewed-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot/next, thanks!
diff --git a/arch/x86/cpu/quark/mrc.c b/arch/x86/cpu/quark/mrc.c index 3e8c0bc28c5f..ce3c2b8ab426 100644 --- a/arch/x86/cpu/quark/mrc.c +++ b/arch/x86/cpu/quark/mrc.c @@ -33,7 +33,6 @@ */ #include <common.h> -#include <version.h> #include <asm/arch/mrc.h> #include <asm/arch/msg_port.h> #include "mrc_util.h" @@ -191,8 +190,7 @@ void mrc_init(struct mrc_params *mrc_params) { ENTERFN(); - DPF(D_INFO, "MRC Version %04x %s %s\n", MRC_VERSION, - U_BOOT_DATE, U_BOOT_TIME); + DPF(D_INFO, "MRC Version %04x\n", MRC_VERSION); /* Set up the data structures used by mrc_mem_init() */ mrc_adjust_params(mrc_params);
U_BOOT_DATE and U_BOOT_TIME are updated on every run of make command. Therefore mrc.c file is recompiled every time when running make which means that whole U-Boot binary is recompiled on every run of make command. Simplify it and do not recompile U-Boot binary on every run of make command by not depending on macros U_BOOT_DATE and U_BOOT_TIME. Signed-off-by: Pali Rohár <pali@kernel.org> --- arch/x86/cpu/quark/mrc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)