| Message ID | 20210629175317.2607470-5-vladimir.oltean@nxp.com |
|---|---|
| State | Accepted |
| Commit | bec7d5342d031ddfc4558aaafc1e6e63e5652917 |
| Delegated to: | Ramon Fried |
| Headers | show |
| Series | Fixes for the NXP LS1028A-QDS boards | expand |
On Tue, Jun 29, 2021 at 8:55 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > The enetc-2 port is used as DSA master (connected back-to-back to > mscc_felix_port4). Since the convention is to not enable ports in the > common SoC dtsi unless they are used on the board, then enable enetc-2 > only when mscc_felix_port4 itself is enabled. > > All existing device trees appear to adhere to this rule, so disable > enetc-2 in the SoC dtsi. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > v2->v3: none > v1->v2: none > > arch/arm/dts/fsl-ls1028a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/dts/fsl-ls1028a.dtsi b/arch/arm/dts/fsl-ls1028a.dtsi > index 21f4ef78a059..50f9b527cde1 100644 > --- a/arch/arm/dts/fsl-ls1028a.dtsi > +++ b/arch/arm/dts/fsl-ls1028a.dtsi > @@ -142,7 +142,7 @@ > }; > enetc2: pci@0,2 { > reg = <0x000200 0 0 0 0>; > - status = "okay"; > + status = "disabled"; > phy-mode = "internal"; > > fixed-link { > -- > 2.25.1 > Applied to u-boot-net/master, Thanks ! Ramon
diff --git a/arch/arm/dts/fsl-ls1028a.dtsi b/arch/arm/dts/fsl-ls1028a.dtsi index 21f4ef78a059..50f9b527cde1 100644 --- a/arch/arm/dts/fsl-ls1028a.dtsi +++ b/arch/arm/dts/fsl-ls1028a.dtsi @@ -142,7 +142,7 @@ }; enetc2: pci@0,2 { reg = <0x000200 0 0 0 0>; - status = "okay"; + status = "disabled"; phy-mode = "internal"; fixed-link {
The enetc-2 port is used as DSA master (connected back-to-back to mscc_felix_port4). Since the convention is to not enable ports in the common SoC dtsi unless they are used on the board, then enable enetc-2 only when mscc_felix_port4 itself is enabled. All existing device trees appear to adhere to this rule, so disable enetc-2 in the SoC dtsi. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- v2->v3: none v1->v2: none arch/arm/dts/fsl-ls1028a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)