diff mbox series

nvme: Remove the redundant aqa value setting

Message ID 20210616032255.76966-1-wesley.sheng@amd.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series nvme: Remove the redundant aqa value setting | expand

Commit Message

Wesley Sheng June 16, 2021, 3:22 a.m. UTC 
From: wesleywesley <wesleyshenggit@sina.com>

AQA (Admin Queue Attributes) register is a dword size with
lower word of ASQS, and higher word of ACQS.

The code set the variable aqa twice, but it is redundant.

Signed-off-by: wesleywesley <wesleyshenggit@sina.com>
---
 drivers/nvme/nvme.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bin Meng June 18, 2021, 6:01 a.m. UTC | #1 
On Wed, Jun 16, 2021 at 12:09 PM Wesley Sheng <wesley.sheng@amd.com> wrote:
>
> From: wesleywesley <wesleyshenggit@sina.com>
>
> AQA (Admin Queue Attributes) register is a dword size with
> lower word of ASQS, and higher word of ACQS.
>
> The code set the variable aqa twice, but it is redundant.
>
> Signed-off-by: wesleywesley <wesleyshenggit@sina.com>
> ---
>  drivers/nvme/nvme.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox series

Patch

diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c
index fc64d93ab8..a062234163 100644
--- a/drivers/nvme/nvme.c
+++ b/drivers/nvme/nvme.c
@@ -379,7 +379,6 @@  static int nvme_configure_admin_queue(struct nvme_dev *dev)
 
 	aqa = nvmeq->q_depth - 1;
 	aqa |= aqa << 16;
-	aqa |= aqa << 16;
 
 	dev->page_size = 1 << page_shift;