| Message ID | 20210522124757.18639-8-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | 6aa36936161c7e010aeadf1fafd8238db2efde1f |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Migrate to DM_USB and OF_CONTROL support | expand |
Since the proper U-Boot doesn't do anything at the moment, I don't think this hurts much. My usage of mx6memcal generally ends after SPL spits out calibration values, and I suspect the same is true for other users, so Acked-by: Eric Nelson <eric@nelint.com> On 5/22/21 5:47 AM, Tom Rini wrote: > As this board does not use CONFIG_OF_CONTROL and the DM_USB migration > deadline has passed, disable USB_GADGET support. > > Cc: Eric Nelson <eric@nelint.com> > Cc: Stefano Babic <sbabic@denx.de> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > I realize this removes an important functional part of the board. I > suspect the path forward here is to make a generic mx6 device tree to > use here, so that the USB functionality keeps working. > --- > configs/mx6memcal_defconfig | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/configs/mx6memcal_defconfig b/configs/mx6memcal_defconfig > index 41ff942cf1ce..a860fbe77738 100644 > --- a/configs/mx6memcal_defconfig > +++ b/configs/mx6memcal_defconfig > @@ -16,9 +16,6 @@ CONFIG_SPL=y > CONFIG_SUPPORT_RAW_INITRD=y > CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg,SPL" > CONFIG_SPL_USB_HOST_SUPPORT=y > -CONFIG_SPL_USB_GADGET=y > -CONFIG_SPL_USB_ETHER=y > -CONFIG_SPL_USB_SDP_SUPPORT=y > CONFIG_SPL_WATCHDOG_SUPPORT=y > CONFIG_HUSH_PARSER=y > # CONFIG_CMD_BOOTD is not set > @@ -45,11 +42,5 @@ CONFIG_BOUNCE_BUFFER=y > # CONFIG_MMC is not set > CONFIG_FSL_USDHC=y > CONFIG_MXC_UART=y > -CONFIG_USB=y > -CONFIG_USB_GADGET=y > -CONFIG_USB_GADGET_MANUFACTURER="FSL" > -CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > -CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > -CONFIG_CI_UDC=y > CONFIG_OF_LIBFDT=y > # CONFIG_EFI_LOADER is not set >
On Tue, May 25, 2021 at 07:10:29AM -0700, Eric Nelson wrote: > Since the proper U-Boot doesn't do anything at the moment, I don't think > this hurts much. > > My usage of mx6memcal generally ends after SPL spits out calibration > values, and I suspect the same is true for other users, so > > Acked-by: Eric Nelson <eric@nelint.com> But don't you need SPL gadget support to easily load this in?
Hi Tom, On 5/25/21 8:47 AM, Tom Rini wrote: > On Tue, May 25, 2021 at 07:10:29AM -0700, Eric Nelson wrote: > >> Since the proper U-Boot doesn't do anything at the moment, I don't think >> this hurts much. >> >> My usage of mx6memcal generally ends after SPL spits out calibration >> values, and I suspect the same is true for other users, so >> >> Acked-by: Eric Nelson <eric@nelint.com> > But don't you need SPL gadget support to easily load this in? > No. The calibration is done by the SPL running in internal RAM.
On Tue, May 25, 2021 at 09:19:30AM -0700, Eric Nelson wrote: > Hi Tom, > > On 5/25/21 8:47 AM, Tom Rini wrote: > > On Tue, May 25, 2021 at 07:10:29AM -0700, Eric Nelson wrote: > > > >> Since the proper U-Boot doesn't do anything at the moment, I don't think > >> this hurts much. > >> > >> My usage of mx6memcal generally ends after SPL spits out calibration > >> values, and I suspect the same is true for other users, so > >> > >> Acked-by: Eric Nelson <eric@nelint.com> > > But don't you need SPL gadget support to easily load this in? > > > No. The calibration is done by the SPL running in internal RAM. ... ah, yes, sorry, I'm with you now. ROM loads via gadget, SPL runs, does memcalc, displays values, then you move on to the real board. Thanks!
Hi Tom, On 5/25/21 9:45 AM, Tom Rini wrote: > On Tue, May 25, 2021 at 09:19:30AM -0700, Eric Nelson wrote: >> Hi Tom, >> >> On 5/25/21 8:47 AM, Tom Rini wrote: >>> On Tue, May 25, 2021 at 07:10:29AM -0700, Eric Nelson wrote: >>> >>>> Since the proper U-Boot doesn't do anything at the moment, I don't think >>>> this hurts much. >>>> >>>> My usage of mx6memcal generally ends after SPL spits out calibration >>>> values, and I suspect the same is true for other users, so >>>> >>>> Acked-by: Eric Nelson <eric@nelint.com> >>> But don't you need SPL gadget support to easily load this in? >>> >> No. The calibration is done by the SPL running in internal RAM. > ... ah, yes, sorry, I'm with you now. ROM loads via gadget, SPL runs, > does memcalc, displays values, then you move on to the real board. > And test under Linux, where you can exercise things with the GPU and VPU active. Testing under U-Boot doesn't tend to find calibration errors. It would be helpful to test under U-Boot by adding support for changing up the DDR frequencies (as done in the NXP test), but that's something for another day.
On Sat, May 22, 2021 at 08:47:06AM -0400, Tom Rini wrote: > As this board does not use CONFIG_OF_CONTROL and the DM_USB migration > deadline has passed, disable USB_GADGET support. > > Cc: Eric Nelson <eric@nelint.com> > Cc: Stefano Babic <sbabic@denx.de> > Signed-off-by: Tom Rini <trini@konsulko.com> > Acked-by: Eric Nelson <eric@nelint.com> Applied to u-boot/master, thanks!
diff --git a/configs/mx6memcal_defconfig b/configs/mx6memcal_defconfig index 41ff942cf1ce..a860fbe77738 100644 --- a/configs/mx6memcal_defconfig +++ b/configs/mx6memcal_defconfig @@ -16,9 +16,6 @@ CONFIG_SPL=y CONFIG_SUPPORT_RAW_INITRD=y CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/mach-imx/spl_sd.cfg,SPL" CONFIG_SPL_USB_HOST_SUPPORT=y -CONFIG_SPL_USB_GADGET=y -CONFIG_SPL_USB_ETHER=y -CONFIG_SPL_USB_SDP_SUPPORT=y CONFIG_SPL_WATCHDOG_SUPPORT=y CONFIG_HUSH_PARSER=y # CONFIG_CMD_BOOTD is not set @@ -45,11 +42,5 @@ CONFIG_BOUNCE_BUFFER=y # CONFIG_MMC is not set CONFIG_FSL_USDHC=y CONFIG_MXC_UART=y -CONFIG_USB=y -CONFIG_USB_GADGET=y -CONFIG_USB_GADGET_MANUFACTURER="FSL" -CONFIG_USB_GADGET_VENDOR_NUM=0x0525 -CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 -CONFIG_CI_UDC=y CONFIG_OF_LIBFDT=y # CONFIG_EFI_LOADER is not set
As this board does not use CONFIG_OF_CONTROL and the DM_USB migration deadline has passed, disable USB_GADGET support. Cc: Eric Nelson <eric@nelint.com> Cc: Stefano Babic <sbabic@denx.de> Signed-off-by: Tom Rini <trini@konsulko.com> --- I realize this removes an important functional part of the board. I suspect the path forward here is to make a generic mx6 device tree to use here, so that the USB functionality keeps working. --- configs/mx6memcal_defconfig | 9 --------- 1 file changed, 9 deletions(-)