| Message ID | 20210514210620.24715-1-oleg@kaa.org.ua |
|---|---|
| State | Accepted |
| Commit | 389b6765366ae95f59b0218a1f933aaa2a2b811f |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v2] Fix flash and erase of eMMC Boot2 with Fastboot | expand |
Hello guys, Could you please review and merge this patch? PR successfully passed CI: https://github.com/u-boot/u-boot/pull/76 15.05.21 00:06, Oleh Kravchenko пише: > The current U-Boot version has the next matches for boot partitions: >> mmc0boot0 to EMMC_BOOT1 >> mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2) > This patch fixes a typo for the boot partition number. > > Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > Cc: Marek Vasut <marex@denx.de> > --- > Changes for v2: > - updated commit message > - CI https://github.com/u-boot/u-boot/pull/76 > > drivers/fastboot/fb_mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c > index 2f3837e559..2326067882 100644 > --- a/drivers/fastboot/fb_mmc.c > +++ b/drivers/fastboot/fb_mmc.c > @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer, > if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) { > dev_desc = fastboot_mmc_get_dev(response); > if (dev_desc) > - fb_mmc_boot_ops(dev_desc, download_buffer, 1, > + fb_mmc_boot_ops(dev_desc, download_buffer, 2, > download_bytes, response); > return; > } > @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response) > /* erase EMMC boot2 */ > dev_desc = fastboot_mmc_get_dev(response); > if (dev_desc) > - fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response); > + fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response); > return; > } > #endif >
On 5/14/21 5:06 PM, Oleh Kravchenko wrote: > The current U-Boot version has the next matches for boot partitions: >> mmc0boot0 to EMMC_BOOT1 >> mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2) > This patch fixes a typo for the boot partition number. > > Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > Cc: Marek Vasut <marex@denx.de> > --- > Changes for v2: > - updated commit message > - CI https://github.com/u-boot/u-boot/pull/76 > > drivers/fastboot/fb_mmc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c > index 2f3837e559..2326067882 100644 > --- a/drivers/fastboot/fb_mmc.c > +++ b/drivers/fastboot/fb_mmc.c > @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer, > if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) { > dev_desc = fastboot_mmc_get_dev(response); > if (dev_desc) > - fb_mmc_boot_ops(dev_desc, download_buffer, 1, > + fb_mmc_boot_ops(dev_desc, download_buffer, 2, > download_bytes, response); > return; > } > @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response) > /* erase EMMC boot2 */ > dev_desc = fastboot_mmc_get_dev(response); > if (dev_desc) > - fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response); > + fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response); > return; > } > #endif > Reviewed-by: Sean Anderson <sean.anderson@seco.com>
Hello Lukasz, Could you please review this patch? This patch fixes small typos for Fastboot mmc boot2 partition. 20.05.21 17:59, Sean Anderson пише: > > > On 5/14/21 5:06 PM, Oleh Kravchenko wrote: >> The current U-Boot version has the next matches for boot partitions: >>> mmc0boot0 to EMMC_BOOT1 >>> mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2) >> This patch fixes a typo for the boot partition number. >> >> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua> >> Cc: Pantelis Antoniou <panto@antoniou-consulting.com> >> Cc: Marek Vasut <marex@denx.de> >> --- >> Changes for v2: >> - updated commit message >> - CI https://github.com/u-boot/u-boot/pull/76 >> >> drivers/fastboot/fb_mmc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c >> index 2f3837e559..2326067882 100644 >> --- a/drivers/fastboot/fb_mmc.c >> +++ b/drivers/fastboot/fb_mmc.c >> @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer, >> if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) { >> dev_desc = fastboot_mmc_get_dev(response); >> if (dev_desc) >> - fb_mmc_boot_ops(dev_desc, download_buffer, 1, >> + fb_mmc_boot_ops(dev_desc, download_buffer, 2, >> download_bytes, response); >> return; >> } >> @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response) >> /* erase EMMC boot2 */ >> dev_desc = fastboot_mmc_get_dev(response); >> if (dev_desc) >> - fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response); >> + fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response); >> return; >> } >> #endif >> > > Reviewed-by: Sean Anderson <sean.anderson@seco.com>
On Sat, May 15, 2021 at 12:06:21AM +0300, Oleh Kravchenko wrote: > The current U-Boot version has the next matches for boot partitions: > > mmc0boot0 to EMMC_BOOT1 > > mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2) > This patch fixes a typo for the boot partition number. > > Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua> > Cc: Pantelis Antoniou <panto@antoniou-consulting.com> > Cc: Marek Vasut <marex@denx.de> > Reviewed-by: Sean Anderson <sean.anderson@seco.com> Applied to u-boot/master, thanks!
diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c index 2f3837e559..2326067882 100644 --- a/drivers/fastboot/fb_mmc.c +++ b/drivers/fastboot/fb_mmc.c @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer, if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) { dev_desc = fastboot_mmc_get_dev(response); if (dev_desc) - fb_mmc_boot_ops(dev_desc, download_buffer, 1, + fb_mmc_boot_ops(dev_desc, download_buffer, 2, download_bytes, response); return; } @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response) /* erase EMMC boot2 */ dev_desc = fastboot_mmc_get_dev(response); if (dev_desc) - fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response); + fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response); return; } #endif