| Message ID | 20210427152713.v1.8.I90a9ae45ab51c6f846de0ed1499bf60ddafebb83@changeid |
|---|---|
| State | Changes Requested |
| Delegated to: | Ramon Fried |
| Headers | show |
| Series | net: mvpp2: Sync Marvell mvpp2 driver with Marvell version | expand |
On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese <sr@denx.de> wrote: > > From: Ben Peled <bpeled@marvell.com> > > Signed-off-by: Ben Peled <bpeled@marvell.com> > Reviewed-by: Stefan Chulski <stefanc@marvell.com> > Reviewed-by: Kostya Porotchkin <kostap@marvell.com> > Tested-by: sa_ip-sw-jenkins <sa_ip-sw-jenkins@marvell.com> Please remove this, Jenkins is not a person. > Signed-off-by: Stefan Roese <sr@denx.de> > --- > > drivers/net/mvpp2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c > index 61a0ea0894a7..3d920e85ffef 100644 > --- a/drivers/net/mvpp2.c > +++ b/drivers/net/mvpp2.c > @@ -3247,9 +3247,11 @@ static int gop_gmac_mode_cfg(struct mvpp2_port *port) > > case PHY_INTERFACE_MODE_1000BASEX: > gop_gmac_1000basex_cfg(port); > + break; > > case PHY_INTERFACE_MODE_2500BASEX: > gop_gmac_2500basex_cfg(port); > + break; > > case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > -- > 2.31.1 >
On 29.04.21 22:24, Ramon Fried wrote: > On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese <sr@denx.de> wrote: >> >> From: Ben Peled <bpeled@marvell.com> >> >> Signed-off-by: Ben Peled <bpeled@marvell.com> >> Reviewed-by: Stefan Chulski <stefanc@marvell.com> >> Reviewed-by: Kostya Porotchkin <kostap@marvell.com> >> Tested-by: sa_ip-sw-jenkins <sa_ip-sw-jenkins@marvell.com> > Please remove this, Jenkins is not a person. I've left these lines in because most of these patches are plain cherry-picked from the Marvell SDK. Should I resubmit this patch only or the complete patchset? Or could you perhaps remove this line while collecting the patches for a pull request? Thanks, Stefan >> Signed-off-by: Stefan Roese <sr@denx.de> >> --- >> >> drivers/net/mvpp2.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c >> index 61a0ea0894a7..3d920e85ffef 100644 >> --- a/drivers/net/mvpp2.c >> +++ b/drivers/net/mvpp2.c >> @@ -3247,9 +3247,11 @@ static int gop_gmac_mode_cfg(struct mvpp2_port *port) >> >> case PHY_INTERFACE_MODE_1000BASEX: >> gop_gmac_1000basex_cfg(port); >> + break; >> >> case PHY_INTERFACE_MODE_2500BASEX: >> gop_gmac_2500basex_cfg(port); >> + break; >> >> case PHY_INTERFACE_MODE_RGMII: >> case PHY_INTERFACE_MODE_RGMII_ID: >> -- >> 2.31.1 >> Viele Grüße, Stefan
On Fri, Apr 30, 2021 at 7:40 AM Stefan Roese <sr@denx.de> wrote: > > On 29.04.21 22:24, Ramon Fried wrote: > > On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese <sr@denx.de> wrote: > >> > >> From: Ben Peled <bpeled@marvell.com> > >> > >> Signed-off-by: Ben Peled <bpeled@marvell.com> > >> Reviewed-by: Stefan Chulski <stefanc@marvell.com> > >> Reviewed-by: Kostya Porotchkin <kostap@marvell.com> > >> Tested-by: sa_ip-sw-jenkins <sa_ip-sw-jenkins@marvell.com> > > Please remove this, Jenkins is not a person. > > I've left these lines in because most of these patches are plain > cherry-picked from the Marvell SDK. > > Should I resubmit this patch only or the complete patchset? Or could you > perhaps remove this line while collecting the patches for a pull > request? Please submit the patchset again.
Hi Ramon, On 30.04.21 16:18, Ramon Fried wrote: > On Fri, Apr 30, 2021 at 7:40 AM Stefan Roese <sr@denx.de> wrote: >> >> On 29.04.21 22:24, Ramon Fried wrote: >>> On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese <sr@denx.de> wrote: >>>> >>>> From: Ben Peled <bpeled@marvell.com> >>>> >>>> Signed-off-by: Ben Peled <bpeled@marvell.com> >>>> Reviewed-by: Stefan Chulski <stefanc@marvell.com> >>>> Reviewed-by: Kostya Porotchkin <kostap@marvell.com> >>>> Tested-by: sa_ip-sw-jenkins <sa_ip-sw-jenkins@marvell.com> >>> Please remove this, Jenkins is not a person. >> >> I've left these lines in because most of these patches are plain >> cherry-picked from the Marvell SDK. >> >> Should I resubmit this patch only or the complete patchset? Or could you >> perhaps remove this line while collecting the patches for a pull >> request? > Please submit the patchset again. Done. I just now noticed, that I forgot to add your RB tags. Should I send v3 with the RB tags? Thanks, Stefan
On Mon, May 3, 2021 at 9:13 AM Stefan Roese <sr@denx.de> wrote: > > Hi Ramon, > > On 30.04.21 16:18, Ramon Fried wrote: > > On Fri, Apr 30, 2021 at 7:40 AM Stefan Roese <sr@denx.de> wrote: > >> > >> On 29.04.21 22:24, Ramon Fried wrote: > >>> On Tue, Apr 27, 2021 at 4:28 PM Stefan Roese <sr@denx.de> wrote: > >>>> > >>>> From: Ben Peled <bpeled@marvell.com> > >>>> > >>>> Signed-off-by: Ben Peled <bpeled@marvell.com> > >>>> Reviewed-by: Stefan Chulski <stefanc@marvell.com> > >>>> Reviewed-by: Kostya Porotchkin <kostap@marvell.com> > >>>> Tested-by: sa_ip-sw-jenkins <sa_ip-sw-jenkins@marvell.com> > >>> Please remove this, Jenkins is not a person. > >> > >> I've left these lines in because most of these patches are plain > >> cherry-picked from the Marvell SDK. > >> > >> Should I resubmit this patch only or the complete patchset? Or could you > >> perhaps remove this line while collecting the patches for a pull > >> request? > > Please submit the patchset again. > > Done. I just now noticed, that I forgot to add your RB tags. Should I > send v3 with the RB tags? No, that's fine.
diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c index 61a0ea0894a7..3d920e85ffef 100644 --- a/drivers/net/mvpp2.c +++ b/drivers/net/mvpp2.c @@ -3247,9 +3247,11 @@ static int gop_gmac_mode_cfg(struct mvpp2_port *port) case PHY_INTERFACE_MODE_1000BASEX: gop_gmac_1000basex_cfg(port); + break; case PHY_INTERFACE_MODE_2500BASEX: gop_gmac_2500basex_cfg(port); + break; case PHY_INTERFACE_MODE_RGMII: case PHY_INTERFACE_MODE_RGMII_ID: