| Message ID | 20210402180552.1075997-5-pbrobinson@gmail.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [1/5] ARM: board: warp: Import dts files | expand |
> We don't need a random MAC as the only network that's supported is > over USB and that has a hardcoded MAC, enable DM_ETH for the USB, > and the device doesn't have MTD storage so drop that. > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
Hi Peter, series was lost, sorry. I have picked them up and rebased on current master. Anyway, build fails (warning) due to +board/warp7/warp7.c: In function 'board_eth_init': +board/warp7/warp7.c:94:15: error: implicit declaration of function 'usb_eth_initialize'; did you mean 'sh_eth_initialize'? [-Werror=implicit-function-declaration] + 94 | ret = usb_eth_initialize(bis); + | ^~~~~~~~~~~~~~~~~~ But as board already switched to CONFIG_DM_USB and CONFIG_DM_ETH, do we still need to call this function ? Best regards, Stefano On 02.04.21 20:05, Peter Robinson wrote: > We don't need a random MAC as the only network that's supported is > over USB and that has a hardcoded MAC, enable DM_ETH for the USB, > and the device doesn't have MTD storage so drop that. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Stefano Babic <sbabic@denx.de> > --- > configs/warp7_bl33_defconfig | 3 +-- > configs/warp7_defconfig | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/configs/warp7_bl33_defconfig b/configs/warp7_bl33_defconfig > index 4b45fcd50a..98d370754a 100644 > --- a/configs/warp7_bl33_defconfig > +++ b/configs/warp7_bl33_defconfig > @@ -32,14 +32,13 @@ CONFIG_CMD_FS_GENERIC=y > CONFIG_OF_CONTROL=y > CONFIG_ENV_OVERWRITE=y > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > -CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_BOUNCE_BUFFER=y > CONFIG_DFU_MMC=y > +CONFIG_DM_ETH=y > CONFIG_DM_I2C=y > CONFIG_DM_MMC=y > CONFIG_SUPPORT_EMMC_BOOT=y > CONFIG_FSL_USDHC=y > -CONFIG_MTD=y > CONFIG_PINCTRL=y > CONFIG_PINCTRL_IMX7=y > CONFIG_DM_PMIC=y > diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig > index 3d11196080..8fa1981207 100644 > --- a/configs/warp7_defconfig > +++ b/configs/warp7_defconfig > @@ -38,14 +38,13 @@ CONFIG_CMD_FS_GENERIC=y > CONFIG_OF_CONTROL=y > CONFIG_ENV_OVERWRITE=y > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > -CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_BOUNCE_BUFFER=y > CONFIG_DFU_MMC=y > +CONFIG_DM_ETH=y > CONFIG_DM_I2C=y > CONFIG_DM_MMC=y > CONFIG_SUPPORT_EMMC_BOOT=y > CONFIG_FSL_USDHC=y > -CONFIG_MTD=y > CONFIG_PINCTRL=y > CONFIG_PINCTRL_IMX7=y > CONFIG_DM_PMIC=y >
diff --git a/configs/warp7_bl33_defconfig b/configs/warp7_bl33_defconfig index 4b45fcd50a..98d370754a 100644 --- a/configs/warp7_bl33_defconfig +++ b/configs/warp7_bl33_defconfig @@ -32,14 +32,13 @@ CONFIG_CMD_FS_GENERIC=y CONFIG_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y -CONFIG_NET_RANDOM_ETHADDR=y CONFIG_BOUNCE_BUFFER=y CONFIG_DFU_MMC=y +CONFIG_DM_ETH=y CONFIG_DM_I2C=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_FSL_USDHC=y -CONFIG_MTD=y CONFIG_PINCTRL=y CONFIG_PINCTRL_IMX7=y CONFIG_DM_PMIC=y diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig index 3d11196080..8fa1981207 100644 --- a/configs/warp7_defconfig +++ b/configs/warp7_defconfig @@ -38,14 +38,13 @@ CONFIG_CMD_FS_GENERIC=y CONFIG_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y -CONFIG_NET_RANDOM_ETHADDR=y CONFIG_BOUNCE_BUFFER=y CONFIG_DFU_MMC=y +CONFIG_DM_ETH=y CONFIG_DM_I2C=y CONFIG_DM_MMC=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_FSL_USDHC=y -CONFIG_MTD=y CONFIG_PINCTRL=y CONFIG_PINCTRL_IMX7=y CONFIG_DM_PMIC=y
We don't need a random MAC as the only network that's supported is over USB and that has a hardcoded MAC, enable DM_ETH for the USB, and the device doesn't have MTD storage so drop that. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Stefano Babic <sbabic@denx.de> --- configs/warp7_bl33_defconfig | 3 +-- configs/warp7_defconfig | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)