diff mbox series

dt-bindings: fsp: Fix Apollo Lake FSP-S devicetree bindings

Message ID 20210323085458.30511-1-wolfgang.wallner@br-automation.com
State Accepted
Commit da35d7af335a5be3ae5033a44f0e8b536c38dce7
Delegated to: Bin Meng
Headers show
Series dt-bindings: fsp: Fix Apollo Lake FSP-S devicetree bindings | expand

Commit Message

Wolfgang Wallner March 23, 2021, 8:54 a.m. UTC
An entry is missing in the FSP-S devicetree bindings, and as a result
the description for the next few following entries is off by one line.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>

---

 .../fsp/fsp2/apollolake/fsp-s.txt             | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Simon Glass March 24, 2021, 7:09 a.m. UTC | #1
On Tue, 23 Mar 2021 at 21:55, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> An entry is missing in the FSP-S devicetree bindings, and as a result
> the description for the next few following entries is off by one line.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
>  .../fsp/fsp2/apollolake/fsp-s.txt             | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Bin Meng April 8, 2021, 1:56 a.m. UTC | #2
On Tue, Mar 23, 2021 at 4:55 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> An entry is missing in the FSP-S devicetree bindings, and as a result
> the description for the next few following entries is off by one line.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
>  .../fsp/fsp2/apollolake/fsp-s.txt             | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng April 8, 2021, 1:59 a.m. UTC | #3
On Thu, Apr 8, 2021 at 9:56 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Tue, Mar 23, 2021 at 4:55 PM Wolfgang Wallner
> <wolfgang.wallner@br-automation.com> wrote:
> >
> > An entry is missing in the FSP-S devicetree bindings, and as a result
> > the description for the next few following entries is off by one line.
> >
> > Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> >
> > ---
> >
> >  .../fsp/fsp2/apollolake/fsp-s.txt             | 19 ++++++++++---------
> >  1 file changed, 10 insertions(+), 9 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-s.txt b/doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-s.txt
index b605ed0056..dc8e3251a3 100644
--- a/doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-s.txt
+++ b/doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-s.txt
@@ -258,19 +258,20 @@  Optional properties:
 - fsps,pcie-rp-clk-req-detect: CLKREQ# Detection
 - fsps,advanced-error-reportingt: Advanced Error Reporting
 - fsps,pme-interrupt: PME Interrupt
-- fsps,fatal-error-report: URR
-- fsps,no-fatal-error-report: FER
-- fsps,correctable-error-report: NFER
-- fsps,system-error-on-fatal-error: CER
-- fsps,system-error-on-non-fatal-error: SEFE
-- fsps,system-error-on-correctable-error: SENFE
-- fsps,pcie-rp-speed: SECE
-- fsps,physical-slot-number: PCIe Speed
+- fsps,unsupported-request-report: URR
+- fsps,fatal-error-report: FER
+- fsps,no-fatal-error-report: NFER
+- fsps,correctable-error-report: CER
+- fsps,system-error-on-fatal-error: SEFE
+- fsps,system-error-on-non-fatal-error: SENFE
+- fsps,system-error-on-correctable-error: SECE
+- fsps,pcie-rp-speed: PCIe Speed
+- fsps,physical-slot-number: Physical Slot Number
   0: Auto (default)
   1: Gen1
   2: Gen2
   3: Gen3
-- fsps,pcie-rp-completion-timeout: Physical Slot Number
+- fsps,pcie-rp-completion-timeout: CTO
   0x00, 0x01, 0x02, 0x03, 0x04, 0x05 (default)
 - fsps,enable-ptm: PTM Support
 - fsps,pcie-rp-aspm: ASPM