diff mbox series

ahci: mediatek: fix undefined reference of dev_err

Message ID 20210316180533.184794-1-linux@fw-web.de
State Accepted
Commit 93cac85d78d9f105ff2e4651c558607acef93b64
Delegated to: Tom Rini
Headers show
Series ahci: mediatek: fix undefined reference of dev_err | expand

Commit Message

Frank Wunderlich March 16, 2021, 6:05 p.m. UTC 
From: Frank Wunderlich <frank-w@public-files.de>

building with MTK_AHCI enabled results in implicit declaration and
undefined reference of dev_err followed by a segfault of gcc

drivers/ata/mtk_ahci.c: In function 'mtk_ahci_parse_property':
drivers/ata/mtk_ahci.c:65:4: warning:
implicit declaration of function 'dev_err'
drivers/ata/mtk_ahci.c:65: undefined reference to `dev_err'
in function `mtk_ahci_probe':
drivers/ata/mtk_ahci.c:92: undefined reference to `dev_err'
Segmentation fault

fix this by adding the dm/device_compat.h to includes

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 drivers/ata/mtk_ahci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini March 19, 2021, 8:42 p.m. UTC | #1 
On Tue, Mar 16, 2021 at 07:05:33PM +0100, Frank Wunderlich wrote:

> From: Frank Wunderlich <frank-w@public-files.de>
> 
> building with MTK_AHCI enabled results in implicit declaration and
> undefined reference of dev_err followed by a segfault of gcc
> 
> drivers/ata/mtk_ahci.c: In function 'mtk_ahci_parse_property':
> drivers/ata/mtk_ahci.c:65:4: warning:
> implicit declaration of function 'dev_err'
> drivers/ata/mtk_ahci.c:65: undefined reference to `dev_err'
> in function `mtk_ahci_probe':
> drivers/ata/mtk_ahci.c:92: undefined reference to `dev_err'
> Segmentation fault
> 
> fix this by adding the dm/device_compat.h to includes
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/ata/mtk_ahci.c b/drivers/ata/mtk_ahci.c
index 554175bc0051..2c5227df306b 100644
--- a/drivers/ata/mtk_ahci.c
+++ b/drivers/ata/mtk_ahci.c
@@ -21,6 +21,7 @@ 
 #include <sata.h>
 #include <scsi.h>
 #include <syscon.h>
+#include <dm/device_compat.h>
 
 #define SYS_CFG			0x14
 #define SYS_CFG_SATA_MSK	GENMASK(31, 30)