| Message ID | 20201123080842.2063-1-pragnesh.patel@sifive.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | cmd: Add a pwm command | expand |
On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > Add the command "pwm" for controlling the pwm channels. This > command provides pwm invert/config/enable/disable functionalities > via PWM uclass drivers > > Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com> > --- > cmd/Kconfig | 6 +++ > cmd/Makefile | 1 + > cmd/pwm.c | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 126 insertions(+) > create mode 100644 cmd/pwm.c Can you please add some tests and dt fragments to sandbox for this? Thanks.
>-----Original Message----- >From: Tom Rini <trini@konsulko.com> >Sent: 23 November 2020 21:22 >To: Pragnesh Patel <pragnesh.patel@openfive.com> >Cc: u-boot@lists.denx.de; atish.patra@wdc.com; palmerdabbelt@google.com; >bmeng.cn@gmail.com; Paul Walmsley ( Sifive) <paul.walmsley@sifive.com>; >anup.patel@wdc.com; Sagar Kadam <sagar.kadam@openfive.com>; >rick@andestech.com; Simon Glass <sjg@chromium.org>; Heinrich Schuchardt ><xypron.glpk@gmx.de>; Bin Meng <bin.meng@windriver.com>; Miquel Raynal ><miquel.raynal@bootlin.com>; Patrick Delaunay <patrick.delaunay@st.com>; >Sam Protsenko <joe.skb7@gmail.com>; Philippe Reynes ><philippe.reynes@softathome.com>; Frédéric Danis ><frederic.danis@collabora.com>; Patrice Chotard <patrice.chotard@st.com>; >Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Ramon Fried ><rfried.dev@gmail.com>; Eugeniu Rosca <roscaeugeniu@gmail.com> >Subject: Re: [PATCH] cmd: Add a pwm command > >On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > >> Add the command "pwm" for controlling the pwm channels. This command >> provides pwm invert/config/enable/disable functionalities via PWM >> uclass drivers >> >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com> >> --- >> cmd/Kconfig | 6 +++ >> cmd/Makefile | 1 + >> cmd/pwm.c | 119 >+++++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 126 insertions(+) >> create mode 100644 cmd/pwm.c > >Can you please add some tests and dt fragments to sandbox for this? There is already a "test/dm/pwm.c". >Thanks. > >-- >Tom
On Tue, Nov 24, 2020 at 12:41:34PM +0000, Pragnesh Patel wrote: > > > >-----Original Message----- > >From: Tom Rini <trini@konsulko.com> > >Sent: 23 November 2020 21:22 > >To: Pragnesh Patel <pragnesh.patel@openfive.com> > >Cc: u-boot@lists.denx.de; atish.patra@wdc.com; palmerdabbelt@google.com; > >bmeng.cn@gmail.com; Paul Walmsley ( Sifive) <paul.walmsley@sifive.com>; > >anup.patel@wdc.com; Sagar Kadam <sagar.kadam@openfive.com>; > >rick@andestech.com; Simon Glass <sjg@chromium.org>; Heinrich Schuchardt > ><xypron.glpk@gmx.de>; Bin Meng <bin.meng@windriver.com>; Miquel Raynal > ><miquel.raynal@bootlin.com>; Patrick Delaunay <patrick.delaunay@st.com>; > >Sam Protsenko <joe.skb7@gmail.com>; Philippe Reynes > ><philippe.reynes@softathome.com>; Frédéric Danis > ><frederic.danis@collabora.com>; Patrice Chotard <patrice.chotard@st.com>; > >Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Ramon Fried > ><rfried.dev@gmail.com>; Eugeniu Rosca <roscaeugeniu@gmail.com> > >Subject: Re: [PATCH] cmd: Add a pwm command > > > >On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > > > >> Add the command "pwm" for controlling the pwm channels. This command > >> provides pwm invert/config/enable/disable functionalities via PWM > >> uclass drivers > >> > >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com> > >> --- > >> cmd/Kconfig | 6 +++ > >> cmd/Makefile | 1 + > >> cmd/pwm.c | 119 > >+++++++++++++++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 126 insertions(+) > >> create mode 100644 cmd/pwm.c > > > >Can you please add some tests and dt fragments to sandbox for this? > > There is already a "test/dm/pwm.c". Right, but for the new command as well please, similar to test/py/tests/test_gpio.py.
Hi, On Tue, 24 Nov 2020 at 06:23, Tom Rini <trini@konsulko.com> wrote: > > On Tue, Nov 24, 2020 at 12:41:34PM +0000, Pragnesh Patel wrote: > > > > > > >-----Original Message----- > > >From: Tom Rini <trini@konsulko.com> > > >Sent: 23 November 2020 21:22 > > >To: Pragnesh Patel <pragnesh.patel@openfive.com> > > >Cc: u-boot@lists.denx.de; atish.patra@wdc.com; palmerdabbelt@google.com; > > >bmeng.cn@gmail.com; Paul Walmsley ( Sifive) <paul.walmsley@sifive.com>; > > >anup.patel@wdc.com; Sagar Kadam <sagar.kadam@openfive.com>; > > >rick@andestech.com; Simon Glass <sjg@chromium.org>; Heinrich Schuchardt > > ><xypron.glpk@gmx.de>; Bin Meng <bin.meng@windriver.com>; Miquel Raynal > > ><miquel.raynal@bootlin.com>; Patrick Delaunay <patrick.delaunay@st.com>; > > >Sam Protsenko <joe.skb7@gmail.com>; Philippe Reynes > > ><philippe.reynes@softathome.com>; Frédéric Danis > > ><frederic.danis@collabora.com>; Patrice Chotard <patrice.chotard@st.com>; > > >Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Ramon Fried > > ><rfried.dev@gmail.com>; Eugeniu Rosca <roscaeugeniu@gmail.com> > > >Subject: Re: [PATCH] cmd: Add a pwm command > > > > > >On Mon, Nov 23, 2020 at 01:38:41PM +0530, Pragnesh Patel wrote: > > > > > >> Add the command "pwm" for controlling the pwm channels. This command > > >> provides pwm invert/config/enable/disable functionalities via PWM > > >> uclass drivers > > >> > > >> Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com> > > >> --- > > >> cmd/Kconfig | 6 +++ > > >> cmd/Makefile | 1 + > > >> cmd/pwm.c | 119 > > >+++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> 3 files changed, 126 insertions(+) > > >> create mode 100644 cmd/pwm.c > > > > > >Can you please add some tests and dt fragments to sandbox for this? > > > > There is already a "test/dm/pwm.c". > > Right, but for the new command as well please, similar to > test/py/tests/test_gpio.py. I would be happier with a C test like [1] as it is faster and allows debugging, etc. Regards, Simon [1] test/cmd/mem_search.c
diff --git a/cmd/Kconfig b/cmd/Kconfig index 1595de999b..4f3a70b1d5 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -918,6 +918,12 @@ config CMD_GPIO help GPIO support. +config CMD_PWM + bool "pwm" + depends on DM_PWM + help + PWM support. + config CMD_GPT bool "GPT (GUID Partition Table) command" select EFI_PARTITION diff --git a/cmd/Makefile b/cmd/Makefile index dd86675bf2..75df3c136c 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -120,6 +120,7 @@ endif obj-$(CONFIG_CMD_PINMUX) += pinmux.o obj-$(CONFIG_CMD_PMC) += pmc.o obj-$(CONFIG_CMD_PSTORE) += pstore.o +obj-$(CONFIG_CMD_PWM) += pwm.o obj-$(CONFIG_CMD_PXE) += pxe.o pxe_utils.o obj-$(CONFIG_CMD_WOL) += wol.o obj-$(CONFIG_CMD_QFW) += qfw.o diff --git a/cmd/pwm.c b/cmd/pwm.c new file mode 100644 index 0000000000..f82f7789cd --- /dev/null +++ b/cmd/pwm.c @@ -0,0 +1,119 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Control PWM channels + * + * Copyright (c) 2020 SiFive, Inc + * author: Pragnesh Patel <pragnesh.patel@sifive.com> + */ + +#include <command.h> +#include <dm.h> +#include <pwm.h> + +enum pwm_cmd { + PWM_SET_INVERT, + PWM_SET_CONFIG, + PWM_SET_ENABLE, + PWM_SET_DISABLE, +}; + +static int do_pwm(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ + const char *str_cmd, *str_channel = NULL, *str_enable = NULL; + const char *str_pwm = NULL, *str_period = NULL, *str_duty = NULL; + enum pwm_cmd sub_cmd; + struct udevice *dev; + u32 channel, pwm_enable, period_ns = 0, duty_ns = 0; + int ret; + + if (argc < 4) + show_usage: + return CMD_RET_USAGE; + + str_cmd = argv[1]; + argc -= 2; + argv += 2; + + if (argc > 0) { + str_pwm = *argv; + argc--; + argv++; + } + + if (!str_pwm) + goto show_usage; + + switch (*str_cmd) { + case 'i': + sub_cmd = PWM_SET_INVERT; + break; + case 'c': + sub_cmd = PWM_SET_CONFIG; + break; + case 'e': + sub_cmd = PWM_SET_ENABLE; + break; + case 'd': + sub_cmd = PWM_SET_DISABLE; + break; + default: + goto show_usage; + } + + if (IS_ENABLED(CONFIG_DM_PWM)) { + ret = uclass_get_device_by_name(UCLASS_PWM, str_pwm, &dev); + if (ret) { + printf("PWM: '%s' not found\n", str_pwm); + return cmd_process_error(cmdtp, ret); + } + } + + if (argc > 0) { + str_channel = *argv; + channel = simple_strtoul(str_channel, NULL, 10); + argc--; + argv++; + } else { + goto show_usage; + } + + if (sub_cmd == PWM_SET_INVERT && argc > 0) { + str_enable = *argv; + pwm_enable = simple_strtoul(str_enable, NULL, 10); + ret = pwm_set_invert(dev, channel, pwm_enable); + } else if (sub_cmd == PWM_SET_CONFIG && argc == 2) { + str_period = *argv; + argc--; + argv++; + period_ns = simple_strtoul(str_period, NULL, 10); + + if (argc > 0) { + str_duty = *argv; + duty_ns = simple_strtoul(str_duty, NULL, 10); + } + + ret = pwm_set_config(dev, channel, period_ns, duty_ns); + } else if (sub_cmd == PWM_SET_ENABLE) { + ret = pwm_set_enable(dev, channel, 1); + } else if (sub_cmd == PWM_SET_DISABLE) { + ret = pwm_set_enable(dev, channel, 0); + } else { + printf("PWM arguments missing\n"); + return CMD_RET_FAILURE; + } + + if (ret) { + printf("error!\n"); + return CMD_RET_FAILURE; + } + + printf("success!\n"); + return CMD_RET_SUCCESS; +} + +U_BOOT_CMD(pwm, 6, 0, do_pwm, + "control pwm channels", + "pwm <invert> <pwm_device> <channel> <polarity>\n" + "pwm <config> <pwm_device> <channel> <period_ns> <duty_ns>\n" + "pwm <enable/disable> <pwm_device> <channel>");
Add the command "pwm" for controlling the pwm channels. This command provides pwm invert/config/enable/disable functionalities via PWM uclass drivers Signed-off-by: Pragnesh Patel <pragnesh.patel@sifive.com> --- cmd/Kconfig | 6 +++ cmd/Makefile | 1 + cmd/pwm.c | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 126 insertions(+) create mode 100644 cmd/pwm.c