| Message ID | 20200807063901.24842-1-joyce.ooi@intel.com |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [v2] configs: socfpga: add kernel parameter for immediate reboot | expand |
> -----Original Message----- > From: Ooi, Joyce <joyce.ooi@intel.com> > Sent: Friday, August 7, 2020 2:39 PM > To: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Tan, Ley Foon > <ley.foon.tan@intel.com>; Miquel Raynal <miquel.raynal@bootlin.com>; > Boris Brezillon <bbrezillon@kernel.org>; Marek Vasut <marex@denx.de>; > Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>; Hannes Schmelzer > <hannes.schmelzer@br-automation.com> > Cc: u-boot@lists.denx.de; Ooi, Joyce <joyce.ooi@intel.com>; Lim, Elly Siew > Chin <elly.siew.chin.lim@intel.com>; See, Chin Liang > <chin.liang.see@intel.com>; Nguyen, Dinh <dinh.nguyen@intel.com> > Subject: [PATCH v2] configs: socfpga: add kernel parameter for immediate > reboot > > From: Joyce Ooi <joyce.ooi@intel.com> > > Add Linux kernel line parameters for socfpga soc64 U-Boot. The "panic=-1" > indicates the reset should occur immediately (without a delay). > > Signed-off-by: Joyce Ooi <joyce.ooi@intel.com> > --- > v2: fix typo in commit message > --- > include/configs/socfpga_soc64_common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/configs/socfpga_soc64_common.h > b/include/configs/socfpga_soc64_common.h > index 7237ec95e34..d51a532a929 100644 > --- a/include/configs/socfpga_soc64_common.h > +++ b/include/configs/socfpga_soc64_common.h > @@ -79,7 +79,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void); > * CONFIG_BOOTARGS goes into the environment value "bootargs". > * Do note the value will override also the chosen node in FDT blob. > */ > -#define CONFIG_BOOTARGS "earlycon" > +#define CONFIG_BOOTARGS "earlycon panic=-1" > #define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run > linux_qspi_enable;" \ > "run mmcboot" Hi Joyce Just noticed CONFIG_BOOTARGS is supported in Kconfig now. Can you move this #define to Stratix10 and Agilex *_defconfig? Regards Ley Foon
Tan, Ley Foon <ley.foon.tan@intel.com> schrieb am Fr., 7. Aug. 2020, 09:25: > > > Ooi, Joyce wrote: > > From: Joyce Ooi <joyce.ooi@intel.com> > > > > Add Linux kernel line parameters for socfpga soc64 U-Boot. The "panic=-1" > > indicates the reset should occur immediately (without a delay). > > > > Signed-off-by: Joyce Ooi <joyce.ooi@intel.com> > > --- > > v2: fix typo in commit message > > --- > > include/configs/socfpga_soc64_common.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/configs/socfpga_soc64_common.h > > b/include/configs/socfpga_soc64_common.h > > index 7237ec95e34..d51a532a929 100644 > > --- a/include/configs/socfpga_soc64_common.h > > +++ b/include/configs/socfpga_soc64_common.h > > @@ -79,7 +79,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void); > > * CONFIG_BOOTARGS goes into the environment value "bootargs". > > * Do note the value will override also the chosen node in FDT blob. > > */ > > -#define CONFIG_BOOTARGS "earlycon" > > +#define CONFIG_BOOTARGS "earlycon panic=-1" > > #define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run > > linux_qspi_enable;" \ > > "run mmcboot" > Hi Joyce > > Just noticed CONFIG_BOOTARGS is supported in Kconfig now. > Can you move this #define to Stratix10 and Agilex *_defconfig? > Of course _defconfig is a much better place so that people can easily override it... But why do we need this in the defconfig at all? I don't know how other platforms handle this, but to me it seems like a user setting, not a thing that should be changed by general config? Regards, Simon > Regards > Ley Foon >
diff --git a/include/configs/socfpga_soc64_common.h b/include/configs/socfpga_soc64_common.h index 7237ec95e34..d51a532a929 100644 --- a/include/configs/socfpga_soc64_common.h +++ b/include/configs/socfpga_soc64_common.h @@ -79,7 +79,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void); * CONFIG_BOOTARGS goes into the environment value "bootargs". * Do note the value will override also the chosen node in FDT blob. */ -#define CONFIG_BOOTARGS "earlycon" +#define CONFIG_BOOTARGS "earlycon panic=-1" #define CONFIG_BOOTCOMMAND "run fatscript; run mmcload;run linux_qspi_enable;" \ "run mmcboot"