diff mbox series

riscv: ae350: Use fdtdec_get_addr_size_auto_noparent to parse smc reg

Message ID 20200717082444.29631-1-uboot@andestech.com
State Accepted
Commit e8fa43182a487e7542c49408eb2499cc4c0ed53c
Delegated to: Andes
Headers show
Series riscv: ae350: Use fdtdec_get_addr_size_auto_noparent to parse smc reg | expand

Commit Message

Andes July 17, 2020, 8:24 a.m. UTC
From: Rick Chen <rick@andestech.com>

Use fdtdec_get_addr_size_auto_noparent to read the "reg" property
instead of fdtdec_get_addr. This will increase the compatibility
of dtb parsing.

Signed-off-by: Rick Chen <rick@andestech.com>
---
 board/AndesTech/ax25-ae350/ax25-ae350.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Leo Liang July 17, 2020, 8:50 a.m. UTC | #1
On Fri, Jul 17, 2020 at 04:24:44PM +0800, Open Source Project uboot wrote:
> From: Rick Chen <rick@andestech.com>
> 
> Use fdtdec_get_addr_size_auto_noparent to read the "reg" property
> instead of fdtdec_get_addr. This will increase the compatibility
> of dtb parsing.
> 
> Signed-off-by: Rick Chen <rick@andestech.com>
> ---
>  board/AndesTech/ax25-ae350/ax25-ae350.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/board/AndesTech/ax25-ae350/ax25-ae350.c b/board/AndesTech/ax25-ae350/ax25-ae350.c
> index da5bc5b..231a0d5 100644
> --- a/board/AndesTech/ax25-ae350/ax25-ae350.c
> +++ b/board/AndesTech/ax25-ae350/ax25-ae350.c
> @@ -71,7 +71,8 @@ int smc_init(void)
>  	if (node < 0)
>  		return -FDT_ERR_NOTFOUND;
>  
> -	addr = fdtdec_get_addr(blob, node, "reg");
> +	addr = fdtdec_get_addr_size_auto_noparent(blob, node,
> +		"reg", 0, NULL, false);
>  
>  	if (addr == FDT_ADDR_T_NONE)
>  		return -EINVAL;
> -- 
> 2.7.4
>
Acked-by: Leo Liang <ycliang@andestech.com>
Bin Meng July 17, 2020, 9:38 a.m. UTC | #2
On Fri, Jul 17, 2020 at 4:35 PM Andes <uboot@andestech.com> wrote:
>
> From: Rick Chen <rick@andestech.com>
>
> Use fdtdec_get_addr_size_auto_noparent to read the "reg" property
> instead of fdtdec_get_addr. This will increase the compatibility
> of dtb parsing.
>
> Signed-off-by: Rick Chen <rick@andestech.com>
> ---
>  board/AndesTech/ax25-ae350/ax25-ae350.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Leo Liang July 17, 2020, 10:13 a.m. UTC | #3
On Fri, Jul 17, 2020 at 05:38:19PM +0800, Bin Meng wrote:
> On Fri, Jul 17, 2020 at 4:35 PM Andes <uboot@andestech.com> wrote:
> >
> > From: Rick Chen <rick@andestech.com>
> >
> > Use fdtdec_get_addr_size_auto_noparent to read the "reg" property
> > instead of fdtdec_get_addr. This will increase the compatibility
> > of dtb parsing.
> >
> > Signed-off-by: Rick Chen <rick@andestech.com>
> > ---
> >  board/AndesTech/ax25-ae350/ax25-ae350.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> 
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Tested-by: Leo Liang <ycliang@andestech.com>
diff mbox series

Patch

diff --git a/board/AndesTech/ax25-ae350/ax25-ae350.c b/board/AndesTech/ax25-ae350/ax25-ae350.c
index da5bc5b..231a0d5 100644
--- a/board/AndesTech/ax25-ae350/ax25-ae350.c
+++ b/board/AndesTech/ax25-ae350/ax25-ae350.c
@@ -71,7 +71,8 @@  int smc_init(void)
 	if (node < 0)
 		return -FDT_ERR_NOTFOUND;
 
-	addr = fdtdec_get_addr(blob, node, "reg");
+	addr = fdtdec_get_addr_size_auto_noparent(blob, node,
+		"reg", 0, NULL, false);
 
 	if (addr == FDT_ADDR_T_NONE)
 		return -EINVAL;