diff mbox series

rockchip: enable USB OHCI host for RockPro64

Message ID 20200525144449.399887-1-marcin@juszkiewicz.com.pl
State Accepted
Delegated to: Kever Yang
Headers show
Series rockchip: enable USB OHCI host for RockPro64 | expand

Commit Message

Marcin Juszkiewicz May 25, 2020, 2:44 p.m. UTC 
U-Boot has video output enabled so time to get keyboard working.

=> usb reset;usb tree
resetting USB...
Bus usb@fe380000: USB EHCI 1.00
Bus usb@fe3a0000: USB OHCI 1.0
Bus usb@fe3c0000: USB EHCI 1.00
Bus usb@fe3e0000: USB OHCI 1.0
Bus dwc3: usb maximum-speed not found
Register 2000140 NbrPorts 2
Starting the controller
USB XHCI 1.10
scanning bus usb@fe380000 for devices... 1 USB Device(s) found
scanning bus usb@fe3a0000 for devices... 1 USB Device(s) found
scanning bus usb@fe3c0000 for devices... 1 USB Device(s) found
scanning bus usb@fe3e0000 for devices... 3 USB Device(s) found
scanning bus dwc3 for devices... cannot reset port 1!?
2 USB Device(s) found
       scanning usb for storage devices... 2 Storage Device(s) found
USB device tree:
  1  Hub (480 Mb/s, 0mA)
     u-boot EHCI Host Controller

  1  Hub (12 Mb/s, 0mA)
      U-Boot Root Hub

  1  Hub (480 Mb/s, 0mA)
     u-boot EHCI Host Controller

  1  Hub (12 Mb/s, 0mA)
  |   U-Boot Root Hub
  |
  +-2  Hub (12 Mb/s, 100mA)
    |  ALCOR Generic USB Hub
    |
    +-3  Mass Storage (12 Mb/s, 200mA)
         Kingston DT 101 G2 001478544887BB3157380157

  1  Hub (5 Gb/s, 0mA)
  |  U-Boot XHCI Host Controller
  |
  +-2  Mass Storage (5 Gb/s, 76mA)
       ADATA ADATA USB Flash Drive 1520405012240002

Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
---
 configs/rockpro64-rk3399_defconfig | 2 ++
 include/configs/rockpro64_rk3399.h | 2 ++
 2 files changed, 4 insertions(+)

Comments

Kever Yang May 29, 2020, 10:01 a.m. UTC | #1 
On 2020/5/25 下午10:44, Marcin Juszkiewicz wrote:
> U-Boot has video output enabled so time to get keyboard working.
>
> => usb reset;usb tree
> resetting USB...
> Bus usb@fe380000: USB EHCI 1.00
> Bus usb@fe3a0000: USB OHCI 1.0
> Bus usb@fe3c0000: USB EHCI 1.00
> Bus usb@fe3e0000: USB OHCI 1.0
> Bus dwc3: usb maximum-speed not found
> Register 2000140 NbrPorts 2
> Starting the controller
> USB XHCI 1.10
> scanning bus usb@fe380000 for devices... 1 USB Device(s) found
> scanning bus usb@fe3a0000 for devices... 1 USB Device(s) found
> scanning bus usb@fe3c0000 for devices... 1 USB Device(s) found
> scanning bus usb@fe3e0000 for devices... 3 USB Device(s) found
> scanning bus dwc3 for devices... cannot reset port 1!?
> 2 USB Device(s) found
>         scanning usb for storage devices... 2 Storage Device(s) found
> USB device tree:
>    1  Hub (480 Mb/s, 0mA)
>       u-boot EHCI Host Controller
>
>    1  Hub (12 Mb/s, 0mA)
>        U-Boot Root Hub
>
>    1  Hub (480 Mb/s, 0mA)
>       u-boot EHCI Host Controller
>
>    1  Hub (12 Mb/s, 0mA)
>    |   U-Boot Root Hub
>    |
>    +-2  Hub (12 Mb/s, 100mA)
>      |  ALCOR Generic USB Hub
>      |
>      +-3  Mass Storage (12 Mb/s, 200mA)
>           Kingston DT 101 G2 001478544887BB3157380157
>
>    1  Hub (5 Gb/s, 0mA)
>    |  U-Boot XHCI Host Controller
>    |
>    +-2  Mass Storage (5 Gb/s, 76mA)
>         ADATA ADATA USB Flash Drive 1520405012240002
>
> Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   configs/rockpro64-rk3399_defconfig | 2 ++
>   include/configs/rockpro64_rk3399.h | 2 ++
>   2 files changed, 4 insertions(+)
>
> diff --git configs/rockpro64-rk3399_defconfig configs/rockpro64-rk3399_defconfig
> index 53abce0057..205be70cb0 100644
> --- configs/rockpro64-rk3399_defconfig
> +++ configs/rockpro64-rk3399_defconfig
> @@ -52,6 +52,8 @@ CONFIG_USB_XHCI_HCD=y
>   CONFIG_USB_XHCI_DWC3=y
>   CONFIG_USB_EHCI_HCD=y
>   CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
>   CONFIG_USB_HOST_ETHER=y
>   CONFIG_USB_ETHER_ASIX=y
>   CONFIG_USB_ETHER_ASIX88179=y
> diff --git include/configs/rockpro64_rk3399.h include/configs/rockpro64_rk3399.h
> index 7a72cf6049..37a08b2c00 100644
> --- include/configs/rockpro64_rk3399.h
> +++ include/configs/rockpro64_rk3399.h
> @@ -17,4 +17,6 @@
>   
>   #define SDRAM_BANK_SIZE			(2UL << 30)
>   
> +#define CONFIG_USB_OHCI_NEW
> +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS     2
>   #endif
Kever Yang June 1, 2020, 12:55 a.m. UTC | #2 
On 2020/5/29 下午6:01, Kever Yang wrote:
>
> On 2020/5/25 下午10:44, Marcin Juszkiewicz wrote:
>> U-Boot has video output enabled so time to get keyboard working.
>>
>> => usb reset;usb tree
>> resetting USB...
>> Bus usb@fe380000: USB EHCI 1.00
>> Bus usb@fe3a0000: USB OHCI 1.0
>> Bus usb@fe3c0000: USB EHCI 1.00
>> Bus usb@fe3e0000: USB OHCI 1.0
>> Bus dwc3: usb maximum-speed not found
>> Register 2000140 NbrPorts 2
>> Starting the controller
>> USB XHCI 1.10
>> scanning bus usb@fe380000 for devices... 1 USB Device(s) found
>> scanning bus usb@fe3a0000 for devices... 1 USB Device(s) found
>> scanning bus usb@fe3c0000 for devices... 1 USB Device(s) found
>> scanning bus usb@fe3e0000 for devices... 3 USB Device(s) found
>> scanning bus dwc3 for devices... cannot reset port 1!?
>> 2 USB Device(s) found
>>         scanning usb for storage devices... 2 Storage Device(s) found
>> USB device tree:
>>    1  Hub (480 Mb/s, 0mA)
>>       u-boot EHCI Host Controller
>>
>>    1  Hub (12 Mb/s, 0mA)
>>        U-Boot Root Hub
>>
>>    1  Hub (480 Mb/s, 0mA)
>>       u-boot EHCI Host Controller
>>
>>    1  Hub (12 Mb/s, 0mA)
>>    |   U-Boot Root Hub
>>    |
>>    +-2  Hub (12 Mb/s, 100mA)
>>      |  ALCOR Generic USB Hub
>>      |
>>      +-3  Mass Storage (12 Mb/s, 200mA)
>>           Kingston DT 101 G2 001478544887BB3157380157
>>
>>    1  Hub (5 Gb/s, 0mA)
>>    |  U-Boot XHCI Host Controller
>>    |
>>    +-2  Mass Storage (5 Gb/s, 76mA)
>>         ADATA ADATA USB Flash Drive 1520405012240002
>>
>> Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
>
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Applied to u-boot-rockchip master.

Thanks,
- Kever
diff mbox series

Patch

diff --git configs/rockpro64-rk3399_defconfig configs/rockpro64-rk3399_defconfig
index 53abce0057..205be70cb0 100644
--- configs/rockpro64-rk3399_defconfig
+++ configs/rockpro64-rk3399_defconfig
@@ -52,6 +52,8 @@  CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
 CONFIG_USB_ETHER_ASIX88179=y
diff --git include/configs/rockpro64_rk3399.h include/configs/rockpro64_rk3399.h
index 7a72cf6049..37a08b2c00 100644
--- include/configs/rockpro64_rk3399.h
+++ include/configs/rockpro64_rk3399.h
@@ -17,4 +17,6 @@ 
 
 #define SDRAM_BANK_SIZE			(2UL << 30)
 
+#define CONFIG_USB_OHCI_NEW
+#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS     2
 #endif