| Message ID | 20200512100207.13183-1-matthias.bgg@kernel.org |
|---|---|
| State | Accepted |
| Commit | 7acdc9aa096d4e2a4c32d887fdbf4cee381a1e92 |
| Delegated to: | Matthias Brugger |
| Headers | show |
| Series | [1/2] mmc: sdhci: Use debug for not supported SDMA info message | expand |
> Subject: [PATCH 1/2] mmc: sdhci: Use debug for not supported SDMA info > message > > From: Matthias Brugger <mbrugger@suse.com> > > If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, > we no longer error out. Instead we do not enable it in the host. > Change the output from printf to debug as this isn't an error but only > additional information now. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > --- > > drivers/mmc/sdhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index > 6e8f6e3d17..8bb4393ce1 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct > sdhci_host *host, > if ((caps & SDHCI_CAN_DO_SDMA)) { > host->flags |= USE_SDMA; > } else { > - printf("%s: Your controller doesn't support SDMA!!\n", > - __func__); > + debug("%s: Your controller doesn't support SDMA!!\n", > + __func__); > } > #endif > #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA) > -- Reviewed-by: Peng Fan <peng.fan@nxp.com>
On 12/05/2020 12:02, matthias.bgg@kernel.org wrote: > From: Matthias Brugger <mbrugger@suse.com> > > If CONFIG_MMC_SDHCI_SDMA is enabled but the HW could not support it, > we no longer error out. Instead we do not enable it in the host. > Change the output from printf to debug as this isn't an error but only > additional information now. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> Queued for rpi-next > --- > > drivers/mmc/sdhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index 6e8f6e3d17..8bb4393ce1 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, > if ((caps & SDHCI_CAN_DO_SDMA)) { > host->flags |= USE_SDMA; > } else { > - printf("%s: Your controller doesn't support SDMA!!\n", > - __func__); > + debug("%s: Your controller doesn't support SDMA!!\n", > + __func__); > } > #endif > #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA) >
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index 6e8f6e3d17..8bb4393ce1 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -744,8 +744,8 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host, if ((caps & SDHCI_CAN_DO_SDMA)) { host->flags |= USE_SDMA; } else { - printf("%s: Your controller doesn't support SDMA!!\n", - __func__); + debug("%s: Your controller doesn't support SDMA!!\n", + __func__); } #endif #if CONFIG_IS_ENABLED(MMC_SDHCI_ADMA)