diff mbox series

[06/10] arm: stm32mp: improve the error message for smc

Message ID 20200212183744.5309-7-patrick.delaunay@st.com
State Accepted
Commit 718f7bf7ca31277fbe5fdf49b6fa897736b7f36d
Delegated to: Patrick Delaunay
Headers show
Series stm32mp1: board and SOC identifications | expand

Commit Message

Patrick DELAUNAY Feb. 12, 2020, 6:37 p.m. UTC
Add the SMC code and operation for trace on errors.

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

 arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Patrice CHOTARD March 18, 2020, 10:10 a.m. UTC | #1
On 2/12/20 7:37 PM, Patrick Delaunay wrote:
> Add the SMC code and operation for trace on errors.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
>  arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h b/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h
> index 7b9167c356..4ad14f963b 100644
> --- a/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h
> +++ b/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h
> @@ -46,8 +46,8 @@ static inline u32 stm32_smc(u32 svc, u8 op, u32 data1, u32 data2, u32 *result)
>  	arm_smccc_smc(svc, op, data1, data2, 0, 0, 0, 0, &res);
>  
>  	if (res.a0) {
> -		pr_err("%s: Failed to exec in secure mode (err = %ld)\n",
> -		       __func__, res.a0);
> +		pr_err("%s: Failed to exec svc=%x op=%x in secure mode (err = %ld)\n",
> +		       __func__, svc, op, res.a0);
>  		return -EINVAL;
>  	}
>  	if (result)

Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

Patrice
Patrick DELAUNAY March 24, 2020, 8:36 a.m. UTC | #2
Hi,

> From: Patrick DELAUNAY <patrick.delaunay@st.com>
> Sent: mercredi 12 février 2020 19:38
> 
> Add the SMC code and operation for trace on errors.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---

Applied to u-boot-stm/next, thanks!

Regards

Patrick
diff mbox series

Patch

diff --git a/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h b/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h
index 7b9167c356..4ad14f963b 100644
--- a/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h
+++ b/arch/arm/mach-stm32mp/include/mach/stm32mp1_smc.h
@@ -46,8 +46,8 @@  static inline u32 stm32_smc(u32 svc, u8 op, u32 data1, u32 data2, u32 *result)
 	arm_smccc_smc(svc, op, data1, data2, 0, 0, 0, 0, &res);
 
 	if (res.a0) {
-		pr_err("%s: Failed to exec in secure mode (err = %ld)\n",
-		       __func__, res.a0);
+		pr_err("%s: Failed to exec svc=%x op=%x in secure mode (err = %ld)\n",
+		       __func__, svc, op, res.a0);
 		return -EINVAL;
 	}
 	if (result)