diff mbox series

[2/3] mx8mm_evk: spl: Staticize functions

Message ID 20200114185501.4993-2-alifer.wsdm@gmail.com
State Accepted
Commit 62cdfdcc81dc0af1ebabbf589ddb1ecc36351a47
Delegated to: Stefano Babic
Headers show
Series [1/3] imx8m: clock_imx8mm: Staticize functions | expand

Commit Message

Alifer Moraes Jan. 14, 2020, 6:55 p.m. UTC
Functions spl_dram_init() and power_init_board() are used only in
the scope of this file, so make them static to fix the following sparse
warnings:

board/freescale/imx8mm_evk/spl.c:40:6: warning: no previous prototype
for ‘spl_dram_init’ [-Wmissing-prototypes]

board/freescale/imx8mm_evk/spl.c:85:5: warning: no previous prototype
for ‘power_init_board’ [-Wmissing-prototypes]

Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
---
 board/freescale/imx8mm_evk/spl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Babic Jan. 20, 2020, 8:18 p.m. UTC | #1
> Functions spl_dram_init() and power_init_board() are used only in
> the scope of this file, so make them static to fix the following sparse
> warnings:
> board/freescale/imx8mm_evk/spl.c:40:6: warning: no previous prototype
> for ‘spl_dram_init’ [-Wmissing-prototypes]
> board/freescale/imx8mm_evk/spl.c:85:5: warning: no previous prototype
> for ‘power_init_board’ [-Wmissing-prototypes]
> Signed-off-by: Alifer Moraes <alifer.wsdm@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/board/freescale/imx8mm_evk/spl.c b/board/freescale/imx8mm_evk/spl.c
index 2d08f9a563..e28f795676 100644
--- a/board/freescale/imx8mm_evk/spl.c
+++ b/board/freescale/imx8mm_evk/spl.c
@@ -37,7 +37,7 @@  int spl_board_boot_device(enum boot_device boot_dev_spl)
 	}
 }
 
-void spl_dram_init(void)
+static void spl_dram_init(void)
 {
 	ddr_init(&dram_timing);
 }
@@ -82,7 +82,7 @@  int board_early_init_f(void)
 	return 0;
 }
 
-int power_init_board(void)
+static int power_init_board(void)
 {
 	struct udevice *dev;
 	int ret;