diff mbox series

[U-Boot,v3,6/6] cmd: pxe: Fix checkpatch WARNING/CHECK

Message ID 20191125080741.2215-7-patrice.chotard@st.com
State Accepted
Commit 31839dc2d2bb0ecfe0ec0d736e09c8d9d3020977
Delegated to: Tom Rini
Headers show
Series cmd: remove NET and CMD_NET dependency for CMD_PXE | expand

Commit Message

Patrice CHOTARD Nov. 25, 2019, 8:07 a.m. UTC 
Fix checkpatch WARNING and CHECK issues

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>

---

 cmd/pxe.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Comments

Tom Rini Dec. 6, 2019, 9:48 p.m. UTC | #1 
On Mon, Nov 25, 2019 at 09:07:41AM +0100, Patrice Chotard wrote:

> Fix checkpatch WARNING and CHECK issues
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/cmd/pxe.c b/cmd/pxe.c
index 757e186d32..ca1e1b188b 100644
--- a/cmd/pxe.c
+++ b/cmd/pxe.c
@@ -67,7 +67,7 @@  do_pxe_get(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return 1;
 
 	err = strict_strtoul(pxefile_addr_str, 16,
-				(unsigned long *)&pxefile_addr_r);
+			     (unsigned long *)&pxefile_addr_r);
 	if (err < 0)
 		return 1;
 
@@ -129,7 +129,7 @@  do_pxe_boot(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 	cfg = parse_pxefile(cmdtp, pxefile_addr_r);
 
-	if (cfg == NULL) {
+	if (!cfg) {
 		printf("Error parsing config file\n");
 		return 1;
 	}
@@ -169,10 +169,9 @@  static int do_pxe(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	return CMD_RET_USAGE;
 }
 
-U_BOOT_CMD(
-	pxe, 3, 1, do_pxe,
-	"commands to get and boot from pxe files",
-	"get - try to retrieve a pxe file using tftp\npxe "
-	"boot [pxefile_addr_r] - boot from the pxe file at pxefile_addr_r\n"
+U_BOOT_CMD(pxe, 3, 1, do_pxe,
+	   "commands to get and boot from pxe files",
+	   "get - try to retrieve a pxe file using tftp\n"
+	   "pxe boot [pxefile_addr_r] - boot from the pxe file at pxefile_addr_r\n"
 );
 #endif