diff mbox series

[U-Boot,2/2] drivers: net: fsl_enetc: fix RGMII configuration

Message ID 20191026003912.31511-2-michael@walle.cc
State Accepted
Commit 29a6617ada631c1f86512028218491e3c15500cc
Delegated to: Priyanka Jain
Headers show
Series [U-Boot,1/2] drivers: net: fsl_enetc: set phydev->node | expand

Commit Message

Michael Walle Oct. 26, 2019, 12:39 a.m. UTC
Add the missing RGMII PHY modes in which case the MAC has configure its
RGMII settings. The only difference between these modes is the RX and
TX delay configuration. A user might choose any RGMII mode in the device
tree.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/net/fsl_enetc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Alexandru Marginean Oct. 29, 2019, 2:57 p.m. UTC | #1
On 10/26/2019 2:39 AM, Michael Walle wrote:
> Add the missing RGMII PHY modes in which case the MAC has configure its
> RGMII settings. The only difference between these modes is the RX and
> TX delay configuration. A user might choose any RGMII mode in the device
> tree.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>   drivers/net/fsl_enetc.c | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Alex Marginean <alexm.osslist@gmail.com>

Thanks!
Priyanka Jain Nov. 11, 2019, 3:23 p.m. UTC | #2
>-----Original Message-----
>From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Michael Walle
>Sent: Saturday, October 26, 2019 6:09 AM
>To: u-boot@lists.denx.de
>Cc: Joe Hershberger <joe.hershberger@ni.com>; Catalin Horghidan
><catalin.horghidan@nxp.com>
>Subject: [U-Boot] [PATCH 2/2] drivers: net: fsl_enetc: fix RGMII configuration
>
>Add the missing RGMII PHY modes in which case the MAC has configure its
>RGMII settings. The only difference between these modes is the RX and TX
>delay configuration. A user might choose any RGMII mode in the device tree.
>
>Signed-off-by: Michael Walle <michael@walle.cc>
>---

Applied to fsl-qoriq master, awaiting upstream.

Thanks
priyankajain
diff mbox series

Patch

diff --git a/drivers/net/fsl_enetc.c b/drivers/net/fsl_enetc.c
index 86b80c8941..0ca7e838a8 100644
--- a/drivers/net/fsl_enetc.c
+++ b/drivers/net/fsl_enetc.c
@@ -191,6 +191,9 @@  static void enetc_start_pcs(struct udevice *dev)
 		enetc_init_sgmii(dev);
 		break;
 	case PHY_INTERFACE_MODE_RGMII:
+	case PHY_INTERFACE_MODE_RGMII_ID:
+	case PHY_INTERFACE_MODE_RGMII_RXID:
+	case PHY_INTERFACE_MODE_RGMII_TXID:
 		enetc_init_rgmii(dev);
 		break;
 	case PHY_INTERFACE_MODE_XGMII: